Skip to contentSkip to conversation

Minor bug fixes from UPF38

PATCH In review Brian Gix 2 participants 4 messages Feb 19, 2011 – Feb 20, 2011 Bluetooth drivers

lore
Share & tools
lore

Brian Gix

author
#0 lore raw

cover Minor bug fixes from UPF38

--
Brian Gix
[email protected]
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum

author
#1 lore raw

PATCH 1/2 Add missing UUID16 field to Included Svc Attribute

---
 attrib/example.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
attrib/example.c +2 -1
index cd18168..395650a 100644
@@ -124,7 +124,8 @@ static int register_attributes(void)
 	/* Thermometer: Include */
 	att_put_u16(0x0550, &atval[0]);
 	att_put_u16(0x0568, &atval[2]);
-	attrib_db_add(0x0202, &uuid, ATT_NONE, ATT_NOT_PERMITTED, atval, 4);
+	att_put_u16(VENDOR_SPECIFIC_SVC_UUID, &atval[4]);
+	attrib_db_add(0x0202, &uuid, ATT_NONE, ATT_NOT_PERMITTED, atval, 6);
 
 	/* Thermometer: temperature characteristic */
 	sdp_uuid16_create(&uuid, GATT_CHARAC_UUID);
Signature · 6 lines
1.7.1
--
Brian Gix
[email protected]
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
author
#2 lore raw

PATCH 2/2 Fix Crash where MTU allowed to be set too large

In reply to Brian Gix

As previously written, a remote device could request, and we would accept an MTU larger than what we could support.

---
 src/attrib-server.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
src/attrib-server.c +1 -1
index 6966ad0..4285f6e 100644
@@ -639,7 +639,7 @@ static uint16_t write_value(struct gatt_channel *channel, uint16_t handle,
 static uint16_t mtu_exchange(struct gatt_channel *channel, uint16_t mtu,
 		uint8_t *pdu, int len)
 {
-	channel->mtu = MIN(mtu, ATT_MAX_MTU);
+	channel->mtu = MIN(mtu, channel->mtu);
 
 	return enc_mtu_resp(channel->mtu, pdu, len);
 }
Signature · 6 lines
1.7.1
--
Brian Gix
[email protected]
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
#3 lore raw

Re: [PATCH 2/2] Fix Crash where MTU allowed to be set too large

Hi Brian,

Quoted 5 lines · Brian Gix

As previously written, a remote device could request, and we would accept an MTU larger than what we could support.

---
 src/attrib-server.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Both patches have been pushed upstream. Thanks.

Johan