be2net: fixes in ethtool selftest

PATCH In review Ajit Khaparde 1 participant 1 message Feb 20, 2011

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Ajit Khaparde

author

2011-02-20 21:41 UTC #0 lore raw

PATCH 2/6 be2net: fixes in ethtool selftest

Quoted 2 lines

add missing separator between items in ethtool self_test array fix reporting of test resluts when link is down and

when selftest command fails.

From: Suresh R <[email protected]>

Signed-off-by Ajit Khaparde <[email protected]>

---
 drivers/net/benet/be_ethtool.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

drivers/net/benet/be_ethtool.c +3 -2

index 82a9a27..0833cbd 100644
@@ -127,7 +127,7 @@ static const char et_self_tests[][ETH_GSTRING_LEN] = {
 	"MAC Loopback test",
 	"PHY Loopback test",
 	"External Loopback test",
-	"DDR DMA test"
+	"DDR DMA test",
 	"Link test"
 };

@@ -642,7 +642,8 @@ be_self_test(struct net_device *netdev, struct ethtool_test *test, u64 *data)
 				&qos_link_speed) != 0) {
 		test->flags |= ETH_TEST_FL_FAILED;
 		data[4] = -1;
-	} else if (mac_speed) {
+	} else if (!mac_speed) {
+		test->flags |= ETH_TEST_FL_FAILED;
 		data[4] = 1;
 	}
 }

Signature · 1 line

1.7.1