Skip to contentSkip to conversation

bonding: fix sparse warning

PATCH Applied Stephen Hemminger 3 participants 3 messages Feb 23, 2011 – Feb 28, 2011

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bonding: fix sparse warning

Fix use of zero where NULL expected. And wrap long line.

drivers/net/bonding/bonding.h +3 -2
@@ -265,7 +265,8 @@ struct bonding {
  *
  * Caller must hold bond lock for read
  */
-static inline struct slave *bond_get_slave_by_dev(struct bonding *bond, struct net_device *slave_dev)
+static inline struct slave *bond_get_slave_by_dev(struct bonding *bond,
+						  struct net_device *slave_dev)
 {
 	struct slave *slave = NULL;
 	int i;
@@ -276,7 +277,7 @@ static inline struct slave *bond_get_sla
 		}
 	}
 
-	return 0;
+	return NULL;
 }
 
 static inline struct bonding *bond_get_bond_by_slave(struct slave *slave)
#1 lore raw
Quoted 3 lines · Stephen Hemminger

Fix use of zero where NULL expected. And wrap long line.

Quoted 21 lines
drivers/net/bonding/bonding.h +3 -2
@@ -265,7 +265,8 @@ struct bonding {
 *
 * Caller must hold bond lock for read
 */
-static inline struct slave *bond_get_slave_by_dev(struct bonding *bond, struct net_device *slave_dev)
+static inline struct slave *bond_get_slave_by_dev(struct bonding *bond,
+						  struct net_device *slave_dev)
 {
 	struct slave *slave = NULL;
 	int i;
@@ -276,7 +277,7 @@ static inline struct slave *bond_get_sla
 		}
 	}
 
-	return 0;
+	return NULL;
 }
 
 static inline struct bonding *bond_get_bond_by_slave(struct slave *slave)