e1000: fix sparse warning

PATCH In review Stephen Hemminger 3 participants 3 messages Feb 23, 2011 – Feb 24, 2011

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Stephen Hemminger

author

2011-02-23 18:12 UTC #0 lore raw

PATCH 1/1 e1000: fix sparse warning

Sparse complains because the e1000 driver is calling ioread on a pointer not tagged as __iomem.

Signed-off-by Stephen Hemminger <[email protected]>

drivers/net/e1000/e1000_osdep.h +2 -1

@@ -42,7 +42,8 @@
 #define GBE_CONFIG_RAM_BASE \
 	((unsigned int)(CONFIG_RAM_BASE + GBE_CONFIG_OFFSET))
 
-#define GBE_CONFIG_BASE_VIRT    phys_to_virt(GBE_CONFIG_RAM_BASE)
+#define GBE_CONFIG_BASE_VIRT \
+	((void __iomem *)phys_to_virt(GBE_CONFIG_RAM_BASE))
 
 #define GBE_CONFIG_FLASH_WRITE(base, offset, count, data) \
 	(iowrite16_rep(base + offset, data, count))

Brandeburg, Jesse

Reviewed-by on v1 1/1

2011-02-23 18:24 UTC #1 lore raw

Quoted 4 lines · Stephen Hemminger

Sparse complains because the e1000 driver is calling ioread on a pointer not tagged as __iomem.
Signed-off-by Stephen Hemminger <[email protected]>

Seems fine, thanks Stephen.

Reviewed-by Jesse Brandeburg <[email protected]>

Jeff Kirsher

2011-02-24 00:03 UTC #2 lore raw

In reply to Stephen Hemminger

Quoted 5 lines · Stephen Hemminger

Sparse complains because the e1000 driver is calling ioread on a pointer
not tagged as __iomem.
Signed-off-by Stephen Hemminger <[email protected]>

Thanks Stephen! I have added this patch to my queue of e1000 patches.