Skip to contentSkip to conversation

xhci: Fix cycle bit calculation during stall handling.

RFC Sarah Sharp 4 participants 4 messages Feb 24, 2011 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): e1b54e2b29b06b62174de33a74fa7469173abc92.1298514502.git.sarah.a.sharp@linux.intel.com

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 9 lines · Sergei Shtylyov

Hello.

Review

Quoted 3 lines · Sarah Sharp
(quoted diff) +3 -0
+	if (ep_ring->first_seg == ep_ring->first_seg->next&&
+			state->new_deq_ptr < dev->eps[ep_index].stopped_trb)
+			state->new_cycle_state ^= 0x1;

The last line seems overindented.

Hi Sergei,

checkpatch.pl doesn't complain about it. It is not a good use of my time to respin this patch for one stylistic change that is not a violation of the Kernel community norms.

I really feel strongly that you are wasting the community's time by commenting on style when it is only a violation of your personal style, without providing any useful feedback on the code itself.

I feel so strongly that I'm seriously considering setting up a feedback bot for you. It would run any patch you reply to through checkpatch.pl, and send you a small reminder when the patch passes, but you complained about style. I think it would allow you to have a sense of how frustrating it is to receive these unnecessary stylistic comments.

Sarah Sharp

#4 lore raw
Quoted 21 lines · Sarah Sharp
Quoted 9 lines · Sergei Shtylyov

Hello.

Review

Quoted 3 lines · Sarah Sharp
(quoted diff) +3 -0
+	if (ep_ring->first_seg == ep_ring->first_seg->next&&
+			state->new_deq_ptr < dev->eps[ep_index].stopped_trb)
+			state->new_cycle_state ^= 0x1;

The last line seems overindented.

Hi Sergei,

checkpatch.pl doesn't complain about it. It is not a good use of my time to respin this patch for one stylistic change that is not a violation of the Kernel community norms.

I really feel strongly that you are wasting the community's time by commenting on style when it is only a violation of your personal style, without providing any useful feedback on the code itself.

Quoted 5 lines

I feel so strongly that I'm seriously considering setting up a feedback bot for you. It would run any patch you reply to through checkpatch.pl, and send you a small reminder when the patch passes, but you complained about style. I think it would allow you to have a sense of how frustrating it is to receive these unnecessary stylistic comments.

I totally agree, and almost always just filter Sergei's comments away as the large majority of them are pointless and distract from the technical content being discussed.

Sergei, you have been warned of this before, please change in the future.

thanks,

greg k-h

#5 lore raw
Quoted 28 lines · Greg KH
Quoted 21 lines · Sarah Sharp
Quoted 9 lines · Sergei Shtylyov

Hello.

Review

Quoted 3 lines · Sarah Sharp
(quoted diff) +3 -0
+	if (ep_ring->first_seg == ep_ring->first_seg->next&&
+			state->new_deq_ptr < dev->eps[ep_index].stopped_trb)
+			state->new_cycle_state ^= 0x1;

The last line seems overindented.

Hi Sergei,

checkpatch.pl doesn't complain about it. It is not a good use of my time to respin this patch for one stylistic change that is not a violation of the Kernel community norms.

I really feel strongly that you are wasting the community's time by commenting on style when it is only a violation of your personal style, without providing any useful feedback on the code itself.

Quoted 5 lines

I feel so strongly that I'm seriously considering setting up a feedback bot for you. It would run any patch you reply to through checkpatch.pl, and send you a small reminder when the patch passes, but you complained about style. I think it would allow you to have a sense of how frustrating it is to receive these unnecessary stylistic comments.

Quoted 4 lines

I totally agree, and almost always just filter Sergei's comments away as the large majority of them are pointless and distract from the technical content being discussed.

I am sorry, but in this case the 'if' body does run together with the conditional. No need to repost the patch for this, of course, but might be worth fixing locally before pushing into a public branch.

Thanks.

Signature · 1 line
Dmitry
#6 lore raw
In reply to Sarah Sharp

Hello.

Quoted 8 lines · Sarah Sharp
Quoted 5 lines

Review

Quoted 3 lines
(quoted diff) +3 -0
+	if (ep_ring->first_seg == ep_ring->first_seg->next&&
+			state->new_deq_ptr < dev->eps[ep_index].stopped_trb)
+			state->new_cycle_state ^= 0x1;

The last line seems overindented.

Hi Sergei,

Quoted 7 lines

checkpatch.pl doesn't complain about it. It is not a good use of my time to respin this patch for one stylistic change that is not a violation of the Kernel community norms.

I really feel strongly that you are wasting the community's time by commenting on style when it is only a violation of your personal style, without providing any useful feedback on the code itself.

Not only of my personal style, as Dmitry's comment has shown. Like him, I
had some trouble seeing where the *if* expression ends and the branch starts, due to both lines starting on the same level of indentation...

Quoted 5 lines

I feel so strongly that I'm seriously considering setting up a feedback bot for you. It would run any patch you reply to through checkpatch.pl, and send you a small reminder when the patch passes, but you complained about style. I think it would allow you to have a sense of how frustrating it is to receive these unnecessary stylistic comments.

Well, I'll try to save you that trouble and avoid commenting on your patches
in the future.

Quoted 1 line

Sarah Sharp

WBR, Sergei