config: stop leaking memory on config reload

Resolves: rhbz#680155

---
 config/plugins/xml/config.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

index 1db23da..7dcf8ba 100644
@@ -142,7 +142,5 @@ fail:
 	if (doc)
 		xmlFreeDoc(doc);
 
-	xmlCleanupParser();
-
 	return err;
 }

1.7.4

ACK, but seriously, a function called "xmlCleanupParser()" shouldn't leak memory ...

Lon Hohberger - Red Hat, Inc.

It's probably just sweeping it under the rug :P

Tim

Tim Serong <[email protected]>
Senior Clustering Engineer, OPS Engineering, Novell Inc.

I think the problem is triggered by the fact that initial load of config is done in the main thread, while subsequent reloads are done in another thread. libxml2 is said to be thread friendly only under certain circumstances and it's not completely tested for it. The documentation does mention that and since we don't really have a need to use the whole thread code here, let's take the easy approach.

In my tests, where i was calling only xmlCleanupParser, it was not leaking at all. The leak happens only when there is an xmlParseFile and xmlFreeDoc associated with it. Weird but well....

Fabio