ethtool: prevent null pointer dereference with NTUPLE set but no set_rx_ntuple

PATCH New Alexander Duyck 1 participant 1 message Feb 26, 2011

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Alexander Duyck

author

2011-02-26 00:42 UTC #0 lore raw

PATCH 1/1 ethtool: prevent null pointer dereference with NTUPLE set but no set_rx_ntuple

This change is meant to prevent a possible null pointer dereference if NETIF_F_NTUPLE is defined but the set_rx_ntuple function pointer is not.

This issue appears to affect all kernels since 2.6.34.

Signed-off-by Alexander Duyck <[email protected]>

---

 net/core/ethtool.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

net/core/ethtool.c +3 -0

index c1a71bb..4843674 100644
@@ -893,6 +893,9 @@ static noinline_for_stack int ethtool_set_rx_ntuple(struct net_device *dev,
 	struct ethtool_rx_ntuple_flow_spec_container *fsc = NULL;
 	int ret;
 
+	if (!ops->set_rx_ntuple)
+		return -EOPNOTSUPP;
+
 	if (!(dev->features & NETIF_F_NTUPLE))
 		return -EINVAL;