Skip to contentSkip to conversation

sony-laptop: make a couple variables static

PATCH Applied Dan Carpenter 3 participants 3 messages Feb 26, 2011 – Mar 11, 2011

Subsystems (3)
Kernel janitors x86 platform drivers Sony vaio control device driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/4 sony-laptop: make a couple variables static

Sparse complains that these variables should be static.

Signed-off-by Dan Carpenter <[email protected]>
drivers/platform/x86/sony-laptop.c +2 -2
index a0ba0e7..a7b9c72 100644
@@ -745,7 +745,7 @@ struct sony_nc_handles {
 	struct device_attribute devattr;
 };
 
-struct sony_nc_handles *handles;
+static struct sony_nc_handles *handles;
 
 static ssize_t sony_nc_handles_show(struct device *dev,
 		struct device_attribute *attr, char *buffer)

@@ -1358,7 +1358,7 @@ struct kbd_backlight {
 	struct device_attribute timeout_attr;
 };
 
-struct kbd_backlight *kbdbl_handle;
+static struct kbd_backlight *kbdbl_handle;
 
 static ssize_t __sony_nc_kbd_backlight_mode_set(u8 value)
 {
maintainer Acked-by on v1 1/4
#1 lore raw
Quoted 3 lines · Dan Carpenter

Sparse complains that these variables should be static.

Signed-off-by Dan Carpenter <[email protected]>
Acked-by Mattia Dongili <[email protected]>
Quoted 22 lines
drivers/platform/x86/sony-laptop.c +2 -2
index a0ba0e7..a7b9c72 100644
@@ -745,7 +745,7 @@ struct sony_nc_handles {
 	struct device_attribute devattr;
 };
 
-struct sony_nc_handles *handles;
+static struct sony_nc_handles *handles;
 
 static ssize_t sony_nc_handles_show(struct device *dev,
 		struct device_attribute *attr, char *buffer)

@@ -1358,7 +1358,7 @@ struct kbd_backlight {
 	struct device_attribute timeout_attr;
 };
 
-struct kbd_backlight *kbdbl_handle;
+static struct kbd_backlight *kbdbl_handle;
 
 static ssize_t __sony_nc_kbd_backlight_mode_set(u8 value)
 {
Signature · 2 lines
mattia
:wq!