Skip to contentSkip to conversation

MTX-1: make au1000_eth probes all PHY addresses

PATCH Applied Florian Fainelli 2 participants 2 messages Feb 27, 2011 – Mar 4, 2011 MIPS

lore
Share & tools
lore

Florian Fainelli

author
#0 lore raw

PATCH 1/1 MTX-1: make au1000_eth probes all PHY addresses

From: Florian Fainelli <[email protected]>

When au1000_eth probes the MII bus for PHY address, if we do not set au1000_eth platform data's phy_search_highest_address, the MII probing logic will exit early and will assume a valid PHY is found at address 0. For MTX-1, the PHY is at address 31, and without this patch, the link detection/speed/duplex would not work correctly.

CC [email protected]
Signed-off-by Florian Fainelli <[email protected]>

---
Stable: 2.6.34+

arch/mips/alchemy/mtx-1/platform.c +9 -0
index e30e42a..956f946 100644
@@ -28,6 +28,8 @@
 #include <linux/mtd/physmap.h>
 #include <mtd/mtd-abi.h>
 
+#include <asm/mach-au1x00/au1xxx_eth.h>
+
 static struct gpio_keys_button mtx1_gpio_button[] = {
 	{
 		.gpio = 207,

@@ -140,10 +142,17 @@ static struct __initdata platform_device * mtx1_devs[] = {
 	&mtx1_mtd,
 };
 
+static struct au1000_eth_platform_data mtx1_au1000_eth0_pdata = {
+	.phy_search_highest_addr	= 1,
+	.phy1_search_mac0 		= 1,
+};
+
 static int __init mtx1_register_devices(void)
 {
 	int rc;
 
+	au1xxx_override_eth_cfg(0, &mtx1_au1000_eth0_pdata);
+
 	rc = gpio_request(mtx1_gpio_button[0].gpio,
 					mtx1_gpio_button[0].desc);
 	if (rc < 0) {
Signature · 1 line
1.7.1
Applied
#1 lore raw
Quoted 8 lines · Florian Fainelli

From: Florian Fainelli <[email protected]>

When au1000_eth probes the MII bus for PHY address, if we do not set au1000_eth platform data's phy_search_highest_address, the MII probing logic will exit early and will assume a valid PHY is found at address 0. For MTX-1, the PHY is at address 31, and without this patch, the link detection/speed/duplex would not work correctly.

Quoted 4 lines
CC [email protected]
Signed-off-by Florian Fainelli <[email protected]>

---
Stable: 2.6.34+

Thanks, applied to 2.6.34+. Note that while you added a
CC [email protected] that address was not actually on the mail's cc list!

Ralf