checkpatch.pl: never finishes w/ specific file
Hello,
this runs infinitely :
./scripts/checkpatch.pl --file ./drivers/staging/rtl8192u/r819xU_firmware_img.c
Is this a known behaviour of checkpatch.pl ?
Signature · 4 lines
MfG/Kind regards Toralf Förster pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3
2011/3/3 Toralf Förster <[email protected]>:
Quoted 8 lines
Hello,
this runs infinitely :
./scripts/checkpatch.pl--file./drivers/staging/rtl8192u/r819xU_firmware_img.cIs this a known behaviour of checkpatch.pl ?
Not infinitely, just need to wait for a long time.
checkpatch.pl works fine, it report like this:
ERROR: space required after that ',' (ctx:VxV)
+0x01,0x00,0x00,0x08,0x00,0x00,0x00,0x00,};
^
That file miss so many whitespace after ',' from checkpatch point of view. Anyway, forget it, checkpatch.pl is not recommended to check those files.
Quoted 7 lines · Toralf Förster
Hello,
this runs infinitely :
./scripts/checkpatch.pl--file./drivers/staging/rtl8192u/r819xU_firmware_img.cIs this a known behaviour of checkpatch.pl ?
That one may be already fixed in my development version. The form of the file is familiar.
Could you try your file with the one below and let me know:
http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing
-apw
Andy Whitcroft wrote at 12:47:52
Quoted 5 lines
That one may be already fixed in my development version. The form of the file is familiar.
Could you try your file with the one below and let me know:
-apw
That works much more faster :
real 0m18.215s user 0m8.876s sys 0m0.281s
:-)
Signature · 3 lines
MfG/Sincerely Toralf Förster pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3
Andy Whitcroft wrote at 12:47:52
Quoted 4 lines
Could you try your file with the one below and let me know:
http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl
I've a question about line 1365 :
if ($realfile =~ m@^include/asm\/@) {IMO either both "/" or none needs to be escaped, or ?
Signature · 3 lines
MfG/Sincerely Toralf Förster pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3
Quoted 11 lines · Toralf Förster
Andy Whitcroft wrote at 12:47:52
Quoted 4 lines
Could you try your file with the one below and let me know:
http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl
I've a question about line 1365 :
if ($realfile =~ m@^include/asm\/@) {IMO either both "/" or none needs to be escaped, or ?
None as we are using '@' as the separator, however the extra \ is benign.
-apw