libsensors: Add support for fanX_pulses sysfs

PATCH In review Guenter Roeck 2 participants 5 messages Mar 4, 2011

lore

Share & tools

lore

Guenter Roeck

author

2011-03-04 15:09 UTC #0 lore raw

PATCH 1/1 libsensors: Add support for fanX_pulses sysfs

This patch adds support for the fanX_pulses sysfs attribute.

--
Index: lib/sensors.h
=================================--- lib/sensors.h (revision 5937)
+++ lib/sensors.h (working copy)
@@ -170,6 +170,7 @@
SENSORS_SUBFEATURE_FAN_FAULT,
SENSORS_SUBFEATURE_FAN_DIV,
SENSORS_SUBFEATURE_FAN_BEEP,
+ SENSORS_SUBFEATURE_FAN_PULSES,

SENSORS_SUBFEATURE_TEMP_INPUT = SENSORS_FEATURE_TEMP << 8, SENSORS_SUBFEATURE_TEMP_MAX,
Index: lib/sysfs.c
=================================--- lib/sysfs.c (revision 5937)
+++ lib/sysfs.c (working copy)
@@ -265,6 +265,7 @@
{ "input", SENSORS_SUBFEATURE_FAN_INPUT },
{ "min", SENSORS_SUBFEATURE_FAN_MIN },
{ "div", SENSORS_SUBFEATURE_FAN_DIV },
+ { "pulses", SENSORS_SUBFEATURE_FAN_PULSES },
{ "alarm", SENSORS_SUBFEATURE_FAN_ALARM },
{ "fault", SENSORS_SUBFEATURE_FAN_FAULT },
{ "beep", SENSORS_SUBFEATURE_FAN_BEEP },

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Jean Delvare

2011-03-04 18:41 UTC #1 lore raw

Re: [lm-sensors] [PATCH] libsensors: Add support for fanX_pulses

Quoted 19 lines · Guenter Roeck

This patch adds support for the fanX_pulses sysfs attribute.
--
Index: lib/sensors.h
=================================> --- lib/sensors.h (revision 5937)
+++ lib/sensors.h (working copy)
(quoted diff) +1 -0
@@ -170,6 +170,7 @@
 	SENSORS_SUBFEATURE_FAN_FAULT,
 	SENSORS_SUBFEATURE_FAN_DIV,
 	SENSORS_SUBFEATURE_FAN_BEEP,
+	SENSORS_SUBFEATURE_FAN_PULSES,
 
 	SENSORS_SUBFEATURE_TEMP_INPUT = SENSORS_FEATURE_TEMP << 8,
 	SENSORS_SUBFEATURE_TEMP_MAX,
Index: lib/sysfs.c
=================================> --- lib/sysfs.c (revision 5937)
+++ lib/sysfs.c (working copy)

Review line 271

Quoted 7 lines

(quoted diff) +1 -0

@@ -265,6 +265,7 @@
 	{ "input", SENSORS_SUBFEATURE_FAN_INPUT },
 	{ "min", SENSORS_SUBFEATURE_FAN_MIN },
 	{ "div", SENSORS_SUBFEATURE_FAN_DIV },
+	{ "pulses", SENSORS_SUBFEATURE_FAN_PULSES },
 	{ "alarm", SENSORS_SUBFEATURE_FAN_ALARM },
 	{ "fault", SENSORS_SUBFEATURE_FAN_FAULT },
 	{ "beep", SENSORS_SUBFEATURE_FAN_BEEP },

Looks good. Please don't forget to update doc/libsensors-API.txt and CHANGES too.

Signature · 6 lines

Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Guenter Roeck

author

2011-03-04 19:17 UTC #2 lore raw

Re: [lm-sensors] [PATCH] libsensors: Add support for fanX_pulses

In reply to Guenter Roeck

Quoted 22 lines · Jean Delvare

Quoted 21 lines · Guenter Roeck
This patch adds support for the fanX_pulses sysfs attribute.
--
Index: lib/sensors.h
=================================> > --- lib/sensors.h (revision 5937)
+++ lib/sensors.h (working copy)
(quoted diff) +1 -0
@@ -170,6 +170,7 @@
 	SENSORS_SUBFEATURE_FAN_FAULT,
 	SENSORS_SUBFEATURE_FAN_DIV,
 	SENSORS_SUBFEATURE_FAN_BEEP,
+	SENSORS_SUBFEATURE_FAN_PULSES,
 
 	SENSORS_SUBFEATURE_TEMP_INPUT = SENSORS_FEATURE_TEMP << 8,
 	SENSORS_SUBFEATURE_TEMP_MAX,
Index: lib/sysfs.c
=================================> > --- lib/sysfs.c (revision 5937)
+++ lib/sysfs.c (working copy)
(quoted diff) +0 -0
@@ -265,6 +265,7 @@
 	{ "input", SENSORS_SUBFEATURE_FAN_INPUT },
 	{ "min", SENSORS_SUBFEATURE_FAN_MIN },
 	{ "div", SENSORS_SUBFEATURE_FAN_DIV },

Quoted 9 lines

Review line 271
Quoted 5 lines
(quoted diff) +1 -0
+	{ "pulses", SENSORS_SUBFEATURE_FAN_PULSES },
 	{ "alarm", SENSORS_SUBFEATURE_FAN_ALARM },
 	{ "fault", SENSORS_SUBFEATURE_FAN_FAULT },
 	{ "beep", SENSORS_SUBFEATURE_FAN_BEEP },
Looks good. Please don't forget to update doc/libsensors-API.txt and CHANGES too.

Do you want to include the new attribute in the upcoming version of the sensors code ?

Reason for asking is that I plan to commit the sysfs ABI changes into 2.6.39, so the attribute won't be documented yet if you release a new version of the sensors code this weekend (ie prior to the Linux merge window).

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Jean Delvare

2011-03-04 20:31 UTC #3 lore raw

Re: [lm-sensors] [PATCH] libsensors: Add support for fanX_pulses

In reply to Guenter Roeck

Quoted 32 lines · Guenter Roeck

Quoted 22 lines · Jean Delvare
Quoted 21 lines · Guenter Roeck
This patch adds support for the fanX_pulses sysfs attribute.
--
Index: lib/sensors.h
=================================> > > --- lib/sensors.h (revision 5937)
+++ lib/sensors.h (working copy)
(quoted diff) +1 -0
@@ -170,6 +170,7 @@
 	SENSORS_SUBFEATURE_FAN_FAULT,
 	SENSORS_SUBFEATURE_FAN_DIV,
 	SENSORS_SUBFEATURE_FAN_BEEP,
+	SENSORS_SUBFEATURE_FAN_PULSES,
 
 	SENSORS_SUBFEATURE_TEMP_INPUT = SENSORS_FEATURE_TEMP << 8,
 	SENSORS_SUBFEATURE_TEMP_MAX,
Index: lib/sysfs.c
=================================> > > --- lib/sysfs.c (revision 5937)
+++ lib/sysfs.c (working copy)
(quoted diff) +0 -0
@@ -265,6 +265,7 @@
 	{ "input", SENSORS_SUBFEATURE_FAN_INPUT },
 	{ "min", SENSORS_SUBFEATURE_FAN_MIN },
 	{ "div", SENSORS_SUBFEATURE_FAN_DIV },
Quoted 9 lines
Review line 271
Quoted 5 lines
(quoted diff) +1 -0
+	{ "pulses", SENSORS_SUBFEATURE_FAN_PULSES },
 	{ "alarm", SENSORS_SUBFEATURE_FAN_ALARM },
 	{ "fault", SENSORS_SUBFEATURE_FAN_FAULT },
 	{ "beep", SENSORS_SUBFEATURE_FAN_BEEP },
Looks good. Please don't forget to update doc/libsensors-API.txt and CHANGES too.

Quoted 2 lines

Do you want to include the new attribute in the upcoming version of the sensors code ?

I don't think you need any change to the sensors program itself.

Quoted 4 lines

Reason for asking is that I plan to commit the sysfs ABI changes into 2.6.39, so the attribute won't be documented yet if you release a new version of the sensors code this weekend (ie prior to the Linux merge window).

I don't have any problem with this. There is always some latency in one direction or another, the kernel and libsensors can't be in perfect sync all the time.

Signature · 6 lines

Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Guenter Roeck

author

2011-03-04 20:40 UTC #4 lore raw

Re: [lm-sensors] [PATCH] libsensors: Add support for fanX_pulses

In reply to Guenter Roeck

Quoted 33 lines · Jean Delvare

Quoted 32 lines · Guenter Roeck
Quoted 31 lines · Jean Delvare
Quoted 19 lines · Guenter Roeck
This patch adds support for the fanX_pulses sysfs attribute.
--
Index: lib/sensors.h
=================================> > > > --- lib/sensors.h (revision 5937)
+++ lib/sensors.h (working copy)
(quoted diff) +1 -0
@@ -170,6 +170,7 @@
 	SENSORS_SUBFEATURE_FAN_FAULT,
 	SENSORS_SUBFEATURE_FAN_DIV,
 	SENSORS_SUBFEATURE_FAN_BEEP,
+	SENSORS_SUBFEATURE_FAN_PULSES,
 
 	SENSORS_SUBFEATURE_TEMP_INPUT = SENSORS_FEATURE_TEMP << 8,
 	SENSORS_SUBFEATURE_TEMP_MAX,
Index: lib/sysfs.c
=================================> > > > --- lib/sysfs.c (revision 5937)
+++ lib/sysfs.c (working copy)
Review line 271
Quoted 7 lines
(quoted diff) +1 -0
@@ -265,6 +265,7 @@
 	{ "input", SENSORS_SUBFEATURE_FAN_INPUT },
 	{ "min", SENSORS_SUBFEATURE_FAN_MIN },
 	{ "div", SENSORS_SUBFEATURE_FAN_DIV },
+	{ "pulses", SENSORS_SUBFEATURE_FAN_PULSES },
 	{ "alarm", SENSORS_SUBFEATURE_FAN_ALARM },
 	{ "fault", SENSORS_SUBFEATURE_FAN_FAULT },
 	{ "beep", SENSORS_SUBFEATURE_FAN_BEEP },
Looks good. Please don't forget to update doc/libsensors-API.txt and CHANGES too.

Quoted 5 lines

Quoted 2 lines
Do you want to include the new attribute in the upcoming version of the sensors code ?
I don't think you need any change to the sensors program itself.

Sorry, I meant libsensors, assuming the new version will include both the sensors command and libsensors.

Quoted 9 lines

Quoted 4 lines
Reason for asking is that I plan to commit the sysfs ABI changes into 2.6.39, so the attribute won't be documented yet if you release a new version of the sensors code this weekend (ie prior to the Linux merge window).
I don't have any problem with this. There is always some latency in one direction or another, the kernel and libsensors can't be in perfect sync all the time.

Ok, committed with updated doc/libsensors-API.txt. CHANGES already says "Add support for new sysfs attributes" which I guess covers this one as well.

Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors