Skip to contentSkip to conversation

Patches an media build tree

DISCUSSION Helmut Auer 4 participants 5 messages Jan 15, 2011 – Mar 6, 2011 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hello List

How long does it usually take til patches are integrated into the media build tree ( after posting these here ) ? I'm just wondering because I miss some patches posted here.

Signature · 1 line
Helmut Auer, [email protected]
#1 lore raw

Em 15-01-2011 11:46, Helmut Auer escreveu:

Quoted 4 lines

Hello List

How long does it usually take til patches are integrated into the media build tree ( after posting these here ) ? I'm just wondering because I miss some patches posted here.

It takes as much it needs for the driver maintainer to look into it, and for me to have time to handle them.

The pending patches are always at:

https://patchwork.kernel.org/project/linux-media/list/

Please note that, by default, Patchwork filters the patches to display only the ones marked as New or Under Review. If you want to see all patches, you need to change the state filter to show all patches:
https://patchwork.kernel.org/project/linux-media/list/?state=*

If the patch you're waiting are marked as Under Review, you should ping the driver maintainer, as I'm waiting for his review. If it is new, that means that I didn't have time yet to dig into it.

Cheers,
Mauro

#2 lore raw
Quoted 20 lines · On Sun, 16 Jan 2011 16:37:38 -0200 Mauro Carvalho Chehab <[email protected]>…

Em 15-01-2011 11:46, Helmut Auer escreveu:

Quoted 5 lines

Hello List

How long does it usually take til patches are integrated into the media build tree ( after posting these here ) ? I'm just wondering because I miss some patches posted here.

It takes as much it needs for the driver maintainer to look into it, and for me to have time to handle them.

The pending patches are always at:

https://patchwork.kernel.org/project/linux-media/list/

Please note that, by default, Patchwork filters the patches to display only the ones marked as New or Under Review. If you want to see all patches, you need to change the state filter to show all patches:
https://patchwork.kernel.org/project/linux-media/list/?state=*

Quoted 3 lines

If the patch you're waiting are marked as Under Review, you should ping the driver maintainer, as I'm waiting for his review. If it is new, that means that I didn't have time yet to dig into it.

Can you please check these patches ?
What is missing ? Something to be corrected ?

What happens to orphaned drivers ? Manu are you still working on this ?

Manu , Mauro please comment ! Thanks !

Avoid unnecessary data copying inside dvb_dmx_swfilter_204() function

	2010-08-07 	Marko Ristola 		Under Review
Refactor Mantis DMA transfer to deliver 16Kb TS data per interrupt
	2010-08-07 	Marko Ristola 		Under Review
[v2] V4L/DVB: faster DVB-S lock for mantis cards using stb0899 demod
	2010-10-10 	Tuxoholic 		Under Review
#3 lore raw

Hi Steffen,

Quoted 30 lines · Steffen Barszus
Quoted 20 lines · On Sun, 16 Jan 2011 16:37:38 -0200 Mauro Carvalho Chehab <[email protected]>…

Em 15-01-2011 11:46, Helmut Auer escreveu:

Quoted 5 lines

Hello List

How long does it usually take til patches are integrated into the media build tree ( after posting these here ) ? I'm just wondering because I miss some patches posted here.

It takes as much it needs for the driver maintainer to look into it, and for me to have time to handle them.

The pending patches are always at:

      https://patchwork.kernel.org/project/linux-media/list/

Please note that, by default, Patchwork filters the patches to display only the ones marked as New or Under Review. If you want to see all patches, you need to change the state filter to show all patches:
https://patchwork.kernel.org/project/linux-media/list/?state=*

Quoted 3 lines

If the patch you're waiting are marked as Under Review, you should ping the driver maintainer, as I'm waiting for his review. If it is new, that means that I didn't have time yet to dig into it.

Can you please check these patches ?
What is missing ? Something to be corrected ?

Quoted 8 lines

What happens to orphaned drivers ? Manu are you still working on this ?

Manu , Mauro please comment ! Thanks !

Avoid unnecessary data copying inside dvb_dmx_swfilter_204() function 2010-08-07      Marko Ristola           Under Review Refactor Mantis DMA transfer to deliver 16Kb TS data per interrupt 2010-08-07      Marko Ristola           Under Review

I had tried this patch a while back, but due to some reason it was causing a complete freeze at my side: it could have been due to a different version of the bridge or so, But it wasn't really easy on my side to ascertain that. That time looking at the patch it wasn't easy to identify the reason as well. I need to retry the same again, with a cooler head as to see what happens.

Quoted 3 lines

[v2] V4L/DVB: faster DVB-S lock for mantis cards using stb0899 demod 2010-10-10      Tuxoholic               Under Review

I was under the assumption that this issue was fixed in the right way, with the fix being applied to the stb6100 driver sometime back. Was your test with that fix in ?

Best Regards,
Manu

#4 lore raw
Quoted 1 line · On Sun, 6 Mar 2011 17:23:11 +0530 Manu Abraham <[email protected]> wrote:

Hi Steffen,

Hi Manu ,

thx for the reply :)

Quoted 9 lines

On Sat, Mar 5, 2011 at 9:13 PM, Steffen Barszus

Quoted 6 lines

Manu , Mauro please comment ! Thanks !

Avoid unnecessary data copying inside dvb_dmx_swfilter_204() function 2010-08-07      Marko Ristola           Under Review Refactor Mantis DMA transfer to deliver 16Kb TS data per interrupt 2010-08-07      Marko Ristola           Under Review

Quoted 6 lines

I had tried this patch a while back, but due to some reason it was causing a complete freeze at my side: it could have been due to a different version of the bridge or so, But it wasn't really easy on my side to ascertain that. That time looking at the patch it wasn't easy to identify the reason as well. I need to retry the same again, with a cooler head as to see what happens.

That would be good, as far as i remember - the issue is, without these patches the driver crashes after a while caused by vdr's excessive use by EIT scanner. So it can only be used without EPG scan enabled. With that it was running stable. There have been a few different patches floating around to address this issue.

Quoted 7 lines
Quoted 3 lines

[v2] V4L/DVB: faster DVB-S lock for mantis cards using stb0899 demod 2010-10-10      Tuxoholic               Under Review

I was under the assumption that this issue was fixed in the right way, with the fix being applied to the stb6100 driver sometime back. Was your test with that fix in ?

Think i did not put it into relation.

Let me get to the users of the cards, to test the current dkms [1] w/o any patches and confirm back to you whats current situation It was this one:

commit f14bfe94e459cb070a489e1786f26d54e9e7b5de

Author: Manu Abraham <[email protected]>
Date:   Sun Nov 14 15:52:10 2010 -0300

[media] stb6100: Improve tuner performance

right ?

Kind Regards

Steffen

[1] Test version of the dkms, need to remove above named patches tomorrow. Will remove the above patches again for testing, then its except for a small fix for more then on TT S2 1600 plain media_tree.
https://launchpad.net/~yavdr/+archive/testing-vdr/+packages?field.name_filter=v4l-dvb-dkms&field.status_filter=published&field.series_filter=