Skip to contentSkip to conversation

powerpc: Use more accurate limit for first segment memory allocations

PATCH In review Kamalesh Babulal 1 participant 1 message Mar 7, 2011 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 3/7 powerpc: Use more accurate limit for first segment memory allocations

powerpc: Use more accurate limit for first segment memory allocations

Commit: 095c7965f4dc870ed2b65143b1e2610de653416c upstream

On large machines we are running out of room below 256MB. In some cases we only need to ensure the allocation is in the first segment, which may be 256MB or 1TB.

Add slb0_limit and use it to specify the upper limit for the irqstack and emergency stacks.

On a large ppc64 box, this fixes a panic at boot when the crashkernel= option is specified (previously we would run out of memory below 256MB).

---
 arch/powerpc/kernel/setup_64.c |   17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)
arch/powerpc/kernel/setup_64.c +0 -0
Index: b/arch/powerpc/kernel/setup_64.c
===================================================================
@@ -432,9 +432,18 @@
	DBG(" <- setup_system()\n");

}

+static u64 slb0_limit(void)
+{
+ if (cpu_has_feature(CPU_FTR_1T_SEGMENT))
+ return 1UL << SID_SHIFT_1T;
+
+ return 1UL << SID_SHIFT;
+}
+
#ifdef CONFIG_IRQSTACKS
static void __init irqstack_early_init(void)
{

+	u64 limit = slb0_limit();
	unsigned int i;

	/*
@@ -444,10 +453,10 @@
	for_each_possible_cpu(i) {
		softirq_ctx[i] = (struct thread_info *)
			__va(lmb_alloc_base(THREAD_SIZE,

- THREAD_SIZE, 0x10000000));
+ THREAD_SIZE, limit));
hardirq_ctx[i] = (struct thread_info *)
__va(lmb_alloc_base(THREAD_SIZE,
- THREAD_SIZE, 0x10000000));

+					    THREAD_SIZE, limit));
	}

}
#else
@@ -478,7 +487,7 @@
*/
static void __init emergency_stack_init(void)
{
- unsigned long limit;

+	u64 limit;
	unsigned int i;

	/*

@@ -490,7 +499,7 @@
* bringup, we need to get at them in real mode. This means they
* must also be within the RMO region.
*/
- limit = min(0x10000000ULL, lmb.rmo_size);
+ limit = min(slb0_limit(), lmb.rmo_size);

	for_each_possible_cpu(i) {
		unsigned long sp;