Skip to contentSkip to conversation

Adds general Freescale external debugger support

PATCH New Roy Zang 5 participants 8 messages Jan 30, 2011 – Mar 7, 2011 PowerPC

lore
Share & tools
lore

Roy Zang

author
#0 lore raw

PATCH v2 1/1 Adds general Freescale external debugger support

This patch adds general Freescale powerpc external debugger support. Patch is tested on 85xx/QorIQ platforms in u-boot with CodeWarrior. CONFIG_EXT_DEBUGGER should be defined if the u-boot needs to be debugged by external debugger.
To use the external debug funciton, the make command can be just as make CONFIG_EXT_DEBUGGER=1
or define CONFIG_EXT_DEBUGGER in the board header file.

Cc Wood Scott-B07421 <[email protected]>
Cc Kumar Gala <[email protected]>

---
Consider the comment from Wolfgang Denk
http://lists.denx.de/pipermail/u-boot/2010-October/080689.html

 README                 |    4 ++++
 arch/powerpc/config.mk |    3 +++
 2 files changed, 7 insertions(+), 0 deletions(-)
README +4 -0
index 755d17c..6162fa6 100644
@@ -2885,6 +2885,10 @@ Low Level (hardware related) configuration options:
 		that is executed before the actual U-Boot. E.g. when
 		compiling a NAND SPL.
 
+- CONFIG_EXT_DEBUGGER
+		Adds external debugger support. Extra build option will be
+		added to support external debugger.
+
 Building the Software:
 ======================
 
arch/powerpc/config.mk +3 -0
index 2912604..9af9647 100644
@@ -53,3 +53,6 @@ endif
 ifeq ($(CROSS_COMPILE),powerpc-openbsd-)
 PLATFORM_CPPFLAGS+= -D__PPC__
 endif
+ifdef CONFIG_EXT_DEBUGGER
+PLATFORM_CPPFLAGS+= -ggdb -Wa,-gdwarf2
+endif
Signature · 1 line
1.7.3.5
#1 lore raw

PATCH v2 1/1 Adds general Freescale external debugger support

Dear Roy Zang,

Quoted 7 lines · In message <[email protected]> you…

This patch adds general Freescale powerpc external debugger support. Patch is tested on 85xx/QorIQ platforms in u-boot with CodeWarrior. CONFIG_EXT_DEBUGGER should be defined if the u-boot needs to be debugged by external debugger.
To use the external debug funciton, the make command can be just as make CONFIG_EXT_DEBUGGER=1
or define CONFIG_EXT_DEBUGGER in the board header file.

How exactly do you define "external debugger"? Does that mean that there is an "internal debugger"? Are you thinking of "bedbug" here?

And in which way is this specific to "Freescale external debuggers" as you describe it in the Subject?

I don't see where this is specific to the Power architecture either - expect that you only tested it there.

My understanding is that you enable debug settings for the GNU debugger.

Do these need to be architecture specific? Probably not.

Do these need to be enabled by a new #define? What would be the disadvantages of having these options always enabled, for all architectures?

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Without freedom of choice there is no creativity.
	-- Kirk, "The return of the Archons", stardate 3157.4
#2 lore raw

PATCH v2 1/1 Adds general Freescale external debugger support

Am 01/30/2011 08:43 PM, schrieb Wolfgang Denk:

Quoted 8 lines

I don't see where this is specific to the Power architecture either - expect that you only tested it there.

My understanding is that you enable debug settings for the GNU debugger.

Do these need to be architecture specific? Probably not.

I do remember that we needed architecture-dependent debug options on a system I worked on in the past, because the preferred debug format was different on different platforms (all using gcc/binutils/gdb).

Quoted 3 lines

Do these need to be enabled by a new #define? What would be the disadvantages of having these options always enabled, for all architectures?

Always having debug info in the ELF file should not cause problems IMHO, and one set of settings per platform should be enough.

cu
Michael

#3 lore raw

PATCH v2 1/1 Adds general Freescale external debugger support

Dear Michael Schwingen,

Quoted 5 lines · In message <[email protected]> you wrote:
Quoted 2 lines

Do these need to be architecture specific? Probably not.

I do remember that we needed architecture-dependent debug options on a system I worked on in the past, because the preferred debug format was different on different platforms (all using gcc/binutils/gdb).

Can you please be a bit more specific here?

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You can't have everything... where would you put it?  - Steven Wright
#4 lore raw

PATCH v2 1/1 Adds general Freescale external debugger support

Quoted 4 lines · Wolfgang Denk

Dear Michael Schwingen,

In message <[email protected]> you wrote:

Quoted 9 lines
Quoted 6 lines
Quoted 2 lines

Do these need to be architecture specific? Probably not.

I do remember that we needed architecture-dependent debug options on a system I worked on in the past, because the preferred debug format was different on different platforms (all using gcc/binutils/gdb).

Can you please be a bit more specific here?

I can only tell from memory, since this was some years ago - IIRC, we needed dwarf debug info on some platforms and stabs on others. I can't provide exact details, since the current toolchains work fine without such tweaking - I only wanted to point out that if you need to specify the exact debug format, then it might be platform-specific.

A simple "-g" should be fine in the common area.

cu
Michael

#5 lore raw

PATCH v2 1/1 Adds general Freescale external debugger support

Quoted 24 lines

-----Original Message-----
From: Michael Schwingen [mailto:rincewind at discworld.dascon.de]
Sent: Monday, January 31, 2011 19:18 PM
To: Wolfgang Denk
Cc: Zang Roy-R61911; u-boot at lists.denx.de; Kumar Gala; Wood Scott-B07421
Subject: Re: [U-Boot] [PATCH v2] Adds general Freescale external debugger support

Quoted 4 lines · Wolfgang Denk

Dear Michael Schwingen,

In message <[email protected]> you wrote:

Quoted 9 lines
Quoted 6 lines
Quoted 2 lines

Do these need to be architecture specific? Probably not.

I do remember that we needed architecture-dependent debug options on a system I worked on in the past, because the preferred debug format was different on different platforms (all using gcc/binutils/gdb).

Can you please be a bit more specific here?

Quoted 7 lines

I can only tell from memory, since this was some years ago - IIRC, we needed dwarf debug info on some platforms and stabs on others. I can't provide exact details, since the current toolchains work fine without such tweaking - I only wanted to point out that if you need to specify the exact debug format, then it might be platform-specific.

A simple "-g" should be fine in the common area.

Hi, Wolfgang
Considering the name, how about
CONFIG_POWERPC_GNU_DEBUGGER?
thanks.
Roy

#6 lore raw

PATCH v2 1/1 Adds general Freescale external debugger support

In reply to Michael Schwingen
Quoted 10 lines

-----Original Message-----
From: Michael Schwingen [mailto:rincewind at discworld.dascon.de]
Sent: Monday, January 31, 2011 6:50 AM
To: Wolfgang Denk
Cc: Zang Roy-R61911; u-boot at lists.denx.de; Kumar Gala; Wood Scott-B07421
Subject: Re: [U-Boot] [PATCH v2] Adds general Freescale external debugger support

[snip]

Quoted 5 lines
Quoted 3 lines

Do these need to be enabled by a new #define? What would be the disadvantages of having these options always enabled, for all architectures?

Always having debug info in the ELF file should not cause problems IMHO, and one set of settings per platform should be enough.

Including the debug information, size should be consideration. Roy

#7 lore raw

PATCH v2 1/1 Adds general Freescale external debugger support

Quoted 10 lines · On Mon, 7 Mar 2011 01:18:28 -0600 Zang Roy-R61911 <[email protected]> wrote:
Quoted 10 lines

-----Original Message-----
From: Michael Schwingen [mailto:rincewind at discworld.dascon.de]
Sent: Monday, January 31, 2011 6:50 AM
To: Wolfgang Denk
Cc: Zang Roy-R61911; u-boot at lists.denx.de; Kumar Gala; Wood Scott-B07421
Subject: Re: [U-Boot] [PATCH v2] Adds general Freescale external debugger support

Quoted 8 lines

[snip]

Quoted 5 lines
Quoted 3 lines

Do these need to be enabled by a new #define? What would be the disadvantages of having these options always enabled, for all architectures?

Always having debug info in the ELF file should not cause problems IMHO, and one set of settings per platform should be enough.

Including the debug information, size should be consideration.

It doesn't get included in the .bin which is flashed on the target -- you're worried about the developer's hard disk being too small?

-Scott