Skip to contentSkip to conversation

V4L/DVB: tm6000: remove unneeded NULL check

PATCH RESEND New Dan Carpenter 1 participant 1 message Mar 7, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 V4L/DVB: tm6000: remove unneeded NULL check

We're testing the wrong variable here, and anyway list_entry() never returns NULL. We already verified that the list is not empty.

This was added by: 721f507b694f "V4L/DVB (12842): tm6000: avoid kernel panic while retrieving the filling buffer"

drivers/staging/tm6000/tm6000-video.c +0 -3
index b550340..e1c6ec8 100644
@@ -179,9 +179,6 @@ static inline void get_next_buf(struct tm6000_dmaqueue *dma_q,
 	*buf = list_entry(dma_q->active.next,
 			struct tm6000_buffer, vb.queue);
 
-	if (!buf)
-		return;
-
 	/* Cleans up buffer - Usefull for testing for frame/URB loss */
 	outp = videobuf_to_vmalloc(&(*buf)->vb);