Skip to contentSkip to conversation

ASoC: sgtl5000: use after free in ldo_regulator_register()

PATCH Applied Dan Carpenter 3 participants 3 messages Mar 8, 2011

Subsystems (4)
Sound Kernel janitors ASoC NXP SGTL5000 driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 ASoC: sgtl5000: use after free in ldo_regulator_register()

The "ldo" variable was dereferenced after free on the error path.

Signed-off-by Dan Carpenter <[email protected]>
sound/soc/codecs/sgtl5000.c +3 -1
index b7e97c0..1f7217f 100644
@@ -875,11 +875,13 @@ static int ldo_regulator_register(struct snd_soc_codec *codec,
 	ldo->dev = regulator_register(&ldo->desc, codec->dev,
 					  init_data, ldo);
 	if (IS_ERR(ldo->dev)) {
+		int ret = PTR_ERR(ldo->dev);
+
 		dev_err(codec->dev, "failed to register regulator\n");
 		kfree(ldo->desc.name);
 		kfree(ldo);
 
-		return PTR_ERR(ldo->dev);
+		return ret;
 	}
 
 	return 0;