Product ID for Logitech Driving Force Pro wheel

PATCH In review Michal Malý 2 participants 3 messages Mar 10, 2011 – Mar 16, 2011 HID

Share & tools

Michal Malý

author

2011-03-10 20:53 UTC #0 lore raw

PATCH 1/1 Product ID for Logitech Driving Force Pro wheel

This trivial fix adds correct product ID for Logitech Driving Force Pro wheel when it operates in native mode. This is needed to get force feedback working.

drivers/hid/hid-core.c +1 -0

@@ -1368,6 +1368,7 @@
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_FLIGHT_SYSTEM_G940) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_MOMO_WHEEL) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_MOMO_WHEEL2) },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_DFP_WHEEL) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G25_WHEEL) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_WII_WHEEL) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_RUMBLEPAD2) },

drivers/hid/hid-lg.c +2 -0

@@ -375,6 +375,8 @@
 		.driver_data = LG_FF },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_MOMO_WHEEL2),
 		.driver_data = LG_FF },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_DFP_WHEEL),
+		.driver_data = LG_FF },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G25_WHEEL),
 		.driver_data = LG_FF },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_WII_WHEEL),

drivers/hid/hid-ids.h +1 -0

@@ -383,6 +383,7 @@
 #define USB_DEVICE_ID_LOGITECH_WHEEL	0xc294
 #define USB_DEVICE_ID_LOGITECH_WINGMAN_FFG	0xc293
 #define USB_DEVICE_ID_LOGITECH_MOMO_WHEEL	0xc295
+#define USB_DEVICE_ID_LOGITECH_DFP_WHEEL	0xc298
 #define USB_DEVICE_ID_LOGITECH_G25_WHEEL	0xc299
 #define USB_DEVICE_ID_LOGITECH_WII_WHEEL	0xc29c
 #define USB_DEVICE_ID_LOGITECH_ELITE_KBD	0xc30a

Jiri Kosina

2011-03-14 12:12 UTC #1 lore raw

Quoted 2 lines · Michal Malý

This trivial fix adds correct product ID for Logitech Driving Force Pro wheel when it operates in native mode. This is needed to get force feedback working.

Hi Michal,

could you please fixup and re-post your patch, according to Documentation/SubmittingPatches?

Namely

- please add your Signed-off-by: line
- please send a patch in 'condensed' form, i.e. we don't want separate diffs for separate files

Thanks,

Signature · 2 lines

Jiri Kosina
SUSE Labs, Novell Inc.

Jiri Kosina

2011-03-16 23:46 UTC #2 lore raw

Quoted 5 lines · Jiri Kosina

Quoted 2 lines
This trivial fix adds correct product ID for Logitech Driving Force Pro wheel when it operates in native mode. This is needed to get force feedback working.
Hi Michal,

Quoted 8 lines

could you please fixup and re-post your patch, according to Documentation/SubmittingPatches?
Namely
- please add your Signed-off-by: line
- please send a patch in 'condensed' form, i.e. we don't want separate diffs for separate files

As there has been no response, I have applied the patch below to my tree. Thanks a lot for your report!

Quoted 1 line

From 5623a24a80814fe471e777f12b9dbbb0f77e002e Mon Sep 17 00:00:00 2001

From: Jiri Kosina <[email protected]>
Date: Thu, 17 Mar 2011 00:43:23 +0100
Subject: [PATCH] HID: add support for Logitech Driving Force Pro wheel

Add force feedback support for Logitech Driving Force Pro wheel.

Device IDs reported by Michal Malý.

Reported-by Michal Malý <[email protected]>

Signed-off-by Jiri Kosina <[email protected]>

---
 drivers/hid/hid-core.c |    1 +
 drivers/hid/hid-ids.h  |    1 +
 drivers/hid/hid-lg.c   |    2 ++
 3 files changed, 4 insertions(+), 0 deletions(-)

drivers/hid/hid-core.c +1 -0

index 295e248..f99413b 100644
@@ -1368,6 +1368,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_FLIGHT_SYSTEM_G940) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_MOMO_WHEEL) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_MOMO_WHEEL2) },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_DFP_WHEEL) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G25_WHEEL) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_WII_WHEEL) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_RUMBLEPAD2) },

drivers/hid/hid-ids.h +1 -0

index 5f5cc91..cb21c41 100644
@@ -383,6 +383,7 @@
 #define USB_DEVICE_ID_LOGITECH_WHEEL	0xc294
 #define USB_DEVICE_ID_LOGITECH_WINGMAN_FFG	0xc293
 #define USB_DEVICE_ID_LOGITECH_MOMO_WHEEL	0xc295
+#define USB_DEVICE_ID_LOGITECH_DFP_WHEEL	0xc298
 #define USB_DEVICE_ID_LOGITECH_G25_WHEEL	0xc299
 #define USB_DEVICE_ID_LOGITECH_WII_WHEEL	0xc29c
 #define USB_DEVICE_ID_LOGITECH_ELITE_KBD	0xc30a

drivers/hid/hid-lg.c +2 -0

index aef4104..3da9040 100644
@@ -377,6 +377,8 @@ static const struct hid_device_id lg_devices[] = {
 		.driver_data = LG_FF },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G25_WHEEL),
 		.driver_data = LG_FF },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_DFP_WHEEL),
+		.driver_data = LG_FF },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_WII_WHEEL),
 		.driver_data = LG_FF4 },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_WINGMAN_FFG ),

Signature · 2 lines

Jiri Kosina
SUSE Labs, Novell Inc.