Skip to contentSkip to conversation

Apply OPTION_BLACKLIST_SENDSETUP also for ZTE MF626

PATCH New Herton Ronaldo Krzesinski 3 participants 3 messages Mar 9, 2011 – Mar 11, 2011

Subsystems (2)
USB USB serial
lore
Share & tools
lore

Herton Ronaldo Krzesinski

author
#0 lore raw

PATCH 1/1 Apply OPTION_BLACKLIST_SENDSETUP also for ZTE MF626

On https://bugs.launchpad.net/ubuntu/+source/linux/+bug/636091, one of the cases reported is a big timeout on option_send_setup, which causes some side effects as tty_lock is held. Looks like some of ZTE MF626 devices also don't like the RTS/DTR setting in option_send_setup, like with 4G XS Stick W14. The reporter confirms which this it solves the long freezes in his system.

Signed-off-by Herton Ronaldo Krzesinski <[email protected]>
---
 drivers/usb/serial/option.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/usb/serial/option.c +2 -1
index 5f46838..75c7f45 100644
@@ -652,7 +652,8 @@ static const struct usb_device_id option_ids[] = {
 	{ USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0x0028, 0xff, 0xff, 0xff) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0x0029, 0xff, 0xff, 0xff) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0x0030, 0xff, 0xff, 0xff) },
-	{ USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, ZTE_PRODUCT_MF626, 0xff, 0xff, 0xff) },
+	{ USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, ZTE_PRODUCT_MF626, 0xff,
+	  0xff, 0xff), .driver_info = (kernel_ulong_t)&four_g_w14_blacklist },
 	{ USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0x0032, 0xff, 0xff, 0xff) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0x0033, 0xff, 0xff, 0xff) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0x0034, 0xff, 0xff, 0xff) },
Signature · 1 line
1.7.1
Applied
#1 lore raw

PATCH 1/1 Apply OPTION_BLACKLIST_SENDSETUP also for ZTE MF626

Applied to Natty.

-apw

#2 lore raw
Quoted 1 line · Andy Whitcroft

Applied to Natty.

How nice. But we really don't care about seeing distro commit messages on public mailing lists.

Please fix your scripts to never do this again.

thanks,

greg k-h