Skip to contentSkip to conversation

processor_xen.o should depend on CONFIG_XEN

PATCH In review Olaf Hering 3 participants 6 messages Mar 12, 2011 – Mar 18, 2011 ACPI

lore
Share & tools
lore

Olaf Hering

author
#0 lore raw

By accident CONFIG_XEN got disabled in my .config. I noticed that in xen.git/drivers/acpi/Makefile processor_xen.o is compiled unconditionally. I think it should be processor-$(CONFIG_XEN) instead of processor-y because it references xen_pcpu_index().

Olaf

#1 lore raw

Olaf Hering writes ("[Xen-devel] processor_xen.o should depend on CONFIG_XEN"):

Quoted 4 lines

By accident CONFIG_XEN got disabled in my .config. I noticed that in xen.git/drivers/acpi/Makefile processor_xen.o is compiled unconditionally. I think it should be processor-$(CONFIG_XEN) instead of processor-y because it references xen_pcpu_index().

Would you care to write a patch to this effect ?

Ian.

author
#2 lore raw

PATCH 1/1 processor_xen.o should depend on CONFIG_XEN

processor_xen.c references symbols which are only availabe if CONFIG_XEN is enabled.

Signed-off-by Olaf Hering <[email protected]>
---
 drivers/acpi/Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/Makefile +1 -1
Index: linux-2.6.32.32-0.2-pvops/drivers/acpi/Makefile
===================================================================
@@ -61,7 +61,7 @@ obj-$(CONFIG_ACPI_POWER_METER)	+= power_
 # processor has its own "processor." module_param namespace
 processor-y			:= processor_core.o processor_throttling.o
 processor-y			+= processor_idle.o processor_thermal.o
-processor-y			+= processor_xen.o
+processor-$(CONFIG_XEN)		+= processor_xen.o
 processor-$(CONFIG_CPU_FREQ)	+= processor_perflib.o
 
 obj-$(CONFIG_ACPI_PROCESSOR_AGGREGATOR) += acpi_pad.o
#3 lore raw

Olaf Hering writes ("[PATCH] processor_xen.o should depend on CONFIG_XEN"):

Quoted 2 lines

processor_xen.c references symbols which are only availabe if CONFIG_XEN is enabled.

Thanks. This should be sent to linux-kernel and perhaps go in via the Xen tree ?

Ian.

#4 lore raw
In reply to Olaf Hering
Quoted 2 lines · Olaf Hering

processor_xen.c references symbols which are only availabe if CONFIG_XEN is enabled.

Hehe. I saw this for 2.6.38 some time ago from Ian Campbell and promptly forgot. Now it comes up again. Will stick it on 2.6.39 bug-fix branch shortly.

Quoted 25 lines
Signed-off-by Olaf Hering <[email protected]>
---
 drivers/acpi/Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.32.32-0.2-pvops/drivers/acpi/Makefile
===================================================================

drivers/acpi/Makefile +1 -1
@@ -61,7 +61,7 @@ obj-$(CONFIG_ACPI_POWER_METER)	+= power_
 # processor has its own "processor." module_param namespace
 processor-y			:= processor_core.o processor_throttling.o
 processor-y			+= processor_idle.o processor_thermal.o
-processor-y			+= processor_xen.o
+processor-$(CONFIG_XEN)		+= processor_xen.o
 processor-$(CONFIG_CPU_FREQ)	+= processor_perflib.o
 
 obj-$(CONFIG_ACPI_PROCESSOR_AGGREGATOR) += acpi_pad.o

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

author
#5 lore raw
Quoted 6 lines · Konrad Rzeszutek Wilk
Quoted 2 lines · Olaf Hering

processor_xen.c references symbols which are only availabe if CONFIG_XEN is enabled.

Hehe. I saw this for 2.6.38 some time ago from Ian Campbell and promptly forgot. Now it comes up again. Will stick it on 2.6.39 bug-fix branch shortly.

Thats mainly for stable-2.6.32.x, if it applies to other trees too, fine with me.

Olaf