Skip to contentSkip to conversation

gsoap_2.7.13 build errors

PATCH In review Peter Gsellmann 2 participants 6 messages Mar 11, 2011 – Mar 14, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gsoap_2.7.13 build errors

There is a compiler error about an impossible cast from QUIRKS* to const QUIRKS*
The patches are from Fedora12 which has the exact same gsoap-version
They can be found at http://archive.fedoraproject.org/pub/archive/fedora/linux/releases/12/Everything/source/SRPMS/gsoap-2.7.13-2.fc12.src.rpm

In the native package, the generated binary is installed in STAGING_BINDIR_NATIVE where expected by the gsoap-package

Otherwise the gsoap-package uses a soapcpp2 delivered as 32bit-executable in the source-package! This fails on x86_64 hosts.

---
 recipes/gsoap/gsoap-2.7.13/gsoap-2.7-openssl.patch |   17 +++++
 recipes/gsoap/gsoap-2.7.13/unused_args.patch       |   39 +++++++++++
 .../gsoap/gsoap-2.7.13/use_libtool-2.7.12.patch    |   72 ++++++++++++++++++++
 recipes/gsoap/gsoap-native_2.7.13.bb               |    3 +-
 recipes/gsoap/gsoap_2.7.13.inc                     |    4 +-
 5 files changed, 133 insertions(+), 2 deletions(-)
 create mode 100644 recipes/gsoap/gsoap-2.7.13/gsoap-2.7-openssl.patch
 create mode 100644 recipes/gsoap/gsoap-2.7.13/unused_args.patch
 create mode 100644 recipes/gsoap/gsoap-2.7.13/use_libtool-2.7.12.patch
recipes/gsoap/gsoap-2.7.13/gsoap-2.7-openssl.patch new file +17 -0
new file mode 100644
index 0000000..443fb69
@@ -0,0 +1,17 @@
+diff -up gsoap-2.7/gsoap/stdsoap2.cpp.openssl gsoap-2.7/gsoap/stdsoap2.cpp
+--- gsoap-2.7/gsoap/stdsoap2.cpp.openssl	2008-10-02 19:36:28.000000000 +0200
++++ gsoap-2.7/gsoap/stdsoap2.cpp	2009-08-22 22:20:49.000000000 +0200
+@@ -4153,7 +4153,12 @@ again:
+           { X509_EXTENSION *ext = X509_get_ext(peer, i);
+             const char *ext_str = OBJ_nid2sn(OBJ_obj2nid(X509_EXTENSION_get_object(ext)));
+             if (ext_str && !strcmp(ext_str, "subjectAltName"))
+-            { X509V3_EXT_METHOD *meth = X509V3_EXT_get(ext);
++            {
++#if (OPENSSL_VERSION_NUMBER >= 0x10000000L)
++              const X509V3_EXT_METHOD *meth = X509V3_EXT_get(ext);
++#else
++              X509V3_EXT_METHOD *meth = X509V3_EXT_get(ext);
++#endif
+               void *ext_data;
+ #if (OPENSSL_VERSION_NUMBER >= 0x0090800fL)
+               const unsigned char *data;
recipes/gsoap/gsoap-2.7.13/unused_args.patch new file +39 -0
new file mode 100644
index 0000000..376a9b9
@@ -0,0 +1,39 @@
+diff -rup gsoap-2.7/gsoap/src/symbol2.c gsoap-2.7mf/gsoap/src/symbol2.c
+--- gsoap-2.7/gsoap/src/symbol2.c	2009-03-21 16:24:34.000000000 -0500
++++ gsoap-2.7mf/gsoap/src/symbol2.c	2009-05-11 10:18:32.000000000 -0500
+@@ -7334,6 +7334,7 @@ soap_instantiate_class(Tnode *typ)
+   fprintf(fhead,"\nSOAP_FMAC3 %s * SOAP_FMAC4 soap_instantiate_%s(struct soap*, int, const char*, const char*, size_t*);", c_type(typ), c_ident(typ));
+   fprintf(fout,"\n\nSOAP_FMAC3 %s * SOAP_FMAC4 soap_instantiate_%s(struct soap *soap, int n, const char *type, const char *arrayType, size_t *size)", c_type(typ), c_ident(typ));
+   fprintf(fout,"\n{");
++  fprintf(fout,"\n\t(void)type; (void)arrayType; /* appease -Wall -Werror */");
+   fprintf(fout, "\n\tDBGLOG(TEST, SOAP_MESSAGE(fdebug, \"soap_instantiate_%s(%%d, %%s, %%s)\\n\", n, type?type:\"\", arrayType?arrayType:\"\"));", c_ident(typ));
+ 
+   fprintf(fout,"\n\tstruct soap_clist *cp = soap_link(soap, NULL, %s, n, soap_fdelete);", soap_type(typ));
+@@ -7867,6 +7868,8 @@ Tnode* typ;
+         fprintf(fout,"\n\nvoid %s::soap_default(struct soap *soap)\n{", c_ident(typ)); 
+         if ((s = has_soapref(typ)))
+           fprintf(fout,"\n\tthis->%s = soap;", s);
++         else
++           fprintf(fout,"\n\t(void)soap; /* appease -Wall -Werror */");
+ 	d = get_Darraydims(typ);
+         if (d)
+ 	{ fprintf(fout,"\n\tthis->%s = NULL;", ident(p->sym->name));
+@@ -7894,6 +7897,8 @@ Tnode* typ;
+         fprintf(fout,"\n\nSOAP_FMAC3 void SOAP_FMAC4 soap_default_%s(struct soap *soap, %s)\n{", c_ident(typ),c_type_id(typ, "*a")); 
+         if ((s = has_soapref(typ)))
+           fprintf(fout,"\n\ta->%s = soap;", s);
++         else
++           fprintf(fout,"\n\t(void)soap; /* appease -Wall -Werror */");
+ 	d = get_Darraydims(typ);
+         if (d)
+ 	{ fprintf(fout,"\n\ta->%s = NULL;", ident(p->sym->name));
+@@ -9123,7 +9128,7 @@ soap_out(Tnode *typ)
+       if (is_typedef(typ))
+         fprintf(fout, "\n{\treturn soap_%s2s(soap, n);\n}", t_ident(typ));
+       else if (is_boolean(typ))
+-        fprintf(fout, "\n{\treturn soap_code_str(soap_codes_%s, n!=0);\n}", c_ident(typ));
++        fprintf(fout, "\n{\t(void)soap; /* appease -Wall -Werror */\n\treturn soap_code_str(soap_codes_%s, n!=0);\n}", c_ident(typ));
+       else if (!is_mask(typ))
+       { fprintf(fout, "\n{\tconst char *s = soap_code_str(soap_codes_%s, (long)n);", c_ident(typ));
+         fprintf(fout, "\n\tif (s)\n\t\treturn s;");
+Only in gsoap-2.7mf/gsoap/src: symbol2.c~
recipes/gsoap/gsoap-2.7.13/use_libtool-2.7.12.patch new file +72 -0

72 lines not on this page · raw message

recipes/gsoap/gsoap-native_2.7.13.bb +2 -1
index 3e905e7..83c2329 100644
@@ -6,8 +6,9 @@ EXTRA_OEMAKE = ""
 
 inherit native
 
+
 do_install() {
-	:
+	install -m 0755 ${S}/gsoap/src/soapcpp2 ${STAGING_BINDIR_NATIVE}/
 }
 
 
recipes/gsoap/gsoap_2.7.13.inc +3 -1
index 877e1d1..c3ab3c4 100644
@@ -3,7 +3,9 @@ for the development of SOAP Web Services and clients."
 SECTION = "devel"
 LICENSE = "GPL"
 
-SRC_URI = "${SOURCEFORGE_MIRROR}/gsoap2/gsoap_${PV}.tar.gz"
+SRC_URI = "${SOURCEFORGE_MIRROR}/gsoap2/gsoap_${PV}.tar.gz	\
+	file://gsoap-2.7-openssl.patch	\
+	file://unused_args.patch"
 
 inherit autotools
 
Signature · 1 line
1.7.2.3
#1 lore raw

Dear Peter,

Am Freitag, den 11.03.2011, 11:38 +0100 schrieb Peter Gsellmann:

Quoted 7 lines

There is a compiler error about an impossible cast from QUIRKS* to const QUIRKS*
The patches are from Fedora12 which has the exact same gsoap-version
They can be found at http://archive.fedoraproject.org/pub/archive/fedora/linux/releases/12/Everything/source/SRPMS/gsoap-2.7.13-2.fc12.src.rpm

In the native package, the generated binary is installed in STAGING_BINDIR_NATIVE where expected by the gsoap-package

Otherwise the gsoap-package uses a soapcpp2 delivered as 32bit-executable in the source-package! This fails on x86_64 hosts.

smaller patches would it make easier to review in my opinion. (If it were possible.)

On what did you test this patch?

Quoted 11 lines
---
 recipes/gsoap/gsoap-2.7.13/gsoap-2.7-openssl.patch |   17 +++++
 recipes/gsoap/gsoap-2.7.13/unused_args.patch       |   39 +++++++++++
 .../gsoap/gsoap-2.7.13/use_libtool-2.7.12.patch    |   72 ++++++++++++++++++++
 recipes/gsoap/gsoap-native_2.7.13.bb               |    3 +-
 recipes/gsoap/gsoap_2.7.13.inc                     |    4 +-
 5 files changed, 133 insertions(+), 2 deletions(-)
 create mode 100644 recipes/gsoap/gsoap-2.7.13/gsoap-2.7-openssl.patch
 create mode 100644 recipes/gsoap/gsoap-2.7.13/unused_args.patch
 create mode 100644 recipes/gsoap/gsoap-2.7.13/use_libtool-2.7.12.patch

[…]

recipes/gsoap/gsoap-native_2.7.13.bb EXTRA_OEMAKE = "" · line 9

Quoted 9 lines
recipes/gsoap/gsoap-native_2.7.13.bb +1 -0
index 3e905e7..83c2329 100644
@@ -6,8 +6,9 @@ EXTRA_OEMAKE = ""
 
 inherit native
 
+

Not needed?

Quoted 11 lines
recipes/gsoap/gsoap-native_2.7.13.bb +1 -1
 do_install() {
-	:
+	install -m 0755 ${S}/gsoap/src/soapcpp2 ${STAGING_BINDIR_NATIVE}/
 }
 
 
recipes/gsoap/gsoap_2.7.13.inc +0 -0
index 877e1d1..c3ab3c4 100644

recipes/gsoap/gsoap_2.7.13.inc for the development of SOAP Web Services and clients." · line 7

Quoted 6 lines
recipes/gsoap/gsoap_2.7.13.inc +2 -1
@@ -3,7 +3,9 @@ for the development of SOAP Web Services and clients."
 SECTION = "devel"
 LICENSE = "GPL"
 
-SRC_URI = "${SOURCEFORGE_MIRROR}/gsoap2/gsoap_${PV}.tar.gz"
+SRC_URI = "${SOURCEFORGE_MIRROR}/gsoap2/gsoap_${PV}.tar.gz	\
+	file://gsoap-2.7-openssl.patch	\

Use spaces instead of tabulators before »\«?

recipes/gsoap/gsoap_2.7.13.inc for the development of SOAP Web Services and clients." · line 8

Quoted 1 line
recipes/gsoap/gsoap_2.7.13.inc +1 -0
+	file://unused_args.patch"

Maybe you can move the quote »"« on a new line, so that future patches will not create a difference for that line.

recipes/gsoap/gsoap_2.7.13.inc for the development of SOAP Web Services and clients." · line 10

Quoted 1 line
recipes/gsoap/gsoap_2.7.13.inc +0 -0
 inherit autotools

Thanks,

Paul

#2 lore raw

Am Freitag, 11. März 2011, 13:25:15 schrieb Paul Menzel:

Quoted 8 lines

Dear Peter,

Am Freitag, den 11.03.2011, 11:38 +0100 schrieb Peter Gsellmann:

Quoted 4 lines

There is a compiler error about an impossible cast from QUIRKS* to const QUIRKS*
The patches are from Fedora12 which has the exact same gsoap-version
They can be found at http://archive.fedoraproject.org/pub/archive/fedora/linux/releases/12/Everything/source/SRPMS/gsoap-2.7.13-2.fc12.src.rpm

Quoted 6 lines
Quoted 3 lines

In the native package, the generated binary is installed in STAGING_BINDIR_NATIVE where expected by the gsoap-package

Otherwise the gsoap-package uses a soapcpp2 delivered as 32bit-executable in the source-package! This fails on x86_64 hosts.

smaller patches would it make easier to review in my opinion. (If it were possible.)

The patches are as found in Fedora gsoap-2.7.13-2.fc12.src.rpm . I did not make them. Credits to the fedora team.

Quoted 1 line

On what did you test this patch?

I run a daily build for my target which is Angstrom with some extra packages. Target hardware is at91sam9g20.

Quoted 8 lines
Quoted 8 lines
recipes/gsoap/gsoap-native_2.7.13.bb +0 -0
index 3e905e7..83c2329 100644
@@ -6,8 +6,9 @@ EXTRA_OEMAKE = ""
 
 inherit native
 
Quoted 8 lines

recipes/gsoap/gsoap-native_2.7.13.bb EXTRA_OEMAKE = "" · line 9

Quoted 1 line
recipes/gsoap/gsoap-native_2.7.13.bb +1 -0
+

Not needed?

recipes/gsoap/gsoap-native_2.7.13.bb EXTRA_OEMAKE = "" · line 12

Quoted 4 lines
recipes/gsoap/gsoap-native_2.7.13.bb +1 -1
 do_install() {
-	:
+	install -m 0755 ${S}/gsoap/src/soapcpp2 ${STAGING_BINDIR_NATIVE}/
 }

Only soapcpp2 is needed, exactly in this place.

Quoted 14 lines

recipes/gsoap/gsoap_2.7.13.inc for the development of SOAP Web Services and clients." · line 7

Quoted 11 lines
recipes/gsoap/gsoap_2.7.13.inc +2 -1
index 877e1d1..c3ab3c4 100644
@@ -3,7 +3,9 @@ for the development of SOAP Web Services and clients."
 SECTION = "devel"
 LICENSE = "GPL"
 
-SRC_URI = "${SOURCEFORGE_MIRROR}/gsoap2/gsoap_${PV}.tar.gz"
+SRC_URI = "${SOURCEFORGE_MIRROR}/gsoap2/gsoap_${PV}.tar.gz	\
+	file://gsoap-2.7-openssl.patch	\

Use spaces instead of tabulators before »\«?

Quoted 4 lines

recipes/gsoap/gsoap_2.7.13.inc for the development of SOAP Web Services and clients." · line 8

Quoted 1 line
recipes/gsoap/gsoap_2.7.13.inc +1 -0
+	file://unused_args.patch"

Maybe you can move the quote »"« on a new line, so that future patches will not create a difference for that line.

I will repost a reworked patch without tabs today

Peter

#3 lore raw

Am Montag, den 14.03.2011, 10:56 +0100 schrieb Peter Gsellmann:

Quoted 30 lines

Am Freitag, 11. März 2011, 13:25:15 schrieb Paul Menzel:

Quoted 11 lines

Am Freitag, den 11.03.2011, 11:38 +0100 schrieb Peter Gsellmann:

Quoted 7 lines

There is a compiler error about an impossible cast from QUIRKS* to const QUIRKS*
The patches are from Fedora12 which has the exact same gsoap-version
They can be found at http://archive.fedoraproject.org/pub/archive/fedora/linux/releases/12/Everything/source/SRPMS/gsoap-2.7.13-2.fc12.src.rpm

In the native package, the generated binary is installed in STAGING_BINDIR_NATIVE where expected by the gsoap-package

Otherwise the gsoap-package uses a soapcpp2 delivered as 32bit-executable in the source-package! This fails on x86_64 hosts.

smaller patches would it make easier to review in my opinion. (If it were possible.)

The patches are as found in Fedora gsoap-2.7.13-2.fc12.src.rpm . I did not make them. Credits to the fedora team.

Quoted 1 line

On what did you test this patch?

I run a daily build for my target which is Angstrom with some extra packages. Target hardware is at91sam9g20.

Quoted 12 lines

recipes/gsoap/gsoap-native_2.7.13.bb EXTRA_OEMAKE = "" · line 9

Quoted 9 lines
recipes/gsoap/gsoap-native_2.7.13.bb +1 -0
index 3e905e7..83c2329 100644
@@ -6,8 +6,9 @@ EXTRA_OEMAKE = ""
 
 inherit native
 
+

Not needed?

Quoted 5 lines
Quoted 4 lines

recipes/gsoap/gsoap-native_2.7.13.bb EXTRA_OEMAKE = "" · line 12

Quoted 4 lines
recipes/gsoap/gsoap-native_2.7.13.bb +1 -1
 do_install() {
-	:
+	install -m 0755 ${S}/gsoap/src/soapcpp2 ${STAGING_BINDIR_NATIVE}/
 }

Only soapcpp2 is needed, exactly in this place.

I meant the newly added line before the function.

Quoted 14 lines
Quoted 14 lines

recipes/gsoap/gsoap_2.7.13.inc for the development of SOAP Web Services and clients." · line 7

Quoted 11 lines
recipes/gsoap/gsoap_2.7.13.inc +2 -1
index 877e1d1..c3ab3c4 100644
@@ -3,7 +3,9 @@ for the development of SOAP Web Services and clients."
 SECTION = "devel"
 LICENSE = "GPL"
 
-SRC_URI = "${SOURCEFORGE_MIRROR}/gsoap2/gsoap_${PV}.tar.gz"
+SRC_URI = "${SOURCEFORGE_MIRROR}/gsoap2/gsoap_${PV}.tar.gz	\
+	file://gsoap-2.7-openssl.patch	\

Use spaces instead of tabulators before »\«?

Quoted 5 lines
Quoted 4 lines

recipes/gsoap/gsoap_2.7.13.inc for the development of SOAP Web Services and clients." · line 8

Quoted 1 line
recipes/gsoap/gsoap_2.7.13.inc +1 -0
+	file://unused_args.patch"

Maybe you can move the quote »"« on a new line, so that future patches will not create a difference for that line.

I will repost a reworked patch without tabs today

Great! Please remember to tag it as »[PATCH v2]«.

Thanks,

Paul

#4 lore raw

Re: [PATCH] gsoap_2.7.13 build errors, amendment

In reply to Paul Menzel

[amendment to d641ae6bfd4303508c86db9285c2dcba28fb5474] recipes reformatted, removed tab characters

---
 recipes/gsoap/gsoap-native_2.7.13.bb |    3 +--
 recipes/gsoap/gsoap_2.7.13.inc       |    8 ++++----
 2 files changed, 5 insertions(+), 6 deletions(-)
recipes/gsoap/gsoap-native_2.7.13.bb +1 -2
index 83c2329..cc323cb 100644
@@ -6,9 +6,8 @@ EXTRA_OEMAKE = ""
 
 inherit native
 
-
 do_install() {
-	install -m 0755 ${S}/gsoap/src/soapcpp2 ${STAGING_BINDIR_NATIVE}/
+    install -m 0755 ${S}/gsoap/src/soapcpp2 ${STAGING_BINDIR_NATIVE}/
 }
 
 
recipes/gsoap/gsoap_2.7.13.inc +4 -4
index c3ab3c4..3771486 100644
@@ -3,9 +3,10 @@ for the development of SOAP Web Services and clients."
 SECTION = "devel"
 LICENSE = "GPL"
 
-SRC_URI = "${SOURCEFORGE_MIRROR}/gsoap2/gsoap_${PV}.tar.gz	\
-	file://gsoap-2.7-openssl.patch	\
-	file://unused_args.patch"
+SRC_URI = "${SOURCEFORGE_MIRROR}/gsoap2/gsoap_${PV}.tar.gz \
+        file://gsoap-2.7-openssl.patch \
+        file://unused_args.patch \
+        "
 
 inherit autotools
 
@@ -14,4 +15,3 @@ S = "${WORKDIR}/gsoap-2.7"
 PARALLEL_MAKE = ""
 
 EXTRA_OEMAKE = "SOAP=${STAGING_BINDIR_NATIVE}/soapcpp2"
-
Signature · 1 line
1.7.2.3
Acked-by
#5 lore raw

Re: [PATCH] gsoap_2.7.13 build errors, amendment

Am Montag, den 14.03.2011, 12:14 +0100 schrieb Peter Gsellmann:

The commit summary could just say »formatting« or »whitespace fixes« [1].

[1] http://openembedded.org/index.php/Styleguide

Quoted 43 lines

[amendment to d641ae6bfd4303508c86db9285c2dcba28fb5474] recipes reformatted, removed tab characters

---
 recipes/gsoap/gsoap-native_2.7.13.bb |    3 +--
 recipes/gsoap/gsoap_2.7.13.inc       |    8 ++++----
 2 files changed, 5 insertions(+), 6 deletions(-)
recipes/gsoap/gsoap-native_2.7.13.bb +1 -2
index 83c2329..cc323cb 100644
@@ -6,9 +6,8 @@ EXTRA_OEMAKE = ""
 
 inherit native
 
-
 do_install() {
-	install -m 0755 ${S}/gsoap/src/soapcpp2 ${STAGING_BINDIR_NATIVE}/
+    install -m 0755 ${S}/gsoap/src/soapcpp2 ${STAGING_BINDIR_NATIVE}/
 }
 
 
recipes/gsoap/gsoap_2.7.13.inc +4 -3
index c3ab3c4..3771486 100644
@@ -3,9 +3,10 @@ for the development of SOAP Web Services and clients."
 SECTION = "devel"
 LICENSE = "GPL"
 
-SRC_URI = "${SOURCEFORGE_MIRROR}/gsoap2/gsoap_${PV}.tar.gz	\
-	file://gsoap-2.7-openssl.patch	\
-	file://unused_args.patch"
+SRC_URI = "${SOURCEFORGE_MIRROR}/gsoap2/gsoap_${PV}.tar.gz \
+        file://gsoap-2.7-openssl.patch \
+        file://unused_args.patch \
+        "
 
 inherit autotools
 

recipes/gsoap/gsoap_2.7.13.inc S = "${WORKDIR}/gsoap-2.7" · line 17

Quoted 4 lines
recipes/gsoap/gsoap_2.7.13.inc +0 -1
@@ -14,4 +15,3 @@ S = "${WORKDIR}/gsoap-2.7"
 PARALLEL_MAKE = ""
 
 EXTRA_OEMAKE = "SOAP=${STAGING_BINDIR_NATIVE}/soapcpp2"
-

It is just formatting, so