Skip to contentSkip to conversation

omap: zoom: host should not pull up wl1271's irq line

PATCH New Ohad Ben-Cohen 2 participants 2 messages Mar 14, 2011

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

Ohad Ben-Cohen

author
#0 lore raw

PATCH 1/1 omap: zoom: host should not pull up wl1271's irq line

The wl1271's irq line is completely controlled by the 1271 device, and the host does not not need to pull it up.

While there's no functional effect, letting the host pull this line up is just redundant, and wastes power.

Signed-off-by Ohad Ben-Cohen <[email protected]>
---
 arch/arm/mach-omap2/board-zoom.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-zoom.c +1 -1
index e26754c..c59d07b 100644
@@ -49,7 +49,7 @@ static void __init omap_zoom_init_irq(void)
 #ifdef CONFIG_OMAP_MUX
 static struct omap_board_mux board_mux[] __initdata = {
 	/* WLAN IRQ - GPIO 162 */
-	OMAP3_MUX(MCBSP1_CLKX, OMAP_MUX_MODE4 | OMAP_PIN_INPUT_PULLUP),
+	OMAP3_MUX(MCBSP1_CLKX, OMAP_MUX_MODE4 | OMAP_PIN_INPUT),
 	/* WLAN POWER ENABLE - GPIO 101 */
 	OMAP3_MUX(CAM_D2, OMAP_MUX_MODE4 | OMAP_PIN_OUTPUT),
 	/* WLAN SDIO: MMC3 CMD */
Signature · 1 line
1.7.1
maintainer
#1 lore raw

PATCH 1/1 omap: zoom: host should not pull up wl1271's irq line

Quoted 5 lines · Ohad Ben-Cohen

The wl1271's irq line is completely controlled by the 1271 device, and the host does not not need to pull it up.

While there's no functional effect, letting the host pull this line up is just redundant, and wastes power.

Applying.

Tony