Skip to contentSkip to conversation

Staging: crystalhd: don't waste the last char of buffer

PATCH In review Dan Carpenter 2 participants 2 messages Mar 14, 2011

Subsystems (2)
Staging Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 2/2 Staging: crystalhd: don't waste the last char of buffer

pinfo->name is a 32 char buffer. In the original code, the last char wasn't fully utilized.

Signed-off-by Dan Carpenter <[email protected]>
drivers/staging/crystalhd/crystalhd_lnx.c +1 -1
index 4197111..7e0c199 100644
@@ -562,7 +562,7 @@ static int __devinit chd_dec_pci_probe(struct pci_dev *pdev,
 		goto err;
 	}
 
-	snprintf(pinfo->name, 31, "crystalhd_pci_e:%d:%d:%d",
+	snprintf(pinfo->name, sizeof(pinfo->name), "crystalhd_pci_e:%d:%d:%d",
 		 pdev->bus->number, PCI_SLOT(pdev->devfn),
 		 PCI_FUNC(pdev->devfn));