Skip to contentSkip to conversation

asus-wmi: signedness bug in read_brightness()

PATCH In review Dan Carpenter 2 participants 2 messages Mar 15, 2011

Subsystems (3)
Kernel janitors x86 platform drivers ASUS notebooks and eeepc ACPI/WMI extras drivers
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/2 asus-wmi: signedness bug in read_brightness()

"err" needs to be signed for the error handling to work.

Signed-off-by Dan Carpenter <[email protected]>
drivers/platform/x86/asus-wmi.c +2 -1
index 5b779a9..a038595 100644
@@ -946,7 +946,8 @@ static int read_brightness_max(struct asus_wmi *asus)
 static int read_brightness(struct backlight_device *bd)
 {
 	struct asus_wmi *asus = bl_get_data(bd);
-	u32 retval, err;
+	u32 retval;
+	int err;
 
 	err = asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_BRIGHTNESS, &retval);
maintainer Acked-by on v1 1/2
#1 lore raw
Quoted 9 lines · Dan Carpenter

"err" needs to be signed for the error handling to work.

Signed-off-by Dan Carpenter <[email protected]>
drivers/platform/x86/asus-wmi.c +0 -0
index 5b779a9..a038595 100644

drivers/platform/x86/asus-wmi.c static int read_brightness_max(struct asus_wmi *asus) · line 952

Quoted 8 lines
drivers/platform/x86/asus-wmi.c +2 -1
@@ -946,7 +946,8 @@ static int read_brightness_max(struct asus_wmi *asus)
  static int read_brightness(struct backlight_device *bd)
  {
        struct asus_wmi *asus = bl_get_data(bd);
-       u32 retval, err;
+       u32 retval;
+       int err;
 
        err = asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_BRIGHTNESS, &retval);

Hm, Thanks,

Acked-by Corentin Chary <[email protected]>
Signature · 2 lines
Corentin Chary
http://xf.iksaif.net