Skip to contentSkip to conversation

vlynq: fix resource size calculation

PATCH In review Dan Carpenter 2 participants 2 messages Mar 19, 2011 – Mar 21, 2011 Kernel janitors

lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 vlynq: fix resource size calculation

The original code had an off-by-one error so we didn't release the entire memory region on remove().

Signed-off-by Dan Carpenter <[email protected]>
drivers/vlynq/vlynq.c +1 -1
index f885c86..1d37553 100644
@@ -764,7 +764,7 @@ static int vlynq_remove(struct platform_device *pdev)
 
 	device_unregister(&dev->dev);
 	iounmap(dev->local);
-	release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start);
+	release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start + 1);
 
 	kfree(dev);
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · On Saturday 19 March 2011 05:38:13 Dan Carpenter wrote:

The original code had an off-by-one error so we didn't release the entire memory region on remove().

Signed-off-by Dan Carpenter <[email protected]>
Acked-by Florian Fainelli <[email protected]>
Quoted 13 lines
drivers/vlynq/vlynq.c +1 -1
index f885c86..1d37553 100644
@@ -764,7 +764,7 @@ static int vlynq_remove(struct platform_device *pdev)
 
 	device_unregister(&dev->dev);
 	iounmap(dev->local);
-	release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start);
+	release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start + 1);
 
 	kfree(dev);