Skip to contentSkip to conversation

Set the txqueuelen to zero when creating soft interface.

PATCH Applied Andrew Lunn 2 participants 2 messages Mar 23, 2011 – Mar 31, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Set the txqueuelen to zero when creating soft interface.

From e03cb760a296b55138dd6507b5e676c22cecf37e Mon Sep 17 00:00:00 2001
From: Andrew Lunn <[email protected]>
Date: Mon, 21 Mar 2011 21:31:44 +0100
Subject: [PATCH] [batman-adv] Set the txqueuelen to zero when creating soft interface.

Like other virtual interfaces, e.g. br0, we don't need a transmit queue. Packets should only be queued on real interfaces which are underneath. In practice this patch makes little difference since the virtual interfaces can accept packets as fast as they come, but the patch will avoid bufferbloat questions to the mailling lists in the future.

---
 soft-interface.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
soft-interface.c +1 -0
index 9ed2614..7230e33 100644
@@ -524,6 +524,7 @@ static void interface_setup(struct net_device *dev)
 	dev->hard_start_xmit = interface_tx;
 #endif
 	dev->destructor = free_netdev;
+	dev->tx_queue_len = 0;
 
 	/**
 	 * can't call min_mtu, because the needed variables
Signature · 1 line
1.7.4.1
#1 lore raw
Quoted 9 lines · On Wednesday 23 March 2011 13:15:03 Andrew Lunn wrote:

Like other virtual interfaces, e.g. br0, we don't need a transmit queue. Packets should only be queued on real interfaces which are underneath. In practice this patch makes little difference since the virtual interfaces can accept packets as fast as they come, but the patch will avoid bufferbloat questions to the mailling lists in the future.

Applied in revision ga2f8a49.

Thanks,
Marek