Skip to contentSkip to conversation

jrcu: precise vs sloppy sample timing

PATCH New Joe Korty 1 participant 1 message Mar 24, 2011

lore
Share & tools
lore

Joe Korty

author
#0 lore raw

PATCH 22/24 jrcu: precise vs sloppy sample timing

jrcu: test harness: increase sampling period precision.

Normally, jrcu tries to 'catch a ride' with any other local timer interrupt happening on the monitoring cpu. It does this through the hrtimer 'slop' mechanism. Such sloppiness, though, defeats attempts to stress-test jrcu via shortened sampling periods.

The precise/sloppy state is changeable at runtime:

echo precise=1 >/sys/kernel/debug/rcu/rcudata echo precise=0 >/sys/kernel/debug/rcu/rcudata

Signed-off-by Joe Korty <[email protected]>
kernel/jrcu.c +16 -3
Index: b/kernel/jrcu.c
===================================================================
@@ -137,6 +137,8 @@ static int rcu_hz = RCU_HZ;
 static int rcu_hz_period_us = RCU_HZ_PERIOD_US;
 static int rcu_hz_delta_us = RCU_HZ_DELTA_US;
 
+static int rcu_hz_precise;
+
 int rcu_scheduler_active __read_mostly;
 int rcu_nmi_seen __read_mostly;
 

@@ -436,7 +438,8 @@ static enum hrtimer_restart rcu_timer_fu
 	raise_softirq(RCU_SOFTIRQ);
 
 	next = ktime_add_ns(ktime_get(), rcu_hz_period_ns);
-	hrtimer_set_expires_range_ns(&rcu_timer, next, rcu_hz_delta_ns);
+	hrtimer_set_expires_range_ns(&rcu_timer, next,
+		rcu_hz_precise ? 0 : rcu_hz_delta_ns);
 	return HRTIMER_RESTART;
 }
 

@@ -539,7 +542,13 @@ static int jrcud_func(void *arg)
 	pr_info("JRCU: daemon started. Will operate at ~%d Hz.\n", rcu_hz);
 
 	while (!kthread_should_stop()) {
-		usleep_range(rcu_hz_period_us, rcu_hz_period_us + rcu_hz_delta_us);
+		if (rcu_hz_precise) {
+			usleep_range(rcu_hz_period_us,
+				rcu_hz_period_us);
+		} else {
+			usleep_range(rcu_hz_period_us,
+				rcu_hz_period_us + rcu_hz_delta_us);
+		}
 		rcu_delimit_batches();
 	}
 

@@ -576,7 +585,9 @@ static int rcu_debugfs_show(struct seq_f
 {
 	int cpu, q;
 
-	seq_printf(m, "%14u: hz\n", rcu_hz);
+	seq_printf(m, "%14u: hz, %s\n",
+		rcu_hz,
+		rcu_hz_precise ? "precise" : "sloppy");
 
 	seq_printf(m, "%14u: watchdog (secs)\n", rcu_wdog_lim / (int)USEC_PER_SEC);
 	seq_printf(m, "%14d: #secs left on watchdog\n",

@@ -686,6 +697,8 @@ next:
 			return -EINVAL;
 		rcu_hz = rcu_hz_wanted;
 		rcu_hz_period_us = USEC_PER_SEC / rcu_hz;
+	} else if (!strncmp(token, "precise=", 8)) {
+		sscanf(&token[8], "%d", &rcu_hz_precise);
 	} else if (!strncmp(token, "wdog=", 5)) {
 		int wdog = -1;
 		sscanf(&token[5], "%d", &wdog);