drivers: make device_type const

PATCH New Stephen Hemminger 1 participant 1 message Mar 28, 2011 Driver core

Share & tools

Stephen Hemminger

author

2011-03-28 16:12 UTC #0 lore raw

PATCH 1/1 drivers: make device_type const

The device_type structure does not contain data that changes during usage and should be const. This allows devices to declare the struct const.

I have patches to change all the subsystems, but need the infra structure change first.

Signed-off-by Stephen Hemminger <[email protected]>

---
 drivers/base/core.c    |    4 ++--
 include/linux/device.h |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

drivers/base/core.c +2 -2

@@ -400,7 +400,7 @@ static void device_remove_groups(struct
 static int device_add_attrs(struct device *dev)
 {
 	struct class *class = dev->class;
-	struct device_type *type = dev->type;
+	const struct device_type *type = dev->type;
 	int error;
 
 	if (class) {

@@ -440,7 +440,7 @@ static int device_add_attrs(struct devic
 static void device_remove_attrs(struct device *dev)
 {
 	struct class *class = dev->class;
-	struct device_type *type = dev->type;
+	const struct device_type *type = dev->type;
 
 	device_remove_groups(dev, dev->groups);

include/linux/device.h +1 -1

@@ -408,7 +408,7 @@ struct device {
 
 	struct kobject kobj;
 	const char		*init_name; /* initial name of the device */
-	struct device_type	*type;
+	const struct device_type *type;
 
 	struct mutex		mutex;	/* mutex to synchronize calls to
 					 * its driver.