Skip to contentSkip to conversation

x86: Remove dma32_reserve_bootmem

PATCH In review Yinghai Lu 3 participants 5 messages Mar 24, 2011 – Mar 28, 2011 x86

lore
Share & tools
lore

Yinghai Lu

author
#0 lore raw

PATCH 1/1 x86: Remove dma32_reserve_bootmem

That is workaround for holding dma32 buf when early bootmem could use up those range on system that have lots of RAM.

Now x86 is using memblock, and even nobootmem wrapper do top-down allocation.

So We could remove those not needed code now.

Signed-off-by Yinghai Lu <[email protected]>
---
 arch/x86/include/asm/pci.h |    2 -
 arch/x86/kernel/pci-dma.c  |   64 ---------------------------------------------
 arch/x86/kernel/setup.c    |    1
 3 files changed, 67 deletions(-)
arch/x86/include/asm/pci.h +0 -2
Index: linux-2.6/arch/x86/include/asm/pci.h
===================================================================
@@ -135,8 +135,6 @@ void default_teardown_msi_irqs(struct pc
 #include "pci_64.h"
 #endif
 
-void dma32_reserve_bootmem(void);
-
 /* implement the pci_ DMA API in terms of the generic device dma_ one */
 #include <asm-generic/pci-dma-compat.h>
arch/x86/kernel/pci-dma.c +0 -64

74 lines not on this page · raw message

arch/x86/kernel/setup.c +0 -1
Index: linux-2.6/arch/x86/kernel/setup.c
===================================================================
@@ -988,7 +988,6 @@ void __init setup_arch(char **cmdline_p)
 
 	initmem_init();
 	memblock_find_dma_reserve();
-	dma32_reserve_bootmem();
 
 #ifdef CONFIG_KVM_CLOCK
 	kvmclock_init();
#1 lore raw
Quoted 8 lines · Yinghai Lu

That is workaround for holding dma32 buf when early bootmem could use up those range on system that have lots of RAM.

Now x86 is using memblock, and even nobootmem wrapper do top-down allocation.

So We could remove those not needed code now.

Quoted 7 lines
Signed-off-by Yinghai Lu <[email protected]>
---
 arch/x86/include/asm/pci.h |    2 -
 arch/x86/kernel/pci-dma.c  |   64 ---------------------------------------------
 arch/x86/kernel/setup.c    |    1
 3 files changed, 67 deletions(-)
Cc -ing Jesse - i suspect this should be handled by the PCI tree.

Thanks,

Ingo

#2 lore raw
Quoted 13 lines · On Thu, 24 Mar 2011 09:03:26 +0100 Ingo Molnar <[email protected]> wrote:
Quoted 10 lines · Yinghai Lu

That is workaround for holding dma32 buf when early bootmem could use up those range on system that have lots of RAM.

Now x86 is using memblock, and even nobootmem wrapper do top-down allocation.

So We could remove those not needed code now.

Signed-off-by Yinghai Lu <[email protected]>
Quoted 7 lines
Quoted 5 lines
---
 arch/x86/include/asm/pci.h |    2 -
 arch/x86/kernel/pci-dma.c  |   64 ---------------------------------------------
 arch/x86/kernel/setup.c    |    1
 3 files changed, 67 deletions(-)
Cc -ing Jesse - i suspect this should be handled by the PCI tree.

Please re-send, sounds good in theory but I'd like to see the patch.

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center
#3 lore raw
Quoted 22 lines · Jesse Barnes
Quoted 19 lines · On Thu, 24 Mar 2011 09:03:26 +0100 Ingo Molnar <[email protected]> wrote:
Quoted 15 lines · Yinghai Lu

That is workaround for holding dma32 buf when early bootmem could use up those range on system that have lots of RAM.

Now x86 is using memblock, and even nobootmem wrapper do top-down allocation.

So We could remove those not needed code now.

Signed-off-by Yinghai Lu <[email protected]>
---
 arch/x86/include/asm/pci.h |    2 -
 arch/x86/kernel/pci-dma.c  |   64 ---------------------------------------------
 arch/x86/kernel/setup.c    |    1
 3 files changed, 67 deletions(-)
Quoted 3 lines
Quoted 1 line
Cc -ing Jesse - i suspect this should be handled by the PCI tree.

Please re-send, sounds good in theory but I'd like to see the patch.

It should be in your lkml folder, the first mail in this thread has the patch.

Thanks,

Ingo

#4 lore raw
Quoted 25 lines · On Mon, 28 Mar 2011 18:22:13 +0200 Ingo Molnar <[email protected]> wrote:
Quoted 22 lines · Jesse Barnes
Quoted 19 lines · On Thu, 24 Mar 2011 09:03:26 +0100 Ingo Molnar <[email protected]> wrote:
Quoted 15 lines · Yinghai Lu

That is workaround for holding dma32 buf when early bootmem could use up those range on system that have lots of RAM.

Now x86 is using memblock, and even nobootmem wrapper do top-down allocation.

So We could remove those not needed code now.

Signed-off-by Yinghai Lu <[email protected]>
---
 arch/x86/include/asm/pci.h |    2 -
 arch/x86/kernel/pci-dma.c  |   64 ---------------------------------------------
 arch/x86/kernel/setup.c    |    1
 3 files changed, 67 deletions(-)
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Cc -ing Jesse - i suspect this should be handled by the PCI tree.

Please re-send, sounds good in theory but I'd like to see the patch.

It should be in your lkml folder, the first mail in this thread has the patch.

If I kept everything in my lkml folder maybe... :)

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center