Skip to contentSkip to conversation

fbcon: Remove unused 'display *p' variable from fb_flashcursor()

PATCH In review Sergey Senozhatsky 3 participants 3 messages Mar 24, 2011 – Mar 29, 2011

Subsystems (2)
Framebuffer layer Console
lore
Share & tools
lore

Sergey Senozhatsky

author
#0 lore raw

PATCH 1/1 fbcon: Remove unused 'display *p' variable from fb_flashcursor()

fbcon: Remove unused 'display *p' variable from fb_flashcursor()

Signed-of-by Sergey Senozhatsky <[email protected]>

---

 drivers/video/console/fbcon.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/video/console/fbcon.c +0 -2
index c583934..8745637 100644
@@ -370,7 +370,6 @@ static void fb_flashcursor(struct work_struct *work)
 {
 	struct fb_info *info = container_of(work, struct fb_info, queue);
 	struct fbcon_ops *ops = info->fbcon_par;
-	struct display *p;
 	struct vc_data *vc = NULL;
 	int c;
 	int mode;

@@ -386,7 +385,6 @@ static void fb_flashcursor(struct work_struct *work)
 		return;
 	}
 
-	p = &fb_display[vc->vc_num];
 	c = scr_readw((u16 *) vc->vc_pos);
 	mode = (!ops->cursor_flash || ops->cursor_state.enable) ?
 		CM_ERASE : CM_DRAW;
#1 lore raw
Quoted 22 lines · On Thu, 24 Mar 2011 22:50:52 +0200 Sergey Senozhatsky…

fbcon: Remove unused 'display *p' variable from fb_flashcursor()

Signed-of-by Sergey Senozhatsky <[email protected]>

---

 drivers/video/console/fbcon.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/video/console/fbcon.c +0 -1
index c583934..8745637 100644
@@ -370,7 +370,6 @@ static void fb_flashcursor(struct work_struct *work)
 {
 	struct fb_info *info = container_of(work, struct fb_info, queue);
 	struct fbcon_ops *ops = info->fbcon_par;
-	struct display *p;
 	struct vc_data *vc = NULL;
 	int c;
 	int mode;

drivers/video/console/fbcon.c static void fb_flashcursor(struct work_struct *work) · line 390

Quoted 7 lines
drivers/video/console/fbcon.c +0 -1
@@ -386,7 +385,6 @@ static void fb_flashcursor(struct work_struct *work)
 		return;
 	}
 
-	p = &fb_display[vc->vc_num];
 	c = scr_readw((u16 *) vc->vc_pos);
 	mode = (!ops->cursor_flash || ops->cursor_state.enable) ?
 		CM_ERASE : CM_DRAW;

Looks fine to me, is Paul the lucky owner of fbdev now?

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center
#2 lore raw
Quoted 10 lines · Jesse Barnes
Quoted 4 lines · On Thu, 24 Mar 2011 22:50:52 +0200 Sergey Senozhatsky…

fbcon: Remove unused 'display *p' variable from fb_flashcursor()

Signed-of-by Sergey Senozhatsky <[email protected]>

Looks fine to me, is Paul the lucky owner of fbdev now?

Seems so. I'll roll the patch in with the next batch of fixes.