ufs: remove unessecary blk_flush_plug

PATCH In review Christoph Hellwig 2 participants 2 messages Mar 30, 2011 VFS

Share & tools

Christoph Hellwig

author

2011-03-30 09:57 UTC #0 lore raw

PATCH 1/1 ufs: remove unessecary blk_flush_plug

We already flush the per-process plugging list when context switching, so a blk_flush_plug call just before a yield() is not needed.

Signed-off-by Christoph Hellwig <[email protected]>

fs/ufs/truncate.c +0 -1

Index: xfs/fs/ufs/truncate.c
===================================================================
@@ -479,7 +479,6 @@ int ufs_truncate(struct inode *inode, lo
 			break;
 		if (IS_SYNC(inode) && (inode->i_state & I_DIRTY))
 			ufs_sync_inode (inode);
-		blk_flush_plug(current);
 		yield();
 	}

Jens Axboe

2011-03-30 10:18 UTC #1 lore raw

Quoted 10 lines · Christoph Hellwig

We already flush the per-process plugging list when context switching, so a blk_flush_plug call just before a yield() is not needed.
Signed-off-by Christoph Hellwig <[email protected]>
Index: xfs/fs/ufs/truncate.c
===================================================================

fs/ufs/truncate.c int ufs_truncate(struct inode *inode, lo · line 483

Quoted 6 lines

fs/ufs/truncate.c +0 -1

@@ -479,7 +479,6 @@ int ufs_truncate(struct inode *inode, lo
 			break;
 		if (IS_SYNC(inode) && (inode->i_state & I_DIRTY))
 			ufs_sync_inode (inode);
-		blk_flush_plug(current);
 		yield();
 	}

Added for .39 merge, thanks.

Signature · 1 line

Jens Axboe