Skip to contentSkip to conversation

x86, defconfig: replace ext3 with ext4

PATCH In review Konstantin Khlebnikov 3 participants 3 messages Apr 1, 2011 – Apr 4, 2011 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86, defconfig: replace ext3 with ext4

Replace ext3 with ext4, because now it is a de facto standard file system. And set CONFIG_EXT4_USE_FOR_EXT23=y to use it also for mounting ext2/ext3.

---
 arch/x86/configs/i386_defconfig   |    9 +++++----
 arch/x86/configs/x86_64_defconfig |    9 +++++----
 2 files changed, 10 insertions(+), 8 deletions(-)
arch/x86/configs/i386_defconfig +5 -4
index 6f98726..cb8268c 100644
@@ -269,10 +269,11 @@ CONFIG_RTC_CLASS=y
 CONFIG_DMADEVICES=y
 CONFIG_EEEPC_LAPTOP=y
 CONFIG_EFI_VARS=y
-CONFIG_EXT3_FS=y
-# CONFIG_EXT3_DEFAULTS_TO_ORDERED is not set
-CONFIG_EXT3_FS_POSIX_ACL=y
-CONFIG_EXT3_FS_SECURITY=y
+CONFIG_EXT4_FS=y
+CONFIG_EXT4_USE_FOR_EXT23=y
+CONFIG_EXT4_FS_XATTR=y
+CONFIG_EXT4_FS_POSIX_ACL=y
+CONFIG_EXT4_FS_SECURITY=y
 CONFIG_QUOTA=y
 CONFIG_QUOTA_NETLINK_INTERFACE=y
 # CONFIG_PRINT_QUOTA_WARNING is not set
arch/x86/configs/x86_64_defconfig +5 -4
index ee01a9d..033ec9a 100644
@@ -270,10 +270,11 @@ CONFIG_RTC_CLASS=y
 CONFIG_DMADEVICES=y
 CONFIG_EEEPC_LAPTOP=y
 CONFIG_EFI_VARS=y
-CONFIG_EXT3_FS=y
-# CONFIG_EXT3_DEFAULTS_TO_ORDERED is not set
-CONFIG_EXT3_FS_POSIX_ACL=y
-CONFIG_EXT3_FS_SECURITY=y
+CONFIG_EXT4_FS=y
+CONFIG_EXT4_USE_FOR_EXT23=y
+CONFIG_EXT4_FS_XATTR=y
+CONFIG_EXT4_FS_POSIX_ACL=y
+CONFIG_EXT4_FS_SECURITY=y
 CONFIG_QUOTA=y
 CONFIG_QUOTA_NETLINK_INTERFACE=y
 # CONFIG_PRINT_QUOTA_WARNING is not set
#1 lore raw
Quoted 2 lines · Konstantin Khlebnikov

Replace ext3 with ext4, because now it is a de facto standard file system. And set CONFIG_EXT4_USE_FOR_EXT23=y to use it also for mounting ext2/ext3.

I'm sorry but I think it's too early for CONFIG_EXT4_USE_FOR_EXT23 part.
Although ext4 can handle ext3 and is stable, I believe there hasn't been enough testing of ext4 code used as ext3 replacement. Some of the code paths used for handling of ext3 are different from those used for ext4 and there could be bugs lurking. Also ext4 has some slight differences in performance and behavior in corner cases to ext3 which can potentially screw users. I'm not saying these differences are showstoppers but we should at least (try to) identify them before exposing users to them.

Actually, I want to speak to some people about this this week at LSF to get some concensus on what exactly needs to be done so that we can replace ext[23] with ext4.

Honza

Quoted 47 lines
---
 arch/x86/configs/i386_defconfig   |    9 +++++----
 arch/x86/configs/x86_64_defconfig |    9 +++++----
 2 files changed, 10 insertions(+), 8 deletions(-)
arch/x86/configs/i386_defconfig +5 -4
index 6f98726..cb8268c 100644
@@ -269,10 +269,11 @@ CONFIG_RTC_CLASS=y
 CONFIG_DMADEVICES=y
 CONFIG_EEEPC_LAPTOP=y
 CONFIG_EFI_VARS=y
-CONFIG_EXT3_FS=y
-# CONFIG_EXT3_DEFAULTS_TO_ORDERED is not set
-CONFIG_EXT3_FS_POSIX_ACL=y
-CONFIG_EXT3_FS_SECURITY=y
+CONFIG_EXT4_FS=y
+CONFIG_EXT4_USE_FOR_EXT23=y
+CONFIG_EXT4_FS_XATTR=y
+CONFIG_EXT4_FS_POSIX_ACL=y
+CONFIG_EXT4_FS_SECURITY=y
 CONFIG_QUOTA=y
 CONFIG_QUOTA_NETLINK_INTERFACE=y
 # CONFIG_PRINT_QUOTA_WARNING is not set
arch/x86/configs/x86_64_defconfig +5 -4
index ee01a9d..033ec9a 100644
@@ -270,10 +270,11 @@ CONFIG_RTC_CLASS=y
 CONFIG_DMADEVICES=y
 CONFIG_EEEPC_LAPTOP=y
 CONFIG_EFI_VARS=y
-CONFIG_EXT3_FS=y
-# CONFIG_EXT3_DEFAULTS_TO_ORDERED is not set
-CONFIG_EXT3_FS_POSIX_ACL=y
-CONFIG_EXT3_FS_SECURITY=y
+CONFIG_EXT4_FS=y
+CONFIG_EXT4_USE_FOR_EXT23=y
+CONFIG_EXT4_FS_XATTR=y
+CONFIG_EXT4_FS_POSIX_ACL=y
+CONFIG_EXT4_FS_SECURITY=y
 CONFIG_QUOTA=y
 CONFIG_QUOTA_NETLINK_INTERFACE=y
 # CONFIG_PRINT_QUOTA_WARNING is not set
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
#2 lore raw
Quoted 4 lines · Jan Kara
Quoted 2 lines · Konstantin Khlebnikov

Replace ext3 with ext4, because now it is a de facto standard file system. And set CONFIG_EXT4_USE_FOR_EXT23=y to use it also for mounting ext2/ext3.

I'm sorry but I think it's too early for CONFIG_EXT4_USE_FOR_EXT23 part.

I considered the date of the email and then just ignored it. ;)