Skip to contentSkip to conversation

ALSA: usb-audio: define another USB ID for a buggy USB MIDI cable

PATCH In review Tarek Soliman 2 participants 3 messages Apr 3, 2011 – Apr 4, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: usb-audio: define another USB ID for a buggy USB MIDI cable

There are many USB MIDI cables out there that have buggy firmware that reports it can do more than 4 bytes in a packet when they can only properly handle 4

This patch adds the ID of yet another one of those cables

---
 sound/usb/midi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/usb/midi.c +1 -0
index b4b39c0..bdf5d9d 100644
@@ -1299,6 +1299,7 @@ static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi* umidi,
 	case USB_ID(0x0a92, 0x1020): /* ESI M4U */
 	case USB_ID(0x1430, 0x474b): /* RedOctane GH MIDI INTERFACE */
 	case USB_ID(0x15ca, 0x0101): /* Textech USB Midi Cable */
+	case USB_ID(0xfc08, 0x0101): /* Unknown vendor Cable */
 	case USB_ID(0x15ca, 0x1806): /* Textech USB Midi Cable */
 	case USB_ID(0x1a86, 0x752d): /* QinHeng CH345 "USB2.0-MIDI" */
 		ep->max_transfer = 4;
Signature · 3 lines
1.7.4.1
--
Tarek
#1 lore raw

At Sun, 3 Apr 2011 01:51:22 -0500,

Quoted 17 lines · Tarek Soliman

There are many USB MIDI cables out there that have buggy firmware that reports it can do more than 4 bytes in a packet when they can only properly handle 4

This patch adds the ID of yet another one of those cables

---
 sound/usb/midi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/usb/midi.c +0 -0
index b4b39c0..bdf5d9d 100644

sound/usb/midi.c static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi* umidi, · line 1304

Quoted 6 lines
sound/usb/midi.c +1 -0
@@ -1299,6 +1299,7 @@ static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi* umidi,
 	case USB_ID(0x0a92, 0x1020): /* ESI M4U */
 	case USB_ID(0x1430, 0x474b): /* RedOctane GH MIDI INTERFACE */
 	case USB_ID(0x15ca, 0x0101): /* Textech USB Midi Cable */
+	case USB_ID(0xfc08, 0x0101): /* Unknown vendor Cable */
 	case USB_ID(0x15ca, 0x1806): /* Textech USB Midi Cable */
 	case USB_ID(0x1a86, 0x752d): /* QinHeng CH345 "USB2.0-MIDI" */

The entries are sorted in the vendor id order. Could you fix the point to insert and resend the patch?

thanks,

Takashi

#2 lore raw
Quoted 30 lines · Takashi Iwai

At Sun, 3 Apr 2011 01:51:22 -0500,

Quoted 17 lines · Tarek Soliman

There are many USB MIDI cables out there that have buggy firmware that reports it can do more than 4 bytes in a packet when they can only properly handle 4

This patch adds the ID of yet another one of those cables

---
 sound/usb/midi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/usb/midi.c +0 -0
index b4b39c0..bdf5d9d 100644

sound/usb/midi.c static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi* umidi, · line 1304

Quoted 6 lines
sound/usb/midi.c +1 -0
@@ -1299,6 +1299,7 @@ static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi* umidi,
 	case USB_ID(0x0a92, 0x1020): /* ESI M4U */
 	case USB_ID(0x1430, 0x474b): /* RedOctane GH MIDI INTERFACE */
 	case USB_ID(0x15ca, 0x0101): /* Textech USB Midi Cable */
+	case USB_ID(0xfc08, 0x0101): /* Unknown vendor Cable */
 	case USB_ID(0x15ca, 0x1806): /* Textech USB Midi Cable */
 	case USB_ID(0x1a86, 0x752d): /* QinHeng CH345 "USB2.0-MIDI" */

The entries are sorted in the vendor id order. Could you fix the point to insert and resend the patch?

Quoted 3 lines

thanks,

Takashi

I did so. It should be a new thread in the mailing list.

Signature · 1 line
Tarek