drm/nouveau: printk info about disabled modesetting
Subsystems (3)
PATCH 1/1 drm/nouveau: printk info about disabled modesetting
... to make it obvious why nouveau refused to drive the hardware.
--- drivers/gpu/drm/nouveau/nouveau_drv.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/gpu/drm/nouveau/nouveau_drv.c +3 -1
@@ -445,8 +445,10 @@ static int __init nouveau_init(void) nouveau_modeset =1 ; } -if (!nouveau_modeset) +if (!nouveau_modeset) { +printk (KERN_INFO "nouveau: modesetting disabled by kernel parameter\n" );return 0 ; + }nouveau_register_dsm_handler ();return drm_init (&driver);
Signature · 1 line
1.7.4.1
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 14 lines · Marcin Slusarz
... to make it obvious why nouveau refused to drive the hardware.
Signed-off-by Marcin Slusarz <[email protected]>--- drivers/gpu/drm/nouveau/nouveau_drv.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)drivers/gpu/drm/nouveau/nouveau_drv.c +0
-0@@ -445,8 +445,10 @@ static int __init nouveau_init(void) nouveau_modeset =1 ;
drivers/gpu/drm/nouveau/nouveau_drv.c static int __init nouveau_init(void) · line 454
Quoted 10 lines
drivers/gpu/drm/nouveau/nouveau_drv.c +3
-1} -if (!nouveau_modeset) +if (!nouveau_modeset) { +printk (KERN_INFO "nouveau: modesetting disabled by kernel parameter\n" );return 0 ; + }nouveau_register_dsm_handler ();return drm_init (&driver);
ping
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 22 lines · Marcin Slusarz
Quoted 21 lines · Marcin Slusarz
... to make it obvious why nouveau refused to drive the hardware.
Signed-off-by Marcin Slusarz <[email protected]>--- drivers/gpu/drm/nouveau/nouveau_drv.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)drivers/gpu/drm/nouveau/nouveau_drv.c +3
-1@@ -445,8 +445,10 @@ static int __init nouveau_init(void) nouveau_modeset =1 ; } -if (!nouveau_modeset) +if (!nouveau_modeset) { +printk (KERN_INFO "nouveau: modesetting disabled by kernel parameter\n" );return 0 ; + }
Quoted 5 lines
drivers/gpu/drm/nouveau/nouveau_drv.c static int __init nouveau_init(void) · line 454
Quoted 3 lines
drivers/gpu/drm/nouveau/nouveau_drv.c +0
-0nouveau_register_dsm_handler ();return drm_init (&driver);ping
I just wonder how this is useful. I don't find it hard when looking at people's logs to scroll to the top and look at the kernel commandline.
Really, that should be done *anyway* as there are many more options that are relevant to what nouveau does/does not do as well...
Ben.
Quoted 5 lines
_______________________________________________
Nouveau mailing list [email protected]
http://lists.freedesktop.org/mailman/listinfo/nouveau
Quoted 23 lines · Ben Skeggs
Quoted 22 lines · Marcin Slusarz
Quoted 21 lines · Marcin Slusarz
... to make it obvious why nouveau refused to drive the hardware.
Signed-off-by Marcin Slusarz <[email protected]>--- drivers/gpu/drm/nouveau/nouveau_drv.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)drivers/gpu/drm/nouveau/nouveau_drv.c +3
-1@@ -445,8 +445,10 @@ static int __init nouveau_init(void) nouveau_modeset =1 ; } -if (!nouveau_modeset) +if (!nouveau_modeset) { +printk (KERN_INFO "nouveau: modesetting disabled by kernel parameter\n" );return 0 ; + }
Quoted 7 lines
Quoted 5 lines
drivers/gpu/drm/nouveau/nouveau_drv.c static int __init nouveau_init(void) · line 454
Quoted 3 lines
drivers/gpu/drm/nouveau/nouveau_drv.c +0
-0nouveau_register_dsm_handler ();return drm_init (&driver);ping
I just wonder how this is useful. I don't find it hard when looking at people's logs to scroll to the top and look at the kernel commandline.
It's not all about kernel commandline (but it's still nice to have it). You can pass modeset=0 by modprobe.conf and there's no way to read it from dmesg later.
It just simplifies troubleshooting by taking one of the most frequent reasons of "nouveau does not detect my card"...
Quoted 2 lines
Really, that should be done *anyway* as there are many more options that are relevant to what nouveau does/does not do as well...
Yes. But no other parameter silently disables whole module.
Marcin
Quoted 23 lines · On Mon, 02 May 2011 16:51:14 +1000 Ben Skeggs…
Quoted 22 lines · Marcin Slusarz
Quoted 21 lines · Marcin Slusarz
... to make it obvious why nouveau refused to drive the hardware.
Signed-off-by Marcin Slusarz <[email protected]>--- drivers/gpu/drm/nouveau/nouveau_drv.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)drivers/gpu/drm/nouveau/nouveau_drv.c +3
-1@@ -445,8 +445,10 @@ static int __init nouveau_init(void) nouveau_modeset =1 ; } -if (!nouveau_modeset) +if (!nouveau_modeset) { +printk (KERN_INFO "nouveau: modesetting disabled by kernel parameter\n" );return 0 ; + }
Quoted 7 lines
Quoted 5 lines
drivers/gpu/drm/nouveau/nouveau_drv.c static int __init nouveau_init(void) · line 454
Quoted 3 lines
drivers/gpu/drm/nouveau/nouveau_drv.c +0
-0nouveau_register_dsm_handler ();return drm_init (&driver);ping
I just wonder how this is useful. I don't find it hard when looking at people's logs to scroll to the top and look at the kernel commandline.
The kernel command line does not show module parameters.
It appears, that recently something has started to add KMS-disabling options to modprobe.conf or equivalent, and those can be further hidden in initramfs.
Otherwise we have to start asking to dig the parameters from sysfs on mysterious does-not-work problems.
Quoted 2 lines
Really, that should be done *anyway* as there are many more options that are relevant to what nouveau does/does not do as well...
Then maybe we need debug options for those, too, or does the drm core already print the core options for some value of drm.debug?
Thanks.
Signature · 2 lines
Pekka Paalanen http://www.iki.fi/pq/