powerpc: clean up DIU macro definitions for Freescale reference boards
PATCH v4 1/1 powerpc: clean up DIU macro definitions for Freescale reference boards
Clean up the macro defintions used to enable DIU (video) support on the MPC8610HPCD and the MPC5121ADS so that they look more like the P1022DS, which is newer. Add software cursor support to all three boards.
Also document the CONFIG_FSL_DIU_FB in the README.
--- README | 22 ++++++++++++++++++++++ include/configs/MPC8610HPCD.h | 13 ++++--------- include/configs/P1022DS.h | 3 +-- include/configs/mpc5121ads.h | 9 ++++----- 4 files changed, 31 insertions(+), 16 deletions(-)
README +22 -0
@@ -1057,6 +1057,28 @@ The following options need to be configured: and 16bpp modes defined by CONFIG_VIDEO_SED13806_8BPP or CONFIG_VIDEO_SED13806_16BPP + CONFIG_FSL_DIU_FB + Enable the Freescale DIU video driver. Reference boards for + SOCs that have a DIU should define this macro to enable DIU + support, and should also define these other macros: + + CONFIG_SYS_DIU_ADDR + CONFIG_VIDEO + CONFIG_CMD_BMP + CONFIG_CFB_CONSOLE + CONFIG_VIDEO_SW_CURSOR + CONFIG_VGA_AS_SINGLE_DEVICE + CONFIG_VIDEO_LOGO + CONFIG_VIDEO_BMP_LOGO + + The DIU driver will look for the 'monitor' environment variable, + and if defined, enable the DIU as a console during boot. This + variable should be set to one of these values: + + '0' Output video to the DVI connector + '1' Output video to the LVDS connector + '2' Output video to the Dual-Link LVDS connector + - Keyboard Support: CONFIG_KEYBOARD
include/configs/MPC8610HPCD.h +4 -9
@@ -21,14 +21,14 @@#define CONFIG_SYS_TEXT_BASE 0xfff00000 -#define CONFIG_FSL_DIU_FB 1/* FSL DIU */ /* video */ -#undef CONFIG_VIDEO - -#ifdef CONFIG_VIDEO +#ifdef CONFIG_FSL_DIU_FB +#define CONFIG_SYS_DIU_ADDR (CONFIG_SYS_CCSRBAR + 0x2c000) +#define CONFIG_VIDEO #define CONFIG_CMD_BMP #define CONFIG_CFB_CONSOLE +#define CONFIG_VIDEO_SW_CURSOR #define CONFIG_VGA_AS_SINGLE_DEVICE #define CONFIG_VIDEO_LOGO #define CONFIG_VIDEO_BMP_LOGO
@@ -88,8 +88,6 @@#define CONFIG_SYS_CCSRBAR_PHYS_HIGH 0x0#define CONFIG_SYS_CCSRBAR_PHYS CONFIG_SYS_CCSRBAR_PHYS_LOW -#define CONFIG_SYS_DIU_ADDR (CONFIG_SYS_CCSRBAR+0x2c000) -/* DDR Setup */ #define CONFIG_FSL_DDR2 #undef CONFIG_FSL_DDR_INTERACTIVE
@@ -494,9 +492,6 @@#define CONFIG_WATCHDOG /* watchdog enabled */ #define CONFIG_SYS_WATCHDOG_FREQ 5000/* Feed interval, 5s */ -/*DIU Configuration*/ -#define DIU_CONNECT_TO_DVI /* DIU controller connects to DVI encoder*/ -/* * Miscellaneous configurable options */
include/configs/P1022DS.h +1 -2
@@ -185,13 +185,12 @@#define CONFIG_SYS_PROMPT_HUSH_PS2 "> "/* Video */ -#undef CONFIG_FSL_DIU_FB -#ifdef CONFIG_FSL_DIU_FB #define CONFIG_SYS_DIU_ADDR (CONFIG_SYS_CCSRBAR + 0x10000)#define CONFIG_VIDEO #define CONFIG_CMD_BMP #define CONFIG_CFB_CONSOLE +#define CONFIG_VIDEO_SW_CURSOR #define CONFIG_VGA_AS_SINGLE_DEVICE #define CONFIG_VIDEO_LOGO #define CONFIG_VIDEO_BMP_LOGO
include/configs/mpc5121ads.h +4 -5
@@ -46,16 +46,16 @@*/ #define CONFIG_E300 1/* E300 Family */ #define CONFIG_MPC512X 1/* MPC512X family */ -#define CONFIG_FSL_DIU_FB 1/* FSL DIU */ #define CONFIG_SYS_TEXT_BASE 0xFFF00000/* video */ -#undef CONFIG_VIDEO - -#ifdef CONFIG_VIDEO +#ifdef CONFIG_FSL_DIU_FB +#define CONFIG_SYS_DIU_ADDR (CONFIG_SYS_IMMR + 0x2100) +#define CONFIG_VIDEO #define CONFIG_CMD_BMP #define CONFIG_CFB_CONSOLE +#define CONFIG_VIDEO_SW_CURSOR #define CONFIG_VGA_AS_SINGLE_DEVICE #define CONFIG_VIDEO_LOGO #define CONFIG_VIDEO_BMP_LOGO
@@ -74,7 +74,6 @@#define CONFIG_MISC_INIT_R #define CONFIG_SYS_IMMR 0x80000000 -#define CONFIG_SYS_DIU_ADDR (CONFIG_SYS_IMMR+0x2100)#define CONFIG_SYS_MEMTEST_START 0x00200000/* memtest region */ #define CONFIG_SYS_MEMTEST_END 0x00400000
Signature · 1 line
1.7.3.4
PATCH v4 1/1 powerpc: clean up DIU macro definitions for Freescale reference boards
Quoted 7 lines · Timur Tabi
Clean up the macro defintions used to enable DIU (video) support on the MPC8610HPCD and the MPC5121ADS so that they look more like the P1022DS, which is newer. Add software cursor support to all three boards.
Also document the
CONFIG_FSL_DIU_FBin the README.Signed-off-by Timur Tabi <[email protected]>
Wolfgang,
If you're okay with this patch, could you ACK it so that Kumar can queue it for -next?
Signature · 2 lines
Timur Tabi Linux kernel developer at Freescale
PATCH v4 1/1 powerpc: clean up DIU macro definitions for Freescale reference boards
Quoted 5 lines · Timur Tabi
Quoted 4 lines · Timur Tabi
Clean up the macro defintions used to enable DIU (video) support on the MPC8610HPCD and the MPC5121ADS so that they look more like the P1022DS, which is newer. Add software cursor support to all three boards.
Quoted 9 lines
Quoted 3 lines
Also document the
CONFIG_FSL_DIU_FBin the README.Signed-off-by Timur Tabi <[email protected]>Wolfgang,
If you're okay with this patch, could you ACK it so that Kumar can queue it for -next?
Wolfgang,
Please ACK based on previous comments.
- k
PATCH v4 1/1 powerpc: clean up DIU macro definitions for Freescale reference boards
Dear Kumar Gala,
Quoted 11 lines · In message <[email protected]> you wrote:
Quoted 11 lines
Quoted 8 lines
Clean up the macro defintions used to enable DIU (video) support on the MPC8610HPCD and the MPC5121ADS so that they look more like the P1022DS, which is newer. Add software cursor support to all three boards.
Also document the
CONFIG_FSL_DIU_FBin the README.Signed-off-by Timur Tabi <[email protected]>Wolfgang,
Quoted 7 lines
Quoted 3 lines
If you're okay with this patch, could you ACK it so that Kumar can > queue it for -next?
Wolfgang,
Please ACK based on previous comments.
Why me?
Video stuff is obviously something the video custodian should handle.
Of course, this would require that Timur puts the responsible custodian on Cc: ...
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Business is like a wheelbarrow. Nothing ever happens until you start pushing.
PATCH v4 1/1 powerpc: clean up DIU macro definitions for Freescale reference boards
Quoted 4 lines · Wolfgang Denk
Video stuff is obviously something the video custodian should handle.
Of course, this would require that Timur puts the responsible custodian on Cc: ...
I personally don't see how the video maintainer needs to get involved, since I'm just changing a few macros in board header files. That's why the patch is labeled "powerpc:" and not "video:".
Signature · 2 lines
Timur Tabi Linux kernel developer at Freescale
PATCH v4 1/1 powerpc: clean up DIU macro definitions for Freescale reference boards
Dear Timur Tabi,
Quoted 4 lines · In message <[email protected]> you wrote:
I personally don't see how the video maintainer needs to get involved, since I'm just changing a few macros in board header files. That's why the patch is labeled "powerpc:" and not "video:".
The fact that you label something A does not mean that it should acutally be B instead.
You know my position. I want to see at least Anatolij's ACK on this.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Stupidity, like virtue, is its own reward.
PATCH v4 1/1 powerpc: clean up DIU macro definitions for Freescale reference boards
In reply to Wolfgang DenkQuoted 18 lines · Wolfgang Denk
Dear Kumar Gala,
Quoted 15 lines · In message <[email protected]> you wrote:
Quoted 14 lines
Quoted 8 lines
Clean up the macro defintions used to enable DIU (video) support on the MPC8610HPCD and the MPC5121ADS so that they look more like the P1022DS, which is newer. Add software cursor support to all three boards.
Also document the
CONFIG_FSL_DIU_FBin the README.Signed-off-by Timur Tabi <[email protected]>Wolfgang,
If you're okay with this patch, could you ACK it so that Kumar can > queue it for -next?
Quoted 5 lines
Quoted 3 lines
Wolfgang,
Please ACK based on previous comments.
Why me?
I was only looking for ACK because of your feedback on the patch. I like to assume any case that has significant feedback its reasonable for the main feedback giver to ack at some point.
- k
PATCH v4 1/1 powerpc: clean up DIU macro definitions for Freescale reference boards
Dear Kumar Gala,
Quoted 8 lines · In message <[email protected]> you wrote:
Quoted 4 lines
Quoted 2 lines
Please ACK based on previous comments.
Why me?
I was only looking for ACK because of your feedback on the patch. I like to assume any case that has significant feedback its reasonable for the main feedback giver to ack at some point.
I see. But the really missing ACK is Anatolij's.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Compassion -- that's the one things no machine ever had. Maybe it's the one thing that keeps men ahead of them. -- McCoy, "The Ultimate Computer", stardate 4731.3
PATCH v4 1/1 powerpc: clean up DIU macro definitions for Freescale reference boards
In reply to Timur TabiQuoted 6 lines · On Tue, 15 Feb 2011 17:09:19 -0600 Timur Tabi <[email protected]> wrote:
Clean up the macro defintions used to enable DIU (video) support on the MPC8610HPCD and the MPC5121ADS so that they look more like the P1022DS, which is newer. Add software cursor support to all three boards.
Also document the
CONFIG_FSL_DIU_FBin the README.
Quoted 7 lines
Signed-off-by Timur Tabi <[email protected]>--- README | 22 ++++++++++++++++++++++ include/configs/MPC8610HPCD.h | 13 ++++--------- include/configs/P1022DS.h | 3 +-- include/configs/mpc5121ads.h | 9 ++++----- 4 files changed, 31 insertions(+), 16 deletions(-)
Kumar Gala
AppliedPATCH v4 1/1 powerpc: clean up DIU macro definitions for Freescale reference boards
In reply to Timur TabiQuoted 6 lines · Timur Tabi
Clean up the macro defintions used to enable DIU (video) support on the MPC8610HPCD and the MPC5121ADS so that they look more like the P1022DS, which is newer. Add software cursor support to all three boards.
Also document the
CONFIG_FSL_DIU_FBin the README.
Quoted 7 lines
Signed-off-by Timur Tabi <[email protected]>---
README | 22 ++++++++++++++++++++++ include/configs/MPC8610HPCD.h | 13 ++++--------- include/configs/P1022DS.h | 3 +-- include/configs/mpc5121ads.h | 9 ++++----- 4 files changed, 31 insertions(+), 16 deletions(-)
applied to 85xx
- k
PATCH v4 1/1 powerpc: clean up DIU macro definitions for Freescale reference boards
In reply to Timur TabiDear Timur Tabi,
Quoted 3 lines · In message <[email protected]> you wrote:
Clean up the macro defintions used to enable DIU (video) support on the MPC8610HPCD and the MPC5121ADS so that they look more like the P1022DS, which is newer. Add software cursor support to all three boards.
Software cursor support should be split off into a separate patch. And CONFIG_VIDEO_SW_CURSOR needs to be documented.
Quoted 1 line
Also document the
CONFIG_FSL_DIU_FBin the README.
...
README The following options need to be configured: · line 1080
Quoted 7 lines
README +7
-0+ The DIU driver will look for the 'monitor' environment variable, + and if defined, enable the DIU as a console during boot. This + variable should be set to one of these values: + + '0' Output video to the DVI connector + '1' Output video to the LVDS connector + '2' Output video to the Dual-Link LVDS connector
Maybe it would be more user-friendly if we used easy to remember names instead of some magic numbers, like "dvi", "lvds" resp. "dlvds" (or whatever) ?
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de I used to be indecisive, now I'm not sure.
PATCH v4 1/1 powerpc: clean up DIU macro definitions for Freescale reference boards
Quoted 2 lines · Wolfgang Denk
Software cursor support should be split off into a separate patch. And
CONFIG_VIDEO_SW_CURSORneeds to be documented.
That feature is already in U-Boot. All I'm doing is adding a #define CONFIG_VIDEO_SW_CURSOR to the header file. I thought it was already documented somewhere.
Quoted 7 lines
Quoted 3 lines
Quoted 3 lines
+ '0' Output video to the DVI connector
+ '1' Output video to the LVDS connector
+ '2' Output video to the Dual-Link LVDS connectorMaybe it would be more user-friendly if we used easy to remember names instead of some magic numbers, like "dvi", "lvds" resp. "dlvds" (or whatever) ?
That's already fixed in my follow-up patch that is waiting for Anatolij's ACK.
Signature · 2 lines
Timur Tabi Linux kernel developer