Skip to contentSkip to conversation

arm: omap: introduce OMAP MCOP board file

PATCH New Felipe Balbi 4 participants 6 messages Apr 5, 2011

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: omap: introduce OMAP MCOP board file

From: Michael Fillinger <[email protected]>

MCOP is an FPGA-based Silicon Validation platform
which is used to test particular IPs inside OMAP
before we have a real ASIC.

[ balbi at ti.com : few cleanups here an there and also
removal of some unnecessary code. ]

---
 arch/arm/mach-omap2/Kconfig                  |    7 +++
 arch/arm/mach-omap2/Makefile                 |    1 +
 arch/arm/mach-omap2/board-mcop.c             |   60 ++++++++++++++++++++++++++
 arch/arm/plat-omap/include/plat/uncompress.h |    1 +
 4 files changed, 69 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-omap2/board-mcop.c
arch/arm/mach-omap2/Kconfig +7 -0
index 1a2cf62..6f5699f 100644
@@ -116,6 +116,13 @@ config MACH_OMAP_H4
 	select OMAP_PACKAGE_ZAF
 	select OMAP_DEBUG_DEVICES
 
+config MACH_OMAP_MCOP
+	bool "OMAP MCOP Board"
+	depends on ARCH_OMAP2420
+	default y
+#	select OMAP_PACKAGE_ZAF
+#	select OMAP_DEBUG_DEVICES
+
 config MACH_OMAP_APOLLON
 	bool "OMAP 2420 Apollon board"
 	depends on ARCH_OMAP2420
arch/arm/mach-omap2/Makefile +1 -0
index 1c0c2b0..6db99c4 100644
@@ -153,6 +153,7 @@ endif
 # Specific board support
 obj-$(CONFIG_MACH_OMAP_GENERIC)		+= board-generic.o
 obj-$(CONFIG_MACH_OMAP_H4)		+= board-h4.o
+obj-$(CONFIG_MACH_OMAP_MCOP)		+= board-mcop.o
 obj-$(CONFIG_MACH_OMAP_2430SDP)		+= board-2430sdp.o \
 					   hsmmc.o
 obj-$(CONFIG_MACH_OMAP_APOLLON)		+= board-apollon.o
arch/arm/mach-omap2/board-mcop.c new file +60 -0

60 lines not on this page · raw message

arch/arm/plat-omap/include/plat/uncompress.h +1 -0
index ad98b85..dbedd6e 100644
@@ -129,6 +129,7 @@ static inline void __arch_decomp_setup(unsigned long arch_id)
 		DEBUG_LL_OMAP2(1, omap_2430sdp);
 		DEBUG_LL_OMAP2(1, omap_apollon);
 		DEBUG_LL_OMAP2(1, omap_h4);
+		DEBUG_LL_OMAP2(1, omapmcop);
 
 		/* omap2 based boards using UART3 */
 		DEBUG_LL_OMAP2(3, nokia_n800);
Signature · 1 line
1.7.4.1.343.ga91df
#1 lore raw

PATCH 1/1 arm: omap: introduce OMAP MCOP board file

Quoted 6 lines · Felipe Balbi

From: Michael Fillinger <[email protected]>

MCOP is an FPGA-based Silicon Validation platform
which is used to test particular IPs inside OMAP
before we have a real ASIC.

Quoted 6 lines

[ balbi at ti.com : few cleanups here an there and also
removal of some unnecessary code. ]

I should have RFCed this one, but bear with me for a minute.

This is just the bare minimum board-file for MCOP, there's still a bunch of changes needed to get it actually booting. The attached diff shows many of them.

Now, we don't want to send that patch upstream for obvious reasons and we also don't want to add ifdefs to clock data files as that would break multi-omap. What do you guys suggest ? How should we handle detection of MCOP so that we choose correct HWMODs and clock data files for it ?

I don't think Linus will like if we add yet another hwmod + clk data file just for MCOP, so we need to re-use what's in tree.

Signature · 8 lines
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mcop_remaining.diff
Type: text/x-diff
Size: 30349 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110405/ea0208f9/attachment-0001.bin>
#2 lore raw

PATCH 1/1 arm: omap: introduce OMAP MCOP board file

Quoted 25 lines · Felipe Balbi
Quoted 6 lines · Felipe Balbi

From: Michael Fillinger <[email protected]>

MCOP is an FPGA-based Silicon Validation platform
which is used to test particular IPs inside OMAP
before we have a real ASIC.

Quoted 6 lines

[ balbi at ti.com : few cleanups here an there and also
removal of some unnecessary code. ]

I should have RFCed this one, but bear with me for a minute.

This is just the bare minimum board-file for MCOP, there's still a bunch of changes needed to get it actually booting. The attached diff shows many of them.

Now, we don't want to send that patch upstream for obvious reasons and we also don't want to add ifdefs to clock data files as that would break multi-omap. What do you guys suggest ? How should we handle detection of MCOP so that we choose correct HWMODs and clock data files for it ?

Quoted 5 lines

I don't think Linus will like if we add yet another hwmod + clk data file just for MCOP, so we need to re-use what's in tree.

--
Balbi

What you need to know about the MCOP system, based on OMAP2420, is that there is no PRCM and no complex clock trees, or power management. There is just 1 main driver clock. As such the "clock tree" can be extremely simplified.

Michael

Texas Instruments France SA, 821 Avenue Jack Kilby, 06270 Villeneuve Loubet. 036 420 040 R.C.S Antibes. Capital de EUR 753.920

#3 lore raw

PATCH 1/1 arm: omap: introduce OMAP MCOP board file

In reply to Felipe Balbi
Quoted 20 lines · Felipe Balbi
Quoted 6 lines · Felipe Balbi

From: Michael Fillinger <[email protected]>

MCOP is an FPGA-based Silicon Validation platform
which is used to test particular IPs inside OMAP
before we have a real ASIC.

Quoted 6 lines

[ balbi at ti.com : few cleanups here an there and also
removal of some unnecessary code. ]

I should have RFCed this one, but bear with me for a minute.

This is just the bare minimum board-file for MCOP, there's still a bunch of changes needed to get it actually booting. The attached diff shows many of them.

Quoted 7 lines

Now, we don't want to send that patch upstream for obvious reasons and we also don't want to add ifdefs to clock data files as that would break multi-omap. What do you guys suggest ? How should we handle detection of MCOP so that we choose correct HWMODs and clock data files for it ?

I don't think Linus will like if we add yet another hwmod + clk data file just for MCOP, so we need to re-use what's in tree.

I'd suggest holding fire on new stuff.

We *absolutely* *must* show that we're taking Linus' complaint seriously and make headway towards consolidating some of the code. I don't see that activity as optional.

I've now made the decision (as I mentioned I may do in the thread) that for the next merge window I'm only taking consolidations and bug fixes through my tree, and I encourage everyone else to do the same. At the moment, I'm planning for this up until the next merge window, but if sufficient progress hasn't been done, I'll extend it thereafter.

In other words, no new platform code and no new platform class code.

The longer it takes to get the consolidation effort producing results, the longer we will have to keep the restriction in place, and the more painful it'll be for people who want to have their platforms merged.

So I hope *no* one is thinking "this isn't my problem, someone else will solve it" - if you're thinking that then we're doomed.

#4 lore raw

PATCH 1/1 arm: omap: introduce OMAP MCOP board file

Hi,

Quoted 15 lines · Russell King - ARM Linux
Quoted 2 lines

I don't think Linus will like if we add yet another hwmod + clk data file just for MCOP, so we need to re-use what's in tree.

I'd suggest holding fire on new stuff.

We *absolutely* *must* show that we're taking Linus' complaint seriously and make headway towards consolidating some of the code. I don't see that activity as optional.

I've now made the decision (as I mentioned I may do in the thread) that for the next merge window I'm only taking consolidations and bug fixes through my tree, and I encourage everyone else to do the same. At the moment, I'm planning for this up until the next merge window, but if sufficient progress hasn't been done, I'll extend it thereafter.

Quoted 8 lines

In other words, no new platform code and no new platform class code.

The longer it takes to get the consolidation effort producing results, the longer we will have to keep the restriction in place, and the more painful it'll be for people who want to have their platforms merged.

So I hope *no* one is thinking "this isn't my problem, someone else will solve it" - if you're thinking that then we're doomed.

Ok Russell, we will hold on to this patch and try to help as we can on the code consolidation effort.

Let's hope to get this sorted out soon as it would be really great for us to start pre-silicon validation with mainline kernel with little to no effort needed :-D

Signature · 1 line
balbi
maintainer
#5 lore raw

PATCH 1/1 arm: omap: introduce OMAP MCOP board file

In reply to Russell King - ARM Linux
Quoted 6 lines · Russell King - ARM Linux

I'd suggest holding fire on new stuff.

We *absolutely* *must* show that we're taking Linus' complaint seriously and make headway towards consolidating some of the code. I don't see that activity as optional.

I agree.

Quoted 5 lines

I've now made the decision (as I mentioned I may do in the thread) that for the next merge window I'm only taking consolidations and bug fixes through my tree, and I encourage everyone else to do the same. At the moment, I'm planning for this up until the next merge window, but if sufficient progress hasn't been done, I'll extend it thereafter.

OK

Quoted 8 lines

In other words, no new platform code and no new platform class code.

The longer it takes to get the consolidation effort producing results, the longer we will have to keep the restriction in place, and the more painful it'll be for people who want to have their platforms merged.

So I hope *no* one is thinking "this isn't my problem, someone else will solve it" - if you're thinking that then we're doomed.

Yes we need more people to pitch in to the consolidation process, so everybody please help where possible.

Regards,

Tony