Skip to contentSkip to conversation

video: imx-fb: just depend on IMX_HAVE_PLATFORM_IMX_FB

PATCH New Uwe Kleine-König 4 participants 10 messages Apr 6, 2011 – Apr 9, 2011

Subsystems (4)
Arm (32-bit) Arm sub-architectures Arm i.MX and Layerscape Framebuffer layer
lore
Share & tools
lore

Uwe Kleine-König

author
#0 lore raw

PATCH 1/1 video: imx-fb: just depend on IMX_HAVE_PLATFORM_IMX_FB

All machines having a imx-fb device now select IMX_HAVE_PLATFORM_IMX_FB, so HAVE_FB_IMX can go away and there is no need anymore to explicitly depend on ARCH_MX1 or ARCH_MX2.

Signed-off-by Uwe Kleine-K?nig <[email protected]>

---
Hello,

should this go via Sascha's or Paul's tree?

Best regards
Uwe

 arch/arm/plat-mxc/devices/Kconfig |    1 -
 drivers/video/Kconfig             |    5 +----
 2 files changed, 1 insertions(+), 5 deletions(-)
arch/arm/plat-mxc/devices/Kconfig +0 -1
index b9ab1d5..e4dcf49 100644
@@ -24,7 +24,6 @@ config IMX_HAVE_PLATFORM_IMXDI_RTC
 
 config IMX_HAVE_PLATFORM_IMX_FB
 	bool
-	select HAVE_FB_IMX
 
 config IMX_HAVE_PLATFORM_IMX_I2C
 	bool
drivers/video/Kconfig +1 -4
index e6a8d8c..62f337a 100644
@@ -8,9 +8,6 @@ menu "Graphics support"
 config HAVE_FB_ATMEL
 	bool
 
-config HAVE_FB_IMX
-	bool
-
 config SH_MIPI_DSI
 	tristate
 	depends on (SUPERH || ARCH_SHMOBILE) && HAVE_CLK

@@ -359,7 +356,7 @@ config FB_SA1100
 
 config FB_IMX
 	tristate "Freescale i.MX LCD support"
-	depends on FB && (HAVE_FB_IMX || ARCH_MX1 || ARCH_MX2)
+	depends on FB && IMX_HAVE_PLATFORM_IMX_FB
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
Signature · 1 line
1.7.2.3
#1 lore raw

PATCH 1/1 video: imx-fb: just depend on IMX_HAVE_PLATFORM_IMX_FB

Quoted 10 lines · Uwe Kleine-K??nig

All machines having a imx-fb device now select IMX_HAVE_PLATFORM_IMX_FB, so HAVE_FB_IMX can go away and there is no need anymore to explicitly depend on ARCH_MX1 or ARCH_MX2.

Signed-off-by Uwe Kleine-K??nig <[email protected]>

---
Hello,

should this go via Sascha's or Paul's tree?

There shouldn't be anything it conflicts with in my tree, so it can go via either. Most of the imx changes have bypassed the fbdev tree, so I'm unaware if there are outstanding patches in Sascha's tree at the moment or not. I can of course take it though.

author
#2 lore raw

PATCH 1/1 video: imx-fb: just depend on IMX_HAVE_PLATFORM_IMX_FB

Quoted 9 lines · Paul Mundt
Quoted 8 lines · Uwe Kleine-K??nig

All machines having a imx-fb device now select IMX_HAVE_PLATFORM_IMX_FB, so HAVE_FB_IMX can go away and there is no need anymore to explicitly depend on ARCH_MX1 or ARCH_MX2.

Signed-off-by Uwe Kleine-K??nig <[email protected]>

---
Hello,

Quoted 6 lines
Quoted 2 lines

should this go via Sascha's or Paul's tree?

There shouldn't be anything it conflicts with in my tree, so it can go via either. Most of the imx changes have bypassed the fbdev tree, so I'm unaware if there are outstanding patches in Sascha's tree at the moment or not. I can of course take it though.

I currently collect imx patches for Sascha because he is busy doing other stuff. Can I have your ack for the patch that Baruch pointed out? Then I'd take it for the imx tree.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#3 lore raw

PATCH 1/1 video: imx-fb: just depend on IMX_HAVE_PLATFORM_IMX_FB

Quoted 12 lines · Uwe Kleine-K?nig
Quoted 11 lines · Paul Mundt
Quoted 10 lines · Uwe Kleine-K??nig

All machines having a imx-fb device now select IMX_HAVE_PLATFORM_IMX_FB, so HAVE_FB_IMX can go away and there is no need anymore to explicitly depend on ARCH_MX1 or ARCH_MX2.

Signed-off-by Uwe Kleine-K??nig <[email protected]>

---
Hello,

should this go via Sascha's or Paul's tree?

Quoted 8 lines
Quoted 4 lines

There shouldn't be anything it conflicts with in my tree, so it can go via either. Most of the imx changes have bypassed the fbdev tree, so I'm unaware if there are outstanding patches in Sascha's tree at the moment or not. I can of course take it though.

I currently collect imx patches for Sascha because he is busy doing other stuff. Can I have your ack for the patch that Baruch pointed out? Then I'd take it for the imx tree.

That's fine for this, but in the future it would be nice to have changes that impact the fb driver go through the fb tree. In cases like this where you have clear interdependencies in Kconfig language it obviously doesn't make much sense to split things up, but it's something to keep in mind for the things that can be.

Acked-by Paul Mundt <[email protected]>
#4 lore raw

PATCH 1/1 video: imx-fb: just depend on IMX_HAVE_PLATFORM_IMX_FB

In reply to Uwe Kleine-König

Hi Uwe,

Quoted 2 lines · Uwe Kleine-K?nig

I currently collect imx patches for Sascha because he is busy doing other stuff.

Can you take the following one then? I need this to enable multiple NAND chips on i.MX25.

http://article.gmane.org/gmane.linux.ports.arm.kernel/110313

baruch

Signature · 3 lines
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
author
#5 lore raw

PATCH 1/1 video: imx-fb: just depend on IMX_HAVE_PLATFORM_IMX_FB

Hi Baruch,

[trimmed Cc:]

Quoted 8 lines · Baruch Siach
Quoted 2 lines · Uwe Kleine-K?nig

I currently collect imx patches for Sascha because he is busy doing other stuff.

Can you take the following one then? I need this to enable multiple NAND chips on i.MX25.

http://article.gmane.org/gmane.linux.ports.arm.kernel/110313

I already have that in my tree.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
author
#7 lore raw

PATCH 1/1 video: imx-fb: just depend on IMX_HAVE_PLATFORM_IMX_FB

Hi Fabio,

Quoted 9 lines · Fabio Estevam

2011/4/7 Uwe Kleine-K?nig <[email protected]>:
...

Quoted 5 lines
Quoted 4 lines

Can you take the following one then? I need this to enable multiple NAND chips on i.MX25.

http://article.gmane.org/gmane.linux.ports.arm.kernel/110313

I already have that in my tree.

Could you please point us to your git tree?

It's still on a machine that you can only reach if you hack the Pengutronix network. I hope to get it finally sorted on Monday that I can push it to my public tree (or let Sascha push it to the imx repo).

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#8 lore raw

PATCH 1/1 video: imx-fb: just depend on IMX_HAVE_PLATFORM_IMX_FB

In reply to Uwe Kleine-König

Hi Uwe,

Quoted 6 lines · Uwe Kleine-K?nig

All machines having a imx-fb device now select IMX_HAVE_PLATFORM_IMX_FB, so HAVE_FB_IMX can go away and there is no need anymore to explicitly depend on ARCH_MX1 or ARCH_MX2.

Signed-off-by Uwe Kleine-K?nig <[email protected]>

---

Sascha has already sent a patch for this. See
http://article.gmane.org/gmane.linux.ports.arm.kernel/109067.

baruch

Quoted 47 lines

Hello,

should this go via Sascha's or Paul's tree?

Best regards
Uwe

 arch/arm/plat-mxc/devices/Kconfig |    1 -
 drivers/video/Kconfig             |    5 +----
 2 files changed, 1 insertions(+), 5 deletions(-)
arch/arm/plat-mxc/devices/Kconfig +0 -1
index b9ab1d5..e4dcf49 100644
@@ -24,7 +24,6 @@ config IMX_HAVE_PLATFORM_IMXDI_RTC
 
 config IMX_HAVE_PLATFORM_IMX_FB
 	bool
-	select HAVE_FB_IMX
 
 config IMX_HAVE_PLATFORM_IMX_I2C
 	bool
drivers/video/Kconfig +1 -4
index e6a8d8c..62f337a 100644
@@ -8,9 +8,6 @@ menu "Graphics support"
 config HAVE_FB_ATMEL
 	bool
 
-config HAVE_FB_IMX
-	bool
-
 config SH_MIPI_DSI
 	tristate
 	depends on (SUPERH || ARCH_SHMOBILE) && HAVE_CLK

@@ -359,7 +356,7 @@ config FB_SA1100
 
 config FB_IMX
 	tristate "Freescale i.MX LCD support"
-	depends on FB && (HAVE_FB_IMX || ARCH_MX1 || ARCH_MX2)
+	depends on FB && IMX_HAVE_PLATFORM_IMX_FB
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
Signature · 3 lines
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
author
#9 lore raw

PATCH 1/1 video: imx-fb: just depend on IMX_HAVE_PLATFORM_IMX_FB

Quoted 7 lines · Baruch Siach

Hi Uwe,

Quoted 4 lines · Uwe Kleine-K?nig

All machines having a imx-fb device now select IMX_HAVE_PLATFORM_IMX_FB, so HAVE_FB_IMX can go away and there is no need anymore to explicitly depend on ARCH_MX1 or ARCH_MX2.

Quoted 5 lines
Quoted 2 lines
Signed-off-by Uwe Kleine-K?nig <[email protected]>

---

Sascha has already sent a patch for this. See
http://article.gmane.org/gmane.linux.ports.arm.kernel/109067.

yeah, this looks more complete. Thanks for pointing that out.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |