Skip to contentSkip to conversation

cfi_flash: use AMD fixups for AMIC (e.g. A29L160A series) too

PATCH New Steffen Sledz 3 participants 6 messages Feb 11, 2011 – Apr 7, 2011 Memory technology devices (MTD)

lore
Share & tools
lore

Steffen Sledz

author
#0 lore raw

PATCH 1/1 cfi_flash: use AMD fixups for AMIC (e.g. A29L160A series) too

Signed-off-by Mario Schuknecht <[email protected]>
Signed-off-by Steffen Sledz <[email protected]>
---
 drivers/mtd/cfi_flash.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/mtd/cfi_flash.c +2 -1
index dd394a8..527a3a5 100644
@@ -1924,7 +1924,8 @@ ulong flash_get_size (phys_addr_t base, int banknum)
 
 		/* Do manufacturer-specific fixups */
 		switch (info->manufacturer_id) {
-		case 0x0001:
+		case 0x0001: /* AMD */
+		case 0x0037: /* AMIC */
 			flash_fixup_amd(info, &qry);
 			break;
 		case 0x001f:
Signature · 1 line
1.7.1
author
#1 lore raw

PATCH 1/1 cfi_flash: use AMD fixups for AMIC (e.g. A29L160A series) too

Am 11.02.2011 15:30, schrieb Steffen Sledz:

Quoted 11 lines
Signed-off-by Mario Schuknecht <[email protected]>
Signed-off-by Steffen Sledz <[email protected]>
---
 drivers/mtd/cfi_flash.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/mtd/cfi_flash.c +0 -0
index dd394a8..527a3a5 100644

drivers/mtd/cfi_flash.c ulong flash_get_size (phys_addr_t base, int banknum) · line 1931

Quoted 9 lines
drivers/mtd/cfi_flash.c +2 -1
@@ -1924,7 +1924,8 @@ ulong flash_get_size (phys_addr_t base, int banknum)
 
 		/* Do manufacturer-specific fixups */
 		switch (info->manufacturer_id) {
-		case 0x0001:
+		case 0x0001: /* AMD */
+		case 0x0037: /* AMIC */
 			flash_fixup_amd(info, &qry);
 			break;
 		case 0x001f:

Ping!

Signature · 7 lines
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz at DResearch.de
Fax: +49 30 515932-299
Gesch?ftsf?hrer: Dr. Michael Weber, Werner M?gle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058
#2 lore raw

PATCH 1/1 cfi_flash: use AMD fixups for AMIC (e.g. A29L160A series) too

Hi Steffen,

Quoted 22 lines · On Monday 21 February 2011 09:30:35 Steffen Sledz wrote:

Am 11.02.2011 15:30, schrieb Steffen Sledz:

Quoted 21 lines
Signed-off-by Mario Schuknecht <[email protected]>
Signed-off-by Steffen Sledz <[email protected]>

---

 drivers/mtd/cfi_flash.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/mtd/cfi_flash.c +2 -1
index dd394a8..527a3a5 100644
@@ -1924,7 +1924,8 @@ ulong flash_get_size (phys_addr_t base, int
 banknum)
 
 		/* Do manufacturer-specific fixups */
 		switch (info->manufacturer_id) {
 
-		case 0x0001:
+		case 0x0001: /* AMD */
+		case 0x0037: /* AMIC */
Quoted 5 lines

drivers/mtd/cfi_flash.c ulong flash_get_size (phys_addr_t base, int banknum) · line 1931

Quoted 4 lines
drivers/mtd/cfi_flash.c +0 -0
 			flash_fixup_amd(info, &qry);
 			break;
 
 		case 0x001f:

Ping!

This patch is not really a bug-fix. So I have it queued for the upcoming "next" branch (will open with -rc2).

But I do have a small question about the patch: Who is the author of this patch? You (Steffen) or Mario? If its Mario, then you should add a "From:
Mario Schuknecht <[email protected]>" line at the beginning of the mail body. If its yourself, then you should switch the Signed-off-by lines (author should be the first here).

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

author
#3 lore raw

PATCH 1/1 cfi_flash: use AMD fixups for AMIC (e.g. A29L160A series) too

Am 21.02.2011 11:14, schrieb Stefan Roese:

Quoted 11 lines

Hi Steffen,

Quoted 5 lines · On Monday 21 February 2011 09:30:35 Steffen Sledz wrote:

Am 11.02.2011 15:30, schrieb Steffen Sledz:

Quoted 3 lines
Signed-off-by Mario Schuknecht <[email protected]>
Signed-off-by Steffen Sledz <[email protected]>

...

Ping!

This patch is not really a bug-fix. So I have it queued for the upcoming "next" branch (will open with -rc2).

OK, no problem.

Quoted 5 lines

But I do have a small question about the patch: Who is the author of this patch? You (Steffen) or Mario? If its Mario, then you should add a "From:
Mario Schuknecht <[email protected]>" line at the beginning of the mail body. If its yourself, then you should switch the Signed-off-by lines (author should be the first here).

Mario is the main author. I'll send an update to the patch.

Steffen

Signature · 7 lines
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz at DResearch.de
Fax: +49 30 515932-299
Gesch?ftsf?hrer: Dr. Michael Weber, Werner M?gle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058
#4 lore raw

PATCH v2 1/1 cfi_flash: use AMD fixups for AMIC (e.g. A29L160A series) too

In reply to Steffen Sledz
Signed-off-by Mario Schuknecht <[email protected]>
Signed-off-by Steffen Sledz <[email protected]>
---
 drivers/mtd/cfi_flash.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/mtd/cfi_flash.c +2 -1
index dd394a8..527a3a5 100644
@@ -1924,7 +1924,8 @@ ulong flash_get_size (phys_addr_t base, int banknum)
 
 		/* Do manufacturer-specific fixups */
 		switch (info->manufacturer_id) {
-		case 0x0001:
+		case 0x0001: /* AMD */
+		case 0x0037: /* AMIC */
 			flash_fixup_amd(info, &qry);
 			break;
 		case 0x001f:
Signature · 1 line
1.7.1
#5 lore raw

PATCH v2 1/1 cfi_flash: use AMD fixups for AMIC (e.g. A29L160A series) too

Quoted 2 lines · On Monday 21 February 2011 13:13:14 Mario Schuknecht wrote:
Signed-off-by Mario Schuknecht <[email protected]>
Signed-off-by Steffen Sledz <[email protected]>

Applied to u-boot-cfi-flash. Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de