USB: OHCI: Fix build warning on Alchemy

PATCH In review Ralf Baechle 2 participants 4 messages Apr 13, 2011 – Apr 14, 2011

Subsystems (3)

USB MIPS USB ohci driver

lore

Share & tools

lore

Ralf Baechle

author

2011-04-13 23:24 UTC #0 lore raw

PATCH 1/1 USB: OHCI: Fix build warning on Alchemy

CC drivers/usb/host/ohci-hcd.o
In file included from drivers/usb/host/ohci-hcd.c:1028:0:
drivers/usb/host/ohci-au1xxx.c:36:7: warning: "__BIG_ENDIAN" is not defined [-Wundef]

Fix the warning and some other build bullet proofing; let's not rely on other needed header files getting dragged in magically.

Signed-off-by Ralf Baechle <[email protected]>

---

 drivers/usb/host/ohci-au1xxx.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

drivers/usb/host/ohci-au1xxx.c +5 -2

index 17a6043..0723990 100644
@@ -19,7 +19,10 @@
  */
 
 #include <linux/platform_device.h>
-#include <linux/signal.h>
+#include <linux/interrupt.h>
+#include <linux/usb.h>
+#include <linux/usb/hcd.h>
+#include <asm/byteorder.h>
 
 #include <asm/mach-au1x00/au1000.h>

@@ -33,7 +36,7 @@
 
 #ifdef __LITTLE_ENDIAN
 #define USBH_ENABLE_INIT (USBH_ENABLE_CE | USBH_ENABLE_E | USBH_ENABLE_C)
-#elif __BIG_ENDIAN
+#elif defined(__BIG_ENDIAN)
 #define USBH_ENABLE_INIT (USBH_ENABLE_CE | USBH_ENABLE_E | USBH_ENABLE_C | \
 			  USBH_ENABLE_BE)
 #else

Greg KH

2011-04-13 23:44 UTC #1 lore raw

Quoted 6 lines · Ralf Baechle

CC drivers/usb/host/ohci-hcd.o
In file included from drivers/usb/host/ohci-hcd.c:1028:0:
drivers/usb/host/ohci-au1xxx.c:36:7: warning: "__BIG_ENDIAN" is not defined [-Wundef]
Fix the warning and some other build bullet proofing; let's not rely on other needed header files getting dragged in magically.

Ick, I just applied the second part of this patch to my "for-linus" tree as a patch from someone else. Are the #include changes really needed right now?

thanks,

greg k-h

Ralf Baechle

author

2011-04-14 00:32 UTC #2 lore raw

Quoted 11 lines · Greg KH

Quoted 6 lines · Ralf Baechle
CC drivers/usb/host/ohci-hcd.o
In file included from drivers/usb/host/ohci-hcd.c:1028:0:
drivers/usb/host/ohci-au1xxx.c:36:7: warning: "__BIG_ENDIAN" is not defined [-Wundef]
Fix the warning and some other build bullet proofing; let's not rely on other needed header files getting dragged in magically.
Ick, I just applied the second part of this patch to my "for-linus" tree as a patch from someone else. Are the #include changes really needed right now?

No, the include stuff was more for paranoia.

However the warning fixed by the 2nd part of the patch exists back to at least 2.6.27.

Ralf

Greg KH

2011-04-14 02:24 UTC #3 lore raw

Quoted 10 lines · Ralf Baechle

Quoted 8 lines · Greg KH
Quoted 6 lines · Ralf Baechle
CC drivers/usb/host/ohci-hcd.o
In file included from drivers/usb/host/ohci-hcd.c:1028:0:
drivers/usb/host/ohci-au1xxx.c:36:7: warning: "__BIG_ENDIAN" is not defined [-Wundef]
Fix the warning and some other build bullet proofing; let's not rely on other needed header files getting dragged in magically.

Quoted 8 lines

Quoted 3 lines
Ick, I just applied the second part of this patch to my "for-linus" tree as a patch from someone else. Are the #include changes really needed right now?
No, the include stuff was more for paranoia.
However the warning fixed by the 2nd part of the patch exists back to at least 2.6.27.

Ah, it's not that much of a rush then :)

thanks,

greg k-h