Skip to contentSkip to conversation

powerpc: Fix kexec-related UP build error

PATCH In review Paul E. McKenney 2 participants 3 messages Apr 15, 2011

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: Fix kexec-related UP build error

Hello!

The following patch fixes a UP build problem for kexec() on powerpc. When the crash_kexec_wait_realmode() function was added, it was placed in only two of the three required locations.

Thoughts?

Thanx, Paul

------------------------------------------------------------------------

The function crash_kexec_wait_realmode() is defined only if SMP, but is called in UP builds. Create an empty function to keep the compiler happy in UP builds.

arch/powerpc/kernel/crash.c +4 -0
index 3d3d416..6f964ef 100644
@@ -251,6 +251,10 @@ static void crash_kexec_prepare_cpus(int cpu)
 #endif
 }
 
+static void crash_kexec_wait_realmode(int cpu)
+{
+}
+
 void crash_kexec_secondary(struct pt_regs *regs)
 {
 	cpus_in_sr = CPU_MASK_NONE;
#1 lore raw

Hi Paul,

Quoted 5 lines · Paul E. McKenney

Hello!

The following patch fixes a UP build problem for kexec() on powerpc. When the crash_kexec_wait_realmode() function was added, it was placed in only two of the three required locations.

I believe the fix has already been posted as

http://lists.ozlabs.org/pipermail/linuxppc-dev/2011-April/089559.html

Thanks,
Nish

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#2 lore raw
Quoted 5 lines · Nishanth Aravamudan

Hi Paul,

Quoted 2 lines · Paul E. McKenney

Hello!

Quoted 7 lines
Quoted 3 lines

The following patch fixes a UP build problem for kexec() on powerpc. When the crash_kexec_wait_realmode() function was added, it was placed in only two of the three required locations.

I believe the fix has already been posted as

http://lists.ozlabs.org/pipermail/linuxppc-dev/2011-April/089559.html

So it has! Thank you for the pointer.

Thanx, Paul