drivers:regulator:change the dev_dbg in the probe function
PATCH 1/1 drivers:regulator:change the dev_dbg in the probe function
From: Wanlong Gao <[email protected]>
change the function name string to "%s".
--- drivers/regulator/mc13783-regulator.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/regulator/mc13783-regulator.c +1 -1
@@ -341,7 +341,7 @@ static int __devinit mc13783_regulator_probe(struct platform_device *pdev)struct mc13783_regulator_init_data *init_data;int i, ret; -dev_dbg (&pdev->dev,"mc13783_regulator_probe id %d\n" , pdev->id); +dev_dbg (&pdev->dev,"%s id %d\n" , __func__, pdev->id); priv = kzalloc(sizeof(*priv) + pdata->num_regulators * sizeof(priv->regulators[0]),
Signature · 1 line
1.7.3
On Sat, Apr 16, 2011 at 11:42:23PM +0800, [email protected] wrote:
Please ensure that you use subject lines for your patch which fit in with the style of other changes to the subsystem.
Quoted 1 line
change the function name string to "%s".
You should also explain why a change is being made, not what the change is (we can see that from the patch). In this case what you're doing is making this debug statement be consistent with the style of the rest of the file.
PATCH 1/1 drivers:regulator:change debug statement be consistent with the style of the rest.
change the "mc13783_regulator_probe" string in the function "mc13783_regulator_probe" to "__func__" for the debug statement be consistent with the style of the rest of the file.
--- drivers/regulator/mc13783-regulator.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/regulator/mc13783-regulator.c +1 -1
@@ -341,7 +341,7 @@ static int __devinit mc13783_regulator_probe(struct platform_device *pdev)struct mc13783_regulator_init_data *init_data;int i, ret; -dev_dbg (&pdev->dev,"mc13783_regulator_probe id %d\n" , pdev->id); +dev_dbg (&pdev->dev,"%s id %d\n" , __func__, pdev->id); priv =kzalloc (sizeof (*priv) + pdata->num_regulators *
sizeof(priv->regulators[0]),
Signature · 1 line
1.7.3
Re: [PATCH] drivers:regulator:change debug statement be consistent with the style of the rest.
Quoted 10 lines · Wanlong Gao
change the "
mc13783_regulator_probe" string in the function "mc13783_regulator_probe"
to "__func__" for the debug statement be consistent with the style of the rest of
the file.Signed-off-by Wanlong Gao <[email protected]>Acked-by Mark Brown <[email protected]>
Hi Wanlong,
I really wanna know have Mark given this patch a 'Acked-by'.
Because you are the first one, who sent this patch. Of course, Mark maybe your workmate or else.
I am so sorry for this silly question :) but i am curious
about it.
Thanks.
Harry Wei.
Re: [PATCH] drivers:regulator:change debug statement be consistent with the style of the rest.
Quoted 18 lines · Harry Wei
Quoted 10 lines · Wanlong Gao
change the "
mc13783_regulator_probe" string in the function "mc13783_regulator_probe"
to "__func__" for the debug statement be consistent with the style of the rest of
the file.Signed-off-by Wanlong Gao<[email protected]>Acked-by Mark Brown<[email protected]>Hi Wanlong,
I really wanna know have Mark given this patch a 'Acked-by'.
Because you are the first one, who sent this patch. Of course, Mark maybe your workmate or else.
I am so sorry for this silly question :) but i am curious
about it.
Quoted 2 lines
Thanks.
Harry Wei.
It just a resend patch which had already acked-by Make. You had missed my patch before .
Thanks
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [PATCH] drivers:regulator:change debug statement be consistent with the style of the rest.
Quoted 10 lines · harryxiyou
Quoted 10 lines
Quoted 10 lines
Quoted 3 lines
Signed-off-by Wanlong Gao<[email protected]>Acked-by Mark Brown<[email protected]>Hi Wanlong,
I really wanna know have Mark given this patch a 'Acked-by'.
Because you are the first one, who sent this patch. Of course, Mark maybe your workmate or else.
I am so sorry for this silly question :) but i am curious
about it.
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
Thanks.
Harry Wei.It just a resend patch which had already acked-by Make. You had missed my patch before .
Thanks
Hmmm..., i see.
Thanks.
Harry Wei.
Jiri Kosina
AppliedRe: [PATCH] drivers:regulator:change debug statement be consistent with the style of the rest.
In reply to Wanlong GaoQuoted 29 lines · Wanlong Gao
change the "
mc13783_regulator_probe" string in the function "mc13783_regulator_probe"
to "__func__" for the debug statement be consistent with the style of the rest of
the file.Signed-off-by Wanlong Gao <[email protected]>Acked-by Mark Brown <[email protected]>--- drivers/regulator/mc13783-regulator.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/regulator/mc13783-regulator.c +1
-1@@ -341,7 +341,7 @@ static int __devinit mc13783_regulator_probe(struct platform_device *pdev)struct mc13783_regulator_init_data *init_data;int i, ret; -dev_dbg (&pdev->dev,"mc13783_regulator_probe id %d\n" , pdev->id); +dev_dbg (&pdev->dev,"%s id %d\n" , __func__, pdev->id); priv = kzalloc(sizeof(*priv) +
Quoted 1 line
pdata->num_regulators * sizeof(priv->regulators[0]),
Applied.
BTW, your mailer is damaging the in-line patches. I have fixed this now, but please fix that for your future submissions.
Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs
Re: [PATCH] drivers:regulator:change debug statement be consistent with the style of the rest.
Quoted 35 lines · 在 2011-05-10二的 10:12 +0200，Jiri Kosina写道：
Quoted 29 lines · Wanlong Gao
change the "
mc13783_regulator_probe" string in the function "mc13783_regulator_probe"
to "__func__" for the debug statement be consistent with the style of the rest of
the file.Signed-off-by Wanlong Gao <[email protected]>Acked-by Mark Brown <[email protected]>--- drivers/regulator/mc13783-regulator.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/regulator/mc13783-regulator.c +1
-1@@ -341,7 +341,7 @@ static int __devinit mc13783_regulator_probe(struct platform_device *pdev)struct mc13783_regulator_init_data *init_data;int i, ret; -dev_dbg (&pdev->dev,"mc13783_regulator_probe id %d\n" , pdev->id); +dev_dbg (&pdev->dev,"%s id %d\n" , __func__, pdev->id); priv = kzalloc(sizeof(*priv) +Quoted 1 line
pdata->num_regulators * sizeof(priv->regulators[0]),Applied.
Quoted 5 lines
BTW, your mailer is damaging the in-line patches. I have fixed this now, but please fix that for your future submissions.
Thanks,
Thanks, and I'll fix it next time.
Wanlong Gao