Skip to contentSkip to conversation

Compiler warning - overriding codec compress type

DISCUSSION Patrick Lai 3 participants 4 messages Apr 18, 2011

lore
Share & tools
lore
#0 lore raw

Hi,

I got a compiler warning soc-core.c: In function 'snd_soc_instantiate_cards' warning: 'compress_type' may be used uninitialized in this function. In reality, compress_type is defined as local variable in snd_soc_instantiate_card().

My kernel version is 2.6.38. Has the warning being addressed in 2.6.39 or 2.6.40 patches? If not, after tracing through the code, I think the fix should look like the following:

list_for_each_entry(codec, &codec_list, list) {
                 if (codec->cache_init)
                         continue;
+               compress_type = 0;
                 /* check to see if we need to override the compress_type */
                 for (i = 0; i < card->num_configs; ++i) {
                         codec_conf = &card->codec_conf[i];

Please advise

Thanks
Patrick

Signature · 2 lines
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
#1 lore raw
Quoted 4 lines · Patrick Lai

I got a compiler warning soc-core.c: In function 'snd_soc_instantiate_cards' warning: 'compress_type' may be used uninitialized in this function. In reality, compress_type is defined as local variable in snd_soc_instantiate_card().

Please note that this warning is merely a tool to find errors in the code; the word "may" indicates that the compilter isn't sure about this.

Quoted 9 lines

I think the fix should look like the following:

list_for_each_entry(codec, &codec_list, list) {
                 if (codec->cache_init)
                         continue;
+               compress_type = 0;
                 /* check to see if we need to override the compress_type */
                 for (i = 0; i < card->num_configs; ++i) {
                         codec_conf = &card->codec_conf[i];

When the for loop does not find an override, the following if() will jump out of the outer list_for_each_entry loop before the compress_type could be used, so it is not actually necessary to initialize this variable; a better way would be to use uninitialized_var.

Quoted 2 lines

My kernel version is 2.6.38. Has the warning being addressed in 2.6.39 or 2.6.40 patches?

... and an even better way is to simplify the logic:
http://git.alsa-project.org/?p=alsa-kernel.git;a=commitdiff;h=3110b8b0206cba978d95895723a3d901fb0f738d

Regards,
Clemens

#2 lore raw
In reply to Patrick Lai
Quoted 4 lines · Patrick Lai

I got a compiler warning soc-core.c: In function 'snd_soc_instantiate_cards' warning: 'compress_type' may be used uninitialized in this function. In reality, compress_type is defined as local variable in snd_soc_instantiate_card().

Please *always* CC relevant maintainers on mails if you want them to be read.

Quoted 3 lines

My kernel version is 2.6.38. Has the warning being addressed in 2.6.39 or 2.6.40 patches? If not, after tracing through the code, I think the fix should look like the following:

This is the sort of question that can easily be answered by building the code... I believe it's not an issue with current code but I've not looked myself.

#3 lore raw
Quoted 3 lines · Mark Brown

Please *always* CC relevant maintainers on mails if you want them to be read.

Will do

Quoted 4 lines

This is the sort of question that can easily be answered by building the code... I believe it's not an issue with current code but I've not looked myself.

Clemens pointed out the patch which addresses the warning.
http://git.alsa-project.org/?p=alsa-kernel.git;a=commitdiff;h=3110b8b0206cba978d95895723a3d901fb0f738d

Quoted 4 lines

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Signature · 2 lines
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.