Skip to contentSkip to conversation

ARM: at91: AT91CAP9 has a macb device

PATCH New Uwe Kleine-König 3 participants 5 messages Apr 19, 2011

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/Microchip (AT91) SoC support
lore
Share & tools
lore

Uwe Kleine-König

author
#0 lore raw

PATCH 1/1 ARM: at91: AT91CAP9 has a macb device

commit

ee621dd (net: atmel_macb Kconfig: remove long dependency line)

replaced a list of several explicit machines in the dependencies of MACB by a single symbol that is selected by the respective machines. ee621dd missed to let ARCH_AT91CAP9 select HAVE_NET_MACB though which is fixed here.

Signed-off-by Uwe Kleine-K?nig <[email protected]>
---
 arch/arm/mach-at91/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-at91/Kconfig +1 -0
index 1939023..2d299bf 100644
@@ -83,6 +83,7 @@ config ARCH_AT91CAP9
 	select CPU_ARM926T
 	select GENERIC_CLOCKEVENTS
 	select HAVE_FB_ATMEL
+	select HAVE_NET_MACB
 
 config ARCH_AT572D940HF
 	bool "AT572D940HF"
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 ARM: at91: AT91CAP9 has a macb device

hi,

Quoted 9 lines

commit

? ? ? ?ee621dd (net: atmel_macb Kconfig: remove long dependency line)

replaced a list of several explicit machines in the dependencies of MACB by a single symbol that is selected by the respective machines. ee621dd missed to let ARCH_AT91CAP9 select HAVE_NET_MACB though which is fixed here.

Signed-off-by Uwe Kleine-K?nig <[email protected]>
Acked-by Andrew Victor <[email protected]>
#2 lore raw

PATCH 1/1 ARM: at91: AT91CAP9 has a macb device

In reply to Uwe Kleine-König
Quoted 9 lines · Uwe Kleine-K?nig

commit

ee621dd (net: atmel_macb Kconfig: remove long dependency line)

replaced a list of several explicit machines in the dependencies of MACB by a single symbol that is selected by the respective machines. ee621dd missed to let ARCH_AT91CAP9 select HAVE_NET_MACB though which is fixed here.

Signed-off-by Uwe Kleine-K?nig <[email protected]>
Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>

Best Regards,
J.

author
#3 lore raw

PATCH 1/1 ARM: at91: AT91CAP9 has a macb device

Quoted 11 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 9 lines · Uwe Kleine-K?nig

commit

ee621dd (net: atmel_macb Kconfig: remove long dependency line)

replaced a list of several explicit machines in the dependencies of MACB by a single symbol that is selected by the respective machines. ee621dd missed to let ARCH_AT91CAP9 select HAVE_NET_MACB though which is fixed here.

Signed-off-by Uwe Kleine-K?nig <[email protected]>
Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>

I don't understand why you reply with a S-o-b. Does that mean you took the patch somehow? If not, I think an Ack would be more appropriate. With path should this patch go? Patch system?

Thanks
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#4 lore raw

PATCH 1/1 ARM: at91: AT91CAP9 has a macb device

Quoted 10 lines · Uwe Kleine-K?nig
Quoted 9 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 8 lines · Uwe Kleine-K?nig

commit

ee621dd (net: atmel_macb Kconfig: remove long dependency line)

replaced a list of several explicit machines in the dependencies of MACB by a single symbol that is selected by the respective machines. ee621dd missed to let ARCH_AT91CAP9 select HAVE_NET_MACB though which is fixed here.

Quoted 5 lines
Quoted 2 lines
Quoted 1 line
Signed-off-by Uwe Kleine-K?nig <[email protected]>
Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>

I don't understand why you reply with a S-o-b. Does that mean you took the patch somehow? If not, I think an Ack would be more appropriate. With path should this patch go? Patch system?

I'll put it via our own tree
and send the pull request end of the week

with other fix

Best Regards,
J.