hda_intel: ALSA HD Audio patch for Intel Panther Point DeviceIDs

PATCH In review Seth Heasley 5 participants 6 messages Apr 20, 2011 – Oct 12, 2012 Sound

lore

Share & tools

lore

Seth Heasley

author

2011-04-20 17:59 UTC #0 lore raw

PATCH 1/1 hda_intel: ALSA HD Audio patch for Intel Panther Point DeviceIDs

This patch adds the HD Audio Controller DeviceIDs for the Intel Panther Point PCH.

Signed-off-by Seth Heasley <[email protected]>

---

sound/pci/hda/hda_intel.c renamed from sound/pci/hda/hda_intel.c.orig +3 -0

@@ -126,6 +126,7 @@
 			 "{Intel, ICH10},"
 			 "{Intel, PCH},"
 			 "{Intel, CPT},"
+			 "{Intel, PPT},"
 			 "{Intel, PBG},"
 			 "{Intel, SCH},"
 			 "{ATI, SB450},"

@@ -2759,6 +2760,8 @@
 	{ PCI_DEVICE(0x8086, 0x1c20), .driver_data = AZX_DRIVER_PCH },
 	/* PBG */
 	{ PCI_DEVICE(0x8086, 0x1d20), .driver_data = AZX_DRIVER_PCH },
+	/* Panther Point */
+	{ PCI_DEVICE(0x8086, 0x1e20), .driver_data = AZX_DRIVER_PCH },
 	/* SCH */
 	{ PCI_DEVICE(0x8086, 0x811b), .driver_data = AZX_DRIVER_SCH },
 	/* Generic Intel */

Takashi Iwai

2011-04-20 19:04 UTC #1 lore raw

At Wed, 20 Apr 2011 10:59:57 -0700,

Quoted 4 lines · Seth Heasley

This patch adds the HD Audio Controller DeviceIDs for the Intel Panther Point PCH.
Signed-off-by Seth Heasley <[email protected]>

Applied now. Thanks.

Takashi

Quoted 21 lines

---

sound/pci/hda/hda_intel.c renamed from sound/pci/hda/hda_intel.c.orig +3 -0

@@ -126,6 +126,7 @@
 			 "{Intel, ICH10},"
 			 "{Intel, PCH},"
 			 "{Intel, CPT},"
+			 "{Intel, PPT},"
 			 "{Intel, PBG},"
 			 "{Intel, SCH},"
 			 "{ATI, SB450},"

@@ -2759,6 +2760,8 @@
 	{ PCI_DEVICE(0x8086, 0x1c20), .driver_data = AZX_DRIVER_PCH },
 	/* PBG */
 	{ PCI_DEVICE(0x8086, 0x1d20), .driver_data = AZX_DRIVER_PCH },
+	/* Panther Point */
+	{ PCI_DEVICE(0x8086, 0x1e20), .driver_data = AZX_DRIVER_PCH },
 	/* SCH */
 	{ PCI_DEVICE(0x8086, 0x811b), .driver_data = AZX_DRIVER_SCH },
 	/* Generic Intel */

Jonathan Nieder

2012-10-09 01:07 UTC #2 lore raw

PATCH 1/1 ALSA: hda - ALSA HD Audio patch for Intel Panther Point DeviceIDs

From: Seth Heasley <[email protected]>
Date: Wed, 20 Apr 2011 10:59:57 -0700

commit d2edeb7c6f1dada8ca7d5c23e42d604e92ae0c76 upstream.

This patch adds the HD Audio Controller DeviceIDs for the Intel Panther Point PCH.

[jn: backported for 2.6.32.y by Ana Guerrero]

Signed-off-by Seth Heasley <[email protected]>

Signed-off-by Takashi Iwai <[email protected]>

Tested-by Ana Guerrero <[email protected]> # EliteBook 8570w

Signed-off-by Jonathan Nieder <[email protected]>

---
Hi Willy and Paul,

Please consider

d2edeb7c6f1d ALSA: hda - ALSA HD Audio patch for Intel Panther Point
DeviceIDs

for application to the 2.6.32.y and 2.6.34.y trees.

It does what it says on the cover. The patch was merged in the 3.0 cycle, so newer stable kernels don't need it. Backported and tested[1] against Debian's 2.6.32.y-based kernel by Ana (cc-ed) -- thanks!

Thoughts of all kinds welcome, as always.

Regards,
Jonathan

[1] http://bugs.debian.org/689928

 sound/pci/hda/hda_intel.c |    3 +++
 1 file changed, 3 insertions(+)

sound/pci/hda/hda_intel.c +3 -0

index 3cf21ffc7c5f..dc812838ea8b 100644
@@ -126,6 +126,7 @@ MODULE_SUPPORTED_DEVICE("{{Intel, ICH6},"
 			 "{Intel, ICH10},"
 			 "{Intel, PCH},"
 			 "{Intel, CPT},"
+			 "{Intel, PPT},"
 			 "{Intel, SCH},"
 			 "{ATI, SB450},"
 			 "{ATI, SB600},"

@@ -2730,6 +2731,8 @@ static DEFINE_PCI_DEVICE_TABLE(azx_ids) = {
 	{ PCI_DEVICE(0x8086, 0x3b57), .driver_data = AZX_DRIVER_ICH },
 	/* CPT */
 	{ PCI_DEVICE(0x8086, 0x1c20), .driver_data = AZX_DRIVER_PCH },
+	/* Panther Point */
+	{ PCI_DEVICE(0x8086, 0x1e20), .driver_data = AZX_DRIVER_PCH },
 	/* SCH */
 	{ PCI_DEVICE(0x8086, 0x811b), .driver_data = AZX_DRIVER_SCH },
 	/* ATI SB 450/600 */

Signature · 1 line

1.7.10.4

Ben Hutchings

2012-10-09 01:55 UTC #3 lore raw

Re: [PATCH 2.6.32.y, 2.6.34.y] ALSA: hda - ALSA HD Audio patch for Intel Panther Point DeviceIDs

Quoted 21 lines · Jonathan Nieder

From: Seth Heasley <[email protected]>
Date: Wed, 20 Apr 2011 10:59:57 -0700
commit d2edeb7c6f1dada8ca7d5c23e42d604e92ae0c76 upstream.
This patch adds the HD Audio Controller DeviceIDs for the Intel Panther Point PCH.
[jn: backported for 2.6.32.y by Ana Guerrero]
Signed-off-by Seth Heasley <[email protected]>
Signed-off-by Takashi Iwai <[email protected]>
Tested-by Ana Guerrero <[email protected]> # EliteBook 8570w
Signed-off-by Jonathan Nieder <[email protected]>
---
Hi Willy and Paul,
Please consider
d2edeb7c6f1d ALSA: hda - ALSA HD Audio patch for Intel Panther Point
DeviceIDs

Quoted 8 lines

for application to the 2.6.32.y and 2.6.34.y trees.
It does what it says on the cover. The patch was merged in the 3.0 cycle, so newer stable kernels don't need it. Backported and tested[1] against Debian's 2.6.32.y-based kernel by Ana (cc-ed) -- thanks!
Thoughts of all kinds welcome, as always.

[...]

I queued up a whole series of device ID updates for Debian stable, as they didn't obviously depend on other changes:

cea310e ALSA: hda_intel: ALSA HD Audio patch for Intel Patsburg DeviceIDs e35d4b1 ALSA: hda: add Vortex86MX PCI ids
0f0714c ALSA: hda - Add support for VMware controller
d2edeb7 ALSA: hda - ALSA HD Audio patch for Intel Panther Point DeviceIDs

(They can be cherry-picked cleanly in the above order.) But if I've missed some post-2.6.32 dependencies then I would like to know.

Ben.

Signature · 2 lines

Ben Hutchings
Who are all these weirdos? - David Bowie, about L-Space IRC channel #afp

Paul Gortmaker

2012-10-09 14:56 UTC #4 lore raw

Re: [PATCH 2.6.32.y, 2.6.34.y] ALSA: hda - ALSA HD Audio patch for Intel Panther Point DeviceIDs

Quoted 32 lines · Ben Hutchings

Quoted 29 lines · Jonathan Nieder
From: Seth Heasley <[email protected]>
Date: Wed, 20 Apr 2011 10:59:57 -0700
commit d2edeb7c6f1dada8ca7d5c23e42d604e92ae0c76 upstream.
This patch adds the HD Audio Controller DeviceIDs for the Intel Panther Point PCH.
[jn: backported for 2.6.32.y by Ana Guerrero]
Signed-off-by Seth Heasley <[email protected]>
Signed-off-by Takashi Iwai <[email protected]>
Tested-by Ana Guerrero <[email protected]> # EliteBook 8570w
Signed-off-by Jonathan Nieder <[email protected]>
---
Hi Willy and Paul,
Please consider
d2edeb7c6f1d ALSA: hda - ALSA HD Audio patch for Intel Panther Point
DeviceIDs
for application to the 2.6.32.y and 2.6.34.y trees.
It does what it says on the cover. The patch was merged in the 3.0 cycle, so newer stable kernels don't need it. Backported and tested[1] against Debian's 2.6.32.y-based kernel by Ana (cc-ed) -- thanks!
Thoughts of all kinds welcome, as always.
[...]

Quoted 7 lines

I queued up a whole series of device ID updates for Debian stable, as they didn't obviously depend on other changes:
cea310e ALSA: hda_intel: ALSA HD Audio patch for Intel Patsburg DeviceIDs e35d4b1 ALSA: hda: add Vortex86MX PCI ids
0f0714c ALSA: hda - Add support for VMware controller
d2edeb7 ALSA: hda - ALSA HD Audio patch for Intel Panther Point DeviceIDs

I found that d2edeb7c6f depends (only trivially, on context) on b686453543f, which makes a blanket class for intel IDs so that "...the driver will work
with any new control chips in future." In that respect, I guess it too
(b68645) is in the same class as the other "add more IDs" patches?

Paul.
--

Quoted 6 lines

(They can be cherry-picked cleanly in the above order.) But if I've missed some post-2.6.32 dependencies then I would like to know.
Ben.

Ben Hutchings

2012-10-12 01:23 UTC #5 lore raw

Re: [PATCH 2.6.32.y, 2.6.34.y] ALSA: hda - ALSA HD Audio patch for Intel Panther Point DeviceIDs

Quoted 41 lines · Paul Gortmaker

Quoted 32 lines · Ben Hutchings
Quoted 29 lines · Jonathan Nieder
From: Seth Heasley <[email protected]>
Date: Wed, 20 Apr 2011 10:59:57 -0700
commit d2edeb7c6f1dada8ca7d5c23e42d604e92ae0c76 upstream.
This patch adds the HD Audio Controller DeviceIDs for the Intel Panther Point PCH.
[jn: backported for 2.6.32.y by Ana Guerrero]
Signed-off-by Seth Heasley <[email protected]>
Signed-off-by Takashi Iwai <[email protected]>
Tested-by Ana Guerrero <[email protected]> # EliteBook 8570w
Signed-off-by Jonathan Nieder <[email protected]>
---
Hi Willy and Paul,
Please consider
d2edeb7c6f1d ALSA: hda - ALSA HD Audio patch for Intel Panther Point
DeviceIDs
for application to the 2.6.32.y and 2.6.34.y trees.
It does what it says on the cover. The patch was merged in the 3.0 cycle, so newer stable kernels don't need it. Backported and tested[1] against Debian's 2.6.32.y-based kernel by Ana (cc-ed) -- thanks!
Thoughts of all kinds welcome, as always.
[...]
Quoted 7 lines
I queued up a whole series of device ID updates for Debian stable, as they didn't obviously depend on other changes:
cea310e ALSA: hda_intel: ALSA HD Audio patch for Intel Patsburg DeviceIDs e35d4b1 ALSA: hda: add Vortex86MX PCI ids
0f0714c ALSA: hda - Add support for VMware controller
d2edeb7 ALSA: hda - ALSA HD Audio patch for Intel Panther Point DeviceIDs

Quoted 4 lines

I found that d2edeb7c6f depends (only trivially, on context) on b686453543f, which makes a blanket class for intel IDs so that "...the driver will work
with any new control chips in future." In that respect, I guess it too
(b68645) is in the same class as the other "add more IDs" patches?

Yes, it seems like this would also be worth adding. (Always assuming that any functional changes it depends on are also small enough for stable.) It's not a clean cherry-pick as the line above has changed.

Ben.

Quoted 10 lines

Paul.
--
Quoted 6 lines
(They can be cherry-picked cleanly in the above order.) But if I've missed some post-2.6.32 dependencies then I would like to know.
Ben.

Signature · 3 lines

Ben Hutchings
Kids!  Bringing about Armageddon can be dangerous.  Do not attempt it in
your own home. - Terry Pratchett and Neil Gaiman, `Good Omens'