Skip to contentSkip to conversation

gpiolib: export gpiochip_find

PATCH Applied Jean Delvare 2 participants 5 messages Apr 16, 2011 – May 16, 2011 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpiolib: export gpiochip_find

Export function gpiochip_find so that modules can use it.

---
I need this to add support for SMBus multiplexing on my Asus Z8NA-D6 board.

 drivers/gpio/gpiolib.c |    1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpiolib.c +1 -0
@@ -1165,6 +1165,7 @@ struct gpio_chip *gpiochip_find(void *da
 
 	return chip;
 }
+EXPORT_SYMBOL_GPL(gpiochip_find);
 
 /* These "optional" allocation calls help prevent drivers from stomping
  * on each other, and help provide better diagnostics in debugfs.
Signature · 1 line
Jean Delvare
#1 lore raw

Hi Grant,

Quoted 1 line · Jean Delvare

Export function gpiochip_find so that modules can use it.

Any problem with this patch? If not, the earlier it gets upstream, the happier I'll be. I think it should even be considered for stable kernel series.

Thanks.

Quoted 20 lines

---
I need this to add support for SMBus multiplexing on my Asus Z8NA-D6 board.

 drivers/gpio/gpiolib.c |    1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpiolib.c +1 -0
@@ -1165,6 +1165,7 @@ struct gpio_chip *gpiochip_find(void *da
 
 	return chip;
 }
+EXPORT_SYMBOL_GPL(gpiochip_find);
 
 /* These "optional" allocation calls help prevent drivers from stomping
  * on each other, and help provide better diagnostics in debugfs.
Signature · 1 line
Jean Delvare
#2 lore raw
In reply to Jean Delvare

Hi Grant,

Quoted 14 lines · Jean Delvare

Export function gpiochip_find so that modules can use it.

---
I need this to add support for SMBus multiplexing on my Asus Z8NA-D6 board.

 drivers/gpio/gpiolib.c |    1 +
 1 file changed, 1 insertion(+)

drivers/gpio/gpiolib.c struct gpio_chip *gpiochip_find(void *da · line 1171

Quoted 7 lines
drivers/gpio/gpiolib.c +1 -0
@@ -1165,6 +1165,7 @@ struct gpio_chip *gpiochip_find(void *da
 
 	return chip;
 }
+EXPORT_SYMBOL_GPL(gpiochip_find);
 
 /* These "optional" allocation calls help prevent drivers from stomping
  * on each other, and help provide better diagnostics in debugfs.

I am sorry to insist, but this patch seems quite straightforward, it shouldn't take long to review. Do you have any problem with it? If not, please apply it. I really would like to have it in kernel 2.6.40, as the rest of my SMBus multiplexing support effort depends on it.

Thanks,

Signature · 1 line
Jean Delvare
Applied
#3 lore raw
Quoted 22 lines · Jean Delvare

Hi Grant,

Quoted 19 lines · Jean Delvare

Export function gpiochip_find so that modules can use it.

---
I need this to add support for SMBus multiplexing on my Asus Z8NA-D6 board.

 drivers/gpio/gpiolib.c |    1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpiolib.c +1 -0
@@ -1165,6 +1165,7 @@ struct gpio_chip *gpiochip_find(void *da
 
 	return chip;
 }
+EXPORT_SYMBOL_GPL(gpiochip_find);
 
Quoted 7 lines

drivers/gpio/gpiolib.c struct gpio_chip *gpiochip_find(void *da · line 1171

Quoted 2 lines
drivers/gpio/gpiolib.c +0 -0
 /* These "optional" allocation calls help prevent drivers from stomping
  * on each other, and help provide better diagnostics in debugfs.

I am sorry to insist, but this patch seems quite straightforward, it shouldn't take long to review. Do you have any problem with it? If not, please apply it. I really would like to have it in kernel 2.6.40, as the rest of my SMBus multiplexing support effort depends on it.

Merged, thanks.

Sorry for the delay. All the activity around UDS and getting the ARM device tree patches into a state ready for merging pretty much eliminated any chance I've had to look at gpio stuff over the last month. :-( I'm trying to get through the backlog now.

g.

#4 lore raw
Quoted 4 lines · Grant Likely

Sorry for the delay. All the activity around UDS and getting the ARM device tree patches into a state ready for merging pretty much eliminated any chance I've had to look at gpio stuff over the last month. :-( I'm trying to get through the backlog now.

I understand, no problem. It's just in time for 2.6.40, as I needed, so it's OK. Thanks!

Signature · 1 line
Jean Delvare