Skip to contentSkip to conversation

KVM-test: Check if guest bootable after reseting several times

PATCH In review Amos Kong 2 participants 2 messages Apr 21, 2011 – Apr 29, 2011 KVM

lore
Share & tools
lore

Amos Kong

author
#0 lore raw

PATCH 1/1 KVM-test: Check if guest bootable after reseting several times

This test comes from a regression bug:
Guest can not found bootable device after reseting several times by monitor command.

---
 client/tests/kvm/tests/system_reset_bootable.py |   29 +++++++++++++++++++++++
 client/tests/kvm/tests_base.cfg.sample          |    7 ++++++
 2 files changed, 36 insertions(+), 0 deletions(-)
 create mode 100755 client/tests/kvm/tests/system_reset_bootable.py
client/tests/kvm/tests/system_reset_bootable.py new file +29 -0
new file mode 100755
index 0000000..ca9fb70
@@ -0,0 +1,29 @@
+import logging, time
+from autotest_lib.client.common_lib import error
+import kvm_test_utils
+
+
+def run_system_reset_bootable(test, params, env):
+    """
+    KVM reset test:
+    1) Boot guest.
+    2) Send some times system_reset monitor command.
+    3) Log into the guest to verify it could normally boot.
+
+    @param test: kvm test object
+    @param params: Dictionary with the test parameters
+    @param env: Dictionary with test environment.
+    """
+    vm = env.get_vm(params["main_vm"])
+    vm.verify_alive()
+    timeout = float(params.get("login_timeout", 240))
+    reset_times = int(params.get("reset_times",20))
+    interval = int(params.get("reset_interval",10))
+    wait_time = int(params.get("wait_time_for_reset",60))
+    time.sleep(wait_time)
+
+    for i in range(reset_times):
+        vm.monitor.cmd("system_reset")
+        time.sleep(interval)
+
+    session = vm.wait_for_login(timeout=timeout)
client/tests/kvm/tests_base.cfg.sample +7 -0
index 7333ed0..ceafebe 100644
@@ -961,6 +961,13 @@ variants:
         sleep_before_reset = 20
         kill_vm_on_error = yes
 
+    - system_reset_bootable:
+        type = system_reset_bootable
+        interval = 1
+        reset_times = 20
+        wait_time_for_reset = 120
+        kill_vm_on_error = yes
+
     - shutdown:     install setup unattended_install.cdrom
         type = shutdown
         shutdown_method = shell
#1 lore raw
Quoted 3 lines · Amos Kong

This test comes from a regression bug:
Guest can not found bootable device after reseting several times by monitor command.

Can you point out the bug number? I really don't expect that we keep integrity of the disk after several resets, at least I wouldn't if it was a bare metal machine... Anyway, I've made some changes to the code, mostly removing unnecessary imports and having some messages explaining what the test is doing... I am just not convinced that this test should pass in all circumstances (I tried here and it does pass, by the way).

Quoted 66 lines

---
 client/tests/kvm/tests/system_reset_bootable.py |   29 +++++++++++++++++++++++ client/tests/kvm/tests_base.cfg.sample          |    7 ++++++

 2 files changed, 36 insertions(+), 0 deletions(-)

 create mode 100755 client/tests/kvm/tests/system_reset_bootable.py

client/tests/kvm/tests/system_reset_bootable.py new file +29 -0
new file mode 100755
index 0000000..ca9fb70
@@ -0,0 +1,29 @@
+import logging, time
+from autotest_lib.client.common_lib import error
+import kvm_test_utils
+
+
+def run_system_reset_bootable(test, params, env):
+    """
+    KVM reset test:
+    1) Boot guest.
+    2) Send some times system_reset monitor command.
+    3) Log into the guest to verify it could normally boot.
+
+    @param test: kvm test object
+    @param params: Dictionary with the test parameters
+    @param env: Dictionary with test environment.
+    """
+    vm = env.get_vm(params["main_vm"])
+    vm.verify_alive()
+    timeout = float(params.get("login_timeout", 240))
+    reset_times = int(params.get("reset_times",20))
+    interval = int(params.get("reset_interval",10))
+    wait_time = int(params.get("wait_time_for_reset",60))
+    time.sleep(wait_time)
+
+    for i in range(reset_times):
+        vm.monitor.cmd("system_reset")
+        time.sleep(interval)
+
+    session = vm.wait_for_login(timeout=timeout)
client/tests/kvm/tests_base.cfg.sample +0 -0
index 7333ed0..ceafebe 100644
@@ -961,6 +961,13 @@ variants:

        sleep_before_reset = 20
        kill_vm_on_error = yes

+    - system_reset_bootable:
+        type = system_reset_bootable
+        interval = 1
+        reset_times = 20
+        wait_time_for_reset = 120
+        kill_vm_on_error = yes
+
    - shutdown:     install setup unattended_install.cdrom type = shutdown
        shutdown_method = shell

_______________________________________________
Autotest mailing list
[email protected]
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest

Signature · 1 line
Lucas