Skip to contentSkip to conversation

"xt_conntrack: warn about use in raw table" and lo packets

DISCUSSION Florian Westphal 2 participants 3 messages Apr 21, 2011 – Apr 27, 2011 netfilter

lore
Share & tools
lore

Florian Westphal

author maintainer
#0 lore raw

The commit a2361c8735e07322023aedc36e4938b35af31eb0 ("netfilter: xt_conntrack: warn about use in raw table") disallows use of -m conntrack in the raw table:
"nfct happens to run after the raw table only".

Thats correct, but when the packet was sent from the local machine the skb already has ->nfct attached, and -m conntrack seems to do the right thing.

Is the use of -m conntrack in such a scenario considered invalid?

Thanks,
Florian

#1 lore raw
Quoted 8 lines · Florian Westphal

The commit a2361c8735e07322023aedc36e4938b35af31eb0 ("netfilter: xt_conntrack: warn about use in raw table") disallows use of -m conntrack in the raw table:
"nfct happens to run after the raw table only".

Thats correct, but when the packet was sent from the local machine the skb already has ->nfct attached, and -m conntrack seems to do the right thing.

Hm, I did not consider that. In this case, the patch should be backed out.

#2 lore raw
Quoted 7 lines · Jan Engelhardt
Quoted 5 lines · Florian Westphal

The commit a2361c8735e07322023aedc36e4938b35af31eb0 ("netfilter: xt_conntrack: warn about use in raw table") disallows use of -m conntrack in the raw table:
"nfct happens to run after the raw table only".

Quoted 6 lines
Quoted 3 lines

Thats correct, but when the packet was sent from the local machine the skb already has ->nfct attached, and -m conntrack seems to do the right thing.

Hm, I did not consider that. In this case, the patch should be backed out.

Patrick/Dave - please issue a revert on
a2361c8735e07322023aedc36e4938b35af31eb0 .