Skip to contentSkip to conversation

Remove a warning

PATCH In review Harry Wei 3 participants 4 messages Apr 26, 2011 Staging

lore
Share & tools
lore

Harry Wei

author
#0 lore raw

PATCH 1/1 Remove a warning

Hi us,
When i was compiling kernel, a warning happened to me.
The warning said like following.

drivers/staging/wlan-ng/cfg80211.c:709: warning: initialization from incompatible pointer type

So i patched like this.

From: Harry Wei <[email protected]>

Signed-off-by Harry Wei <[email protected]>
---
 drivers/staging/wlan-ng/cfg80211.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/wlan-ng/cfg80211.c +1 -1
index 6a71f52..7637839 100644
@@ -273,7 +273,7 @@ exit:
 }
 
 int prism2_set_default_key(struct wiphy *wiphy, struct net_device *dev,
-			   u8 key_index)
+			   u8 key_index, bool unicast, bool multicast)
 {
 	wlandevice_t *wlandev = dev->ml_priv;
Signature · 1 line
1.7.0.4
author
#1 lore raw
Quoted 6 lines · Harry Wei

Hi us,
When i was compiling kernel, a warning happened to me.
The warning said like following.

drivers/staging/wlan-ng/cfg80211.c:709: warning: initialization from incompatible pointer type

See http://s1202.photobucket.com/albums/bb364/harrywei/?action=view&current=patched2.png
for more details.

Quoted 28 lines

So i patched like this.

From: Harry Wei <[email protected]>

Signed-off-by Harry Wei <[email protected]>
---
 drivers/staging/wlan-ng/cfg80211.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/wlan-ng/cfg80211.c +1 -1
index 6a71f52..7637839 100644
@@ -273,7 +273,7 @@ exit:
 }
 
 int prism2_set_default_key(struct wiphy *wiphy, struct net_device *dev,
-			   u8 key_index)
+			   u8 key_index, bool unicast, bool multicast)
 {
 	wlandevice_t *wlandev = dev->ml_priv;
Signature · 1 line
1.7.0.4
#2 lore raw
Quoted 15 lines
Quoted 15 lines · Harry Wei
Signed-off-by Harry Wei <[email protected]>
---
 drivers/staging/wlan-ng/cfg80211.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/wlan-ng/cfg80211.c +0 -0
index 6a71f52..7637839 100644
@@ -273,7 +273,7 @@ exit:
 }
Quoted 3 lines

drivers/staging/wlan-ng/cfg80211.c exit: · line 276

Quoted 3 lines
drivers/staging/wlan-ng/cfg80211.c +1 -1
 int prism2_set_default_key(struct wiphy *wiphy, struct net_device *dev,
-			   u8 key_index)
+			   u8 key_index, bool unicast, bool multicast)

It seems can fix the warning .
Thanks

Quoted 14 lines
Quoted 8 lines
drivers/staging/wlan-ng/cfg80211.c +0 -1
 {
 	wlandevice_t *wlandev = dev->ml_priv;
 
--

1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Acked-by on v1 1/1
#3 lore raw
In reply to Harry Wei
Quoted 4 lines · On Tue, 26 Apr 2011 12:38:37 +0800 Harry Wei wrote:

Hi us,
When i was compiling kernel, a warning happened to me.
The warning said like following.

Quoted 8 lines

drivers/staging/wlan-ng/cfg80211.c:709: warning: initialization from incompatible pointer type

So i patched like this.

From: Harry Wei <[email protected]>

Signed-off-by Harry Wei <[email protected]>
Acked-by Randy Dunlap <[email protected]>

Thanks.

Quoted 10 lines
---
 drivers/staging/wlan-ng/cfg80211.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/wlan-ng/cfg80211.c +0 -0
index 6a71f52..7637839 100644

drivers/staging/wlan-ng/cfg80211.c exit: · line 279

Quoted 8 lines
drivers/staging/wlan-ng/cfg80211.c +1 -1
@@ -273,7 +273,7 @@ exit:
 }
 
 int prism2_set_default_key(struct wiphy *wiphy, struct net_device *dev,
-			   u8 key_index)
+			   u8 key_index, bool unicast, bool multicast)
 {
 	wlandevice_t *wlandev = dev->ml_priv;

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***