Skip to contentSkip to conversation

multipath: clear checker message

PATCH In review Benjamin Marzinski 2 participants 2 messages Apr 27, 2011 Device mapper

lore
Share & tools
lore

Benjamin Marzinski

author maintainer
#0 lore raw

PATCH 1/1 multipath: clear checker message

Clear the checker message at the start of get_state, so that stale checker messages aren't accidentally printed.

Signed-off-by Benjamin Marzinski <[email protected]>
---
 libmultipath/checkers.c  |    5 +++++
 libmultipath/checkers.h  |    1 +
 libmultipath/discovery.c |    1 +
 3 files changed, 7 insertions(+)
libmultipath/discovery.c +1 -0
Index: multipath-tools-110412/libmultipath/discovery.c
===================================================================
@@ -848,6 +848,7 @@ get_state (struct path * pp, int daemon)
 			return PATH_UNCHECKED;
 		}
 	}
+	checker_clear_message(c);
 	state = path_offline(pp);
 	if (state != PATH_UP) {
 		condlog(3, "%s: path inaccessible", pp->dev);
libmultipath/checkers.c +5 -0
Index: multipath-tools-110412/libmultipath/checkers.c
===================================================================
@@ -183,6 +183,11 @@ char * checker_message (struct checker *
 	return c->message;
 }
 
+void checker_clear_message (struct checker *c)
+{
+	c->message[0] = '\0';
+}
+
 void checker_get (struct checker * dst, char * name)
 {
 	struct checker * src = checker_lookup(name);
libmultipath/checkers.h +1 -0
Index: multipath-tools-110412/libmultipath/checkers.h
===================================================================
@@ -114,6 +114,7 @@ int checker_check (struct checker *);
 int checker_selected (struct checker *);
 char * checker_name (struct checker *);
 char * checker_message (struct checker *);
+void checker_clear_message (struct checker *c);
 void checker_get (struct checker *, char *);
 
 #endif /* _CHECKERS_H */
#1 lore raw
Quoted 3 lines · Benjamin Marzinski

Clear the checker message at the start of get_state, so that stale checker messages aren't accidentally printed.

doh!
applied, thanks.