Add support for LaCie NAS Network Space v2

PATCH Superseded Simon Guinot 5 participants 14 messages May 1, 2011 – May 2, 2011

Subsystems (4)

Networking Arm (32-bit) Kbuild Memory technology devices (MTD)

lore

Share & tools

lore

Simon Guinot

author

2011-05-01 15:03 UTC #0 lore raw

cover Add support for LaCie NAS Network Space v2

Hi,

This patch series adds support for Network Space v2 board and parents.

Please note that the patch "sf: disable write protection for Macronix flash" is probably not correct. I have no idea how to handle properly the SPI flash protection and any hints are welcome.

Simon Guinot (6):
sf: add support for Macronix MX25L4005A
sf: disable write protection for Macronix flash
Kirkwood: allow to override CONFIG_SYS_TCLK
mv-common.h: fix DRAM banks configuration
netconsole: remove `serverip' check
Add support for Network Space v2

 Makefile                                       |    7 +
 arch/arm/include/asm/arch-kirkwood/kw88f6281.h |    8 +-
 board/LaCie/netspace_v2/Makefile               |   49 +++++++
 board/LaCie/netspace_v2/kwbimage.cfg           |  162 ++++++++++++++++++++++++
 board/LaCie/netspace_v2/netspace_v2.c          |  150 ++++++++++++++++++++++
 board/LaCie/netspace_v2/netspace_v2.h          |   39 ++++++
 drivers/mtd/spi/macronix.c                     |   95 ++++++++++++++
 include/configs/mv-common.h                    |    6 +-
 include/configs/netspace_v2.h                  |  142 +++++++++++++++++++++
 net/net.c                                      |    1 -

Simon Guinot

author

2011-05-01 15:03 UTC #1 lore raw

PATCH 1/6 sf: add support for Macronix MX25L4005A

From: Simon Guinot <[email protected]>

Signed-off-by Simon Guinot <[email protected]>

---
 drivers/mtd/spi/macronix.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

drivers/mtd/spi/macronix.c +8 -0

index ff66f2a..8e4d71c 100644
@@ -71,6 +71,14 @@ static inline struct macronix_spi_flash *to_macronix_spi_flash(struct spi_flash
 
 static const struct macronix_spi_flash_params macronix_spi_flash_table[] = {
 	{
+		.idcode = 0x2013,
+		.page_size = 256,
+		.pages_per_sector = 16,
+		.sectors_per_block = 16,
+		.nr_blocks = 8,
+		.name = "MX25L4005A",
+	},
+	{
 		.idcode = 0x2015,
 		.page_size = 256,
 		.pages_per_sector = 16,

Signature · 1 line

1.6.3.1

Simon Guinot

author

2011-05-01 15:04 UTC #2 lore raw

PATCH 2/6 sf: disable write protection for Macronix flash

In reply to Simon Guinot

From: Simon Guinot <[email protected]>

Signed-off-by Simon Guinot <[email protected]>

---
 drivers/mtd/spi/macronix.c |   87 ++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 87 insertions(+), 0 deletions(-)

drivers/mtd/spi/macronix.c +87 -0

index 8e4d71c..b587ac9 100644
@@ -49,6 +49,10 @@
 #define CMD_MX25XX_DP		0xb9	/* Deep Power-down */
 #define CMD_MX25XX_RES		0xab	/* Release from DP, and Read Signature */
 
+/* Status registers */
+#define MX25XX_SR_BP		(0xF << 2)	/* Block Protect */
+#define MX25XX_SR_SRWP		(1 << 7)	/* Write Protect */
+
 struct macronix_spi_flash_params {
 	u16 idcode;
 	u16 page_size;

@@ -120,6 +124,86 @@ static const struct macronix_spi_flash_params macronix_spi_flash_table[] = {
 	},
 };
 
+static int macronix_write_status(struct spi_flash *flash, u8 sr)
+{
+	u8 cmd[2];
+	int ret;
+
+	ret = spi_flash_cmd(flash->spi, CMD_MX25XX_WREN, NULL, 0);
+	if (ret < 0) {
+		debug("SF: Enabling Write failed\n");
+		return ret;
+	}
+
+	cmd[0] = CMD_MX25XX_WRSR;
+	cmd[1] = sr;
+	ret = spi_xfer(flash->spi, 16, cmd, NULL, SPI_XFER_BEGIN);
+	if (ret) {
+		debug("SF: fail to write status register\n");
+		return ret;
+	}
+
+	spi_xfer(flash->spi, 0, NULL, NULL, SPI_XFER_END);
+
+	ret = spi_flash_cmd_wait_ready(flash, SPI_FLASH_PROG_TIMEOUT);
+	if (ret < 0) {
+		debug("SF: write status register timed out\n");
+		return ret;
+	}
+
+	return 0;
+}
+
+static int macronix_read_status(struct spi_flash *flash, u8 *sr)
+{
+	u8 cmd = CMD_MX25XX_RDSR;
+	int ret;
+
+	ret = spi_xfer(flash->spi, 8, &cmd, NULL, SPI_XFER_BEGIN);
+	if (ret) {
+		debug("SF: Failed to send command %02x: %d\n", cmd, ret);
+		return ret;
+	}
+	ret = spi_xfer(flash->spi, 8, NULL, sr, 0);
+	if (ret) {
+		debug("SF: fail to read status register: %d\n", ret);
+		return ret;
+	}
+
+	spi_xfer(flash->spi, 0, NULL, NULL, SPI_XFER_END);
+
+	return 0;
+}
+
+static int macronix_disable_protect(struct spi_flash *flash)
+{
+	int ret;
+	u8 sr;
+
+	ret = macronix_read_status(flash, &sr);
+	if (ret)
+		return ret;
+
+	if ((sr & MX25XX_SR_BP) == 0)
+		return ret;
+
+	/* Disable status register write protection. */
+	sr &= ~MX25XX_SR_SRWP;
+	ret = macronix_write_status(flash, sr);
+	if (ret)
+		return ret;
+
+	/* Disable block protection. */
+	sr &= ~MX25XX_SR_BP;
+	ret = macronix_write_status(flash, sr);
+	if (ret)
+		return ret;
+
+	printf("SF: disable write protection\n");
+
+	return 0;
+}
+
 static int macronix_write(struct spi_flash *flash,
 			  u32 offset, size_t len, const void *buf)
 {

@@ -223,5 +307,8 @@ struct spi_flash *spi_flash_probe_macronix(struct spi_slave *spi, u8 *idcode)
 		* params->sectors_per_block;
 	mcx->flash.size = mcx->flash.sector_size * params->nr_blocks;
 
+	if (macronix_disable_protect(&mcx->flash))
+		printf("SF: disable write protection failed\n");
+
 	return &mcx->flash;
 }

Signature · 1 line

1.6.3.1

Simon Guinot

author

2011-05-01 15:04 UTC #3 lore raw

PATCH 3/6 Kirkwood: allow to override CONFIG_SYS_TCLK

In reply to Simon Guinot

From: Simon Guinot <[email protected]>

This patch allow to override CONFIG_SYS_TCLK from board configuration files. This is needed for the Network Space v2 which use a non standard core clock frequency (166MHz instead of 200MHz for a 6281 SoC).

As a possible enhancement for 6281 and 6282 devices, TCLK could be dynamically detected by checking the Sample at Reset register bit 21.

Additionally this patch fix a typo.

Signed-off-by Simon Guinot <[email protected]>

---
 arch/arm/include/asm/arch-kirkwood/kw88f6281.h |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

arch/arm/include/asm/arch-kirkwood/kw88f6281.h +5 -3

index 80723ea..22d10f1 100644
@@ -27,11 +27,13 @@
 #ifndef _ASM_ARCH_KW88F6281_H
 #define _ASM_ARCH_KW88F6281_H
 
-/* SOC specific definations */
+/* SOC specific definitions */
 #define KW88F6281_REGS_PHYS_BASE	0xf1000000
 #define KW_REGS_PHY_BASE		KW88F6281_REGS_PHYS_BASE
 
-/* TCLK Core Clock defination*/
-#define CONFIG_SYS_TCLK	  200000000 /* 200MHz */
+/* TCLK Core Clock definition */
+#ifndef CONFIG_SYS_TCLK
+#define CONFIG_SYS_TCLK	200000000 /* 200MHz */
+#endif
 
 #endif /* _ASM_ARCH_KW88F6281_H */

Signature · 1 line

1.6.3.1

Simon Guinot

author

2011-05-01 15:04 UTC #4 lore raw

PATCH 4/6 mv-common.h: fix DRAM banks configuration

In reply to Simon Guinot

From: Simon Guinot <[email protected]>

The asm/arch/config.h header define CONFIG_NR_DRAM_BANKS_MAX, which is needed to configure DRAM banks.

This patch move the asm/arch/config.h header inclusion above the DRAM banks configuration.

Signed-off-by Simon Guinot <[email protected]>

---
 include/configs/mv-common.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

include/configs/mv-common.h +3 -3

index a8937dd..e8f2da0 100644
@@ -113,6 +113,9 @@
 #define CONFIG_SYS_RESET_ADDRESS 0xffff0000	/* Rst Vector Adr */
 #define CONFIG_SYS_MAXARGS	16	/* max number of command args */
 
+/* ====> Include platform Common Definations */
+#include <asm/arch/config.h>
+
 /*
  * DRAM Banks configuration, Custom config can be done in <board>.h
  */

@@ -124,9 +127,6 @@
 #endif
 #endif /* CONFIG_NR_DRAM_BANKS */
 
-/* ====> Include platform Common Definations */
-#include <asm/arch/config.h>
-
 /* ====> Include driver Common Definations */
 /*
  * Common NAND configuration

Signature · 1 line

1.6.3.1

Eric Cooper

2011-05-01 16:11 UTC #5 lore raw

PATCH 4/6 mv-common.h: fix DRAM banks configuration

Quoted 24 lines · Simon Guinot

include/configs/mv-common.h +3 -3

@@ -113,6 +113,9 @@
 #define CONFIG_SYS_RESET_ADDRESS 0xffff0000	/* Rst Vector Adr */
 #define CONFIG_SYS_MAXARGS	16	/* max number of command args */
 
+/* ====> Include platform Common Definations */
+#include <asm/arch/config.h>
+
 /*
  * DRAM Banks configuration, Custom config can be done in <board>.h
  */

@@ -124,9 +127,6 @@
 #endif
 #endif /* CONFIG_NR_DRAM_BANKS */
 
-/* ====> Include platform Common Definations */
-#include <asm/arch/config.h>
-
 /* ====> Include driver Common Definations */
 /*
  * Common NAND configuration

Signature · 1 line

1.6.3.1

You didn't fix the "Definations" typos in this one.

Signature · 1 line

Eric Cooper             e c c @ c m u . e d u

Simon Guinot

2011-05-01 21:38 UTC #6 lore raw

PATCH 4/6 mv-common.h: fix DRAM banks configuration

Hi Eric,

Quoted 17 lines · Eric Cooper

Quoted 16 lines · Simon Guinot

include/configs/mv-common.h +3 -0

@@ -113,6 +113,9 @@
 #define CONFIG_SYS_RESET_ADDRESS 0xffff0000	/* Rst Vector Adr */
 #define CONFIG_SYS_MAXARGS	16	/* max number of command args */
 
+/* ====> Include platform Common Definations */
+#include <asm/arch/config.h>
+
 /*
  * DRAM Banks configuration, Custom config can be done in <board>.h
  */

@@ -124,9 +127,6 @@
 #endif
 #endif /* CONFIG_NR_DRAM_BANKS */

Quoted 10 lines

Quoted 8 lines
include/configs/mv-common.h +0 -3
-/* ====> Include platform Common Definations */
-#include <asm/arch/config.h>
-
 /* ====> Include driver Common Definations */
 /*
  * Common NAND configuration
Signature · 1 line
1.6.3.1
You didn't fix the "Definations" typos in this one.

Sorry, I missed your reply. I will add this fix into the v3.

Thanks,

Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110501/c6cc992e/attachment.pgp

Simon Guinot

author

2011-05-01 15:04 UTC #7 lore raw

PATCH 5/6 netconsole: remove `serverip' check

In reply to Simon Guinot

From: Simon Guinot <[email protected]>

Netconsole use the environment variable ncip' to configure the destination IP. serverip' don't need to be defined.

Signed-off-by Simon Guinot <[email protected]>

---
 net/net.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

net/net.c +0 -1

index e50bdf1..63b4201 100644
@@ -1718,7 +1718,6 @@ static int net_check_prereq (proto_t protocol)
 #if defined(CONFIG_CMD_NFS)
 	case NFS:
 #endif
-	case NETCONS:
 	case TFTP:
 		if (NetServerIP == 0) {
 			puts ("*** ERROR: `serverip' not set\n");

Signature · 1 line

1.6.3.1

Wolfgang Denk

NAK

2011-05-01 15:19 UTC #8 lore raw

PATCH 5/6 netconsole: remove `serverip' check

Dear Simon Guinot,

Quoted 15 lines · In message <[email protected]> you…

From: Simon Guinot <[email protected]>
Netconsole use the environment variable ncip' to configure the destination IP. serverip' don't need to be defined.
Signed-off-by Simon Guinot <[email protected]>
---
 net/net.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
net/net.c +0 -0
index e50bdf1..63b4201 100644

net/net.c static int net_check_prereq (proto_t protocol) · line 1723

Quoted 7 lines

net/net.c +0 -1

@@ -1718,7 +1718,6 @@ static int net_check_prereq (proto_t protocol)
 #if defined(CONFIG_CMD_NFS)
 	case NFS:
 #endif
-	case NETCONS:
 	case TFTP:
 		if (NetServerIP == 0) {
 			puts ("*** ERROR: `serverip' not set\n");

NAK, as this change would also disable the test if NetOurIP == 0, i. e. if our own IP address is set.

Best regards,

Wolfgang Denk

Signature · 4 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Genitiv ins Wasser, weil's Dativ ist!

Simon Guinot

author

2011-05-01 15:04 UTC #9 lore raw

PATCH 6/6 Add support for Network Space v2

In reply to Simon Guinot

From: Simon Guinot <[email protected]>

This patch add support for the Network Space v2 board and parents. This include Network Space (Max) v2 and Internet Space v2.

Signed-off-by Simon Guinot <[email protected]>

---
 Makefile                              |    7 ++
 board/LaCie/netspace_v2/Makefile      |   49 ++++++++++
 board/LaCie/netspace_v2/kwbimage.cfg  |  162 +++++++++++++++++++++++++++++++++
 board/LaCie/netspace_v2/netspace_v2.c |  150 ++++++++++++++++++++++++++++++
 board/LaCie/netspace_v2/netspace_v2.h |   39 ++++++++
 include/configs/netspace_v2.h         |  142 +++++++++++++++++++++++++++++
 6 files changed, 549 insertions(+), 0 deletions(-)
 create mode 100644 board/LaCie/netspace_v2/Makefile
 create mode 100644 board/LaCie/netspace_v2/kwbimage.cfg
 create mode 100644 board/LaCie/netspace_v2/netspace_v2.c
 create mode 100644 board/LaCie/netspace_v2/netspace_v2.h
 create mode 100644 include/configs/netspace_v2.h

Makefile +7 -0

index ada951e..18e6ecd 100644
@@ -897,6 +897,13 @@ TNY_A9260_config	:	unconfig
 	@echo "#define CONFIG_$(@:_config=) 1" >$(obj)include/config.h
 	@$(MKCONFIG) -n $@ -a tny_a9260 arm arm926ejs tny_a9260 calao at91
 
+inetspace_v2_config	\
+netspace_v2_config	\
+netspace_max_v2_config	:	unconfig
+	@mkdir -p $(obj)include
+	@echo "#define CONFIG_$(shell echo $(@:_config=) | tr 'a-z' 'A-Z') 1" >$(obj)include/config.h
+	@$(MKCONFIG) -n $@ -a netspace_v2 arm arm926ejs netspace_v2 LaCie kirkwood
+
 ########################################################################
 ## ARM Integrator boards - see doc/README-integrator for more info.
 integratorap_config	\

board/LaCie/netspace_v2/Makefile new file +49 -0

49 lines not on this page · raw message

board/LaCie/netspace_v2/kwbimage.cfg new file +162 -0

162 lines not on this page · raw message

board/LaCie/netspace_v2/netspace_v2.c new file +150 -0

150 lines not on this page · raw message

board/LaCie/netspace_v2/netspace_v2.h new file +39 -0

new file mode 100644
index 0000000..c26a6e0
@@ -0,0 +1,39 @@
+/*
+ * Copyright (C) 2011 Simon Guinot <[email protected]>
+ *
+ * Based on Kirkwood support:
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Written-by: Prafulla Wadaskar <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef NETSPACE_V2_H
+#define NETSPACE_V2_H
+
+#define NETSPACE_V2_OE_LOW		0x06004000
+#define NETSPACE_V2_OE_HIGH		0x00000031
+#define NETSPACE_V2_OE_VAL_LOW		0x10030000
+#define NETSPACE_V2_OE_VAL_HIGH		0x00000000
+
+/* PHY related */
+#define MV88E1116_LED_FCTRL_REG		10
+#define MV88E1116_CPRSP_CR3_REG		21
+#define MV88E1116_MAC_CTRL_REG		21
+#define MV88E1116_PGADR_REG		22
+#define MV88E1116_RGMII_TXTM_CTRL	(1 << 4)
+#define MV88E1116_RGMII_RXTM_CTRL	(1 << 5)
+
+#endif /* NETSPACE_V2_H */

include/configs/netspace_v2.h new file +142 -0

142 lines not on this page · raw message

Signature · 1 line

1.6.3.1

Wolfgang Denk

2011-05-01 15:26 UTC #10 lore raw

PATCH 6/6 Add support for Network Space v2

Dear Simon Guinot,

Quoted 6 lines · In message <[email protected]> you…

From: Simon Guinot <[email protected]>
This patch add support for the Network Space v2 board and parents. This include Network Space (Max) v2 and Internet Space v2.
Signed-off-by Simon Guinot <[email protected]>

Quoted 13 lines

---
 Makefile                              |    7 ++
 board/LaCie/netspace_v2/Makefile      |   49 ++++++++++
 board/LaCie/netspace_v2/kwbimage.cfg  |  162 +++++++++++++++++++++++++++++++++
 board/LaCie/netspace_v2/netspace_v2.c |  150 ++++++++++++++++++++++++++++++
 board/LaCie/netspace_v2/netspace_v2.h |   39 ++++++++
 include/configs/netspace_v2.h         |  142 +++++++++++++++++++++++++++++
 6 files changed, 549 insertions(+), 0 deletions(-)
 create mode 100644 board/LaCie/netspace_v2/Makefile
 create mode 100644 board/LaCie/netspace_v2/kwbimage.cfg
 create mode 100644 board/LaCie/netspace_v2/netspace_v2.c
 create mode 100644 board/LaCie/netspace_v2/netspace_v2.h
 create mode 100644 include/configs/netspace_v2.h

Entries to MAINTAINERS file missing.

Quoted 5 lines

Makefile +0 -0

index ada951e..18e6ecd 100644

Makefile TNY_A9260_config : unconfig · line 905

Quoted 9 lines

Makefile +6 -0

@@ -897,6 +897,13 @@ TNY_A9260_config	:	unconfig
 	@echo "#define CONFIG_$(@:_config=) 1" >$(obj)include/config.h
 	@$(MKCONFIG) -n $@ -a tny_a9260 arm arm926ejs tny_a9260 calao at91
 
+inetspace_v2_config	\
+netspace_v2_config	\
+netspace_max_v2_config	:	unconfig
+	@mkdir -p $(obj)include
+	@echo "#define CONFIG_$(shell echo $(@:_config=) | tr 'a-z' 'A-Z') 1" >$(obj)include/config.h
+	@$(MKCONFIG) -n $@ -a netspace_v2 arm arm926ejs netspace_v2 LaCie kirkwood

NAK. We don't add boards to Makefile any more. Please add entries to boards.cfg instead.

Makefile TNY_A9260_config : unconfig

Quoted 10 lines

Makefile +10 -0

+int board_init(void)
+{
+	/* Board arch number */
+#if defined(CONFIG_NETSPACE_V2)
+	gd->bd->bi_arch_number = MACH_TYPE_NETSPACE_V2;
+#elif defined(CONFIG_INETSPACE_V2)
+	gd->bd->bi_arch_number = MACH_TYPE_INETSPACE_V2;
+#elif defined(CONFIG_NETSPACE_MAX_V2)
+	gd->bd->bi_arch_number = MACH_TYPE_NETSPACE_MAX_V2;
+#endif

Please get rid of the #ifdef's here and define the MACH_TYPE in your board config file.

...

Quoted 2 lines

Makefile +2 -0

+void mv_phy_88e1116_init(char *name)
+{

...

Makefile

Quoted 1 line

Makefile +1 -0

+	printf("88E1116 Initialized on %s\n", name);

Maybe you want to change this into a debug() instead? [I guess it corrupts the formatting of the boot messages?]

...

Quoted 1 line

+#define CONFIG_SYS_HZ 800

NAK. CONFIG_SYS_HZ must always be 1000.

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are no data that cannot be plotted on a straight  line  if  the
axis are chosen correctly.

Simon Guinot

2011-05-01 20:29 UTC #11 lore raw

PATCH 6/6 Add support for Network Space v2

Hi Wolfgang,

Quoted 8 lines · Wolfgang Denk

...
Quoted 2 lines
(quoted diff) +2 -0
+void mv_phy_88e1116_init(char *name)
+{
...
board/LaCie/netspace_v2/netspace_v2.c line 131
Quoted 1 line
board/LaCie/netspace_v2/netspace_v2.c new file +1 -0
+	printf("88E1116 Initialized on %s\n", name);
Maybe you want to change this into a debug() instead? [I guess it corrupts the formatting of the boot messages?]

Actually no. The boot messages seems to be well formatted:

Net: egiga0
88E1116 Initialized on egiga0
Hit any key to stop autoboot: 0

Anyway, I will turn this message into a debug(). The displayed information is not very useful (and quite redundant with the previous message).

Thanks,

Prafulla Wadaskar

2011-05-02 09:18 UTC #12 lore raw

PATCH 6/6 Add support for Network Space v2

In reply to Simon Guinot

Quoted 9 lines

-----Original Message-----
From: Simon Guinot [mailto:simon.guinot at sequanux.org]
Sent: Sunday, May 01, 2011 8:34 PM
To: Prafulla Wadaskar; Albert ARIBAUD
Cc: u-boot at lists.denx.de; Simon Guinot
Subject: [PATCH 6/6] Add support for Network Space v2

Quoted 4 lines

From: Simon Guinot <[email protected]>
This patch add support for the Network Space v2 board and parents. This include Network Space (Max) v2 and Internet Space v2.

It's good it you can provide any pointer for board information if any.

Quoted 18 lines

Signed-off-by Simon Guinot <[email protected]>

---
 Makefile                              |    7 ++
 board/LaCie/netspace_v2/Makefile      |   49 ++++++++++
 board/LaCie/netspace_v2/kwbimage.cfg  |  162
+++++++++++++++++++++++++++++++++
 board/LaCie/netspace_v2/netspace_v2.c |  150
++++++++++++++++++++++++++++++
 board/LaCie/netspace_v2/netspace_v2.h |   39 ++++++++
 include/configs/netspace_v2.h         |  142
+++++++++++++++++++++++++++++
 6 files changed, 549 insertions(+), 0 deletions(-)
 create mode 100644 board/LaCie/netspace_v2/Makefile
 create mode 100644 board/LaCie/netspace_v2/kwbimage.cfg
 create mode 100644 board/LaCie/netspace_v2/netspace_v2.c
 create mode 100644 board/LaCie/netspace_v2/netspace_v2.h
 create mode 100644 include/configs/netspace_v2.h

I hope these are not clone from existing supported board. If you have 80% similarities, you can use the same source code.

Quoted 16 lines

Makefile +5 -0

index ada951e..18e6ecd 100644
@@ -897,6 +897,13 @@ TNY_A9260_config	:	unconfig
 	@echo "#define CONFIG_$(@:_config=) 1" >$(obj)include/config.h
 	@$(MKCONFIG) -n $@ -a tny_a9260 arm arm926ejs tny_a9260 calao at91
 
+inetspace_v2_config	\
+netspace_v2_config	\
+netspace_max_v2_config	:	unconfig
+	@mkdir -p $(obj)include
+	@echo "#define CONFIG_$(shell echo $(@:_config=) | tr 'a-z' 'A-Z')

1" >$(obj)include/config.h

Makefile +1 -0

+	@$(MKCONFIG) -n $@ -a netspace_v2 arm arm926ejs netspace_v2 LaCie

Quoted 3 lines

kirkwood
+

Please refer better way of doing it.
Ref boards.cfg file in : http://lists.denx.de/pipermail/u-boot/2011-April/091368.html

Regards..
Prafulla . .

Simon Guinot

2011-05-02 10:20 UTC #13 lore raw

PATCH 6/6 Add support for Network Space v2

Quoted 9 lines · Prafulla Wadaskar

Quoted 9 lines
-----Original Message-----
From: Simon Guinot [mailto:simon.guinot at sequanux.org]
Sent: Sunday, May 01, 2011 8:34 PM
To: Prafulla Wadaskar; Albert ARIBAUD
Cc: u-boot at lists.denx.de; Simon Guinot
Subject: [PATCH 6/6] Add support for Network Space v2

Quoted 6 lines

Quoted 4 lines
From: Simon Guinot <[email protected]>
This patch add support for the Network Space v2 board and parents. This include Network Space (Max) v2 and Internet Space v2.
It's good it you can provide any pointer for board information if any.

I can only provide some commercial links and their availability for a long period is not guaranteed.

Quoted 20 lines

Quoted 19 lines

Signed-off-by Simon Guinot <[email protected]>

---
 Makefile                              |    7 ++
 board/LaCie/netspace_v2/Makefile      |   49 ++++++++++
 board/LaCie/netspace_v2/kwbimage.cfg  |  162
+++++++++++++++++++++++++++++++++
 board/LaCie/netspace_v2/netspace_v2.c |  150
++++++++++++++++++++++++++++++
 board/LaCie/netspace_v2/netspace_v2.h |   39 ++++++++
 include/configs/netspace_v2.h         |  142
+++++++++++++++++++++++++++++
 6 files changed, 549 insertions(+), 0 deletions(-)
 create mode 100644 board/LaCie/netspace_v2/Makefile
 create mode 100644 board/LaCie/netspace_v2/kwbimage.cfg
 create mode 100644 board/LaCie/netspace_v2/netspace_v2.c
 create mode 100644 board/LaCie/netspace_v2/netspace_v2.h
 create mode 100644 include/configs/netspace_v2.h

Quoted 2 lines

I hope these are not clone from existing supported board. If you have 80% similarities, you can use the same source code.

No, this boards are not clones from the already supported ones.

Quoted 10 lines

Makefile +0 -0

index ada951e..18e6ecd 100644
@@ -897,6 +897,13 @@ TNY_A9260_config	:	unconfig
 	@echo "#define CONFIG_$(@:_config=) 1" >$(obj)include/config.h
 	@$(MKCONFIG) -n $@ -a tny_a9260 arm arm926ejs tny_a9260 calao at91

Quoted 13 lines

Quoted 10 lines
Makefile +5 -0
+inetspace_v2_config	\
+netspace_v2_config	\
+netspace_max_v2_config	:	unconfig
+	@mkdir -p $(obj)include
+	@echo "#define CONFIG_$(shell echo $(@:_config=) | tr 'a-z' 'A-Z')
1" >$(obj)include/config.h
Makefile +1 -0
+	@$(MKCONFIG) -n $@ -a netspace_v2 arm arm926ejs netspace_v2 LaCie
kirkwood
+
Please refer better way of doing it.
Ref boards.cfg file in : http://lists.denx.de/pipermail/u-boot/2011-April/091368.html

This mistake is fixed since the v2 patch series.

Regards,