staging: hv: make HYPERV_UTILS depend on NLS to prevent a build error
PATCH 1/1 staging: hv: make HYPERV_UTILS depend on NLS to prevent a build error
This patch adds a dependency on NLS to HYPERV_UTILS to avoid a build error.
--- drivers/staging/hv/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/hv/Kconfig +1 -1
@@ -31,7 +31,7 @@ config HYPERV_NET config HYPERV_UTILS tristate "Microsoft Hyper-V Utilities driver" - depends on CONNECTOR + depends on CONNECTOR && NLS default HYPERV help Select this option to enable the Hyper-V Utilities.
Signature · 1 line
1.7.5.rc1
Quoted 1 line · Peter Foley
This patch adds a dependency on NLS to
HYPERV_UTILSto avoid a build error.
What is the build error?
thanks,
greg k-h
Quoted 8 lines · Greg KH
Quoted 1 line · Peter Foley
This patch adds a dependency on NLS to
HYPERV_UTILSto avoid a build error.What is the build error?
thanks,
greg k-h
When CONFIG_HYPERV_UTILS=y and CONFIG_NLS=n
the build fails with this error:
Building modules, stage 2.
MODPOST 3 modules
ERROR: "utf8s_to_utf16s" [drivers/staging/hv/hv_utils.ko] undefined! make[3]: *** [__modpost] Error 1
make[2]: *** [modules] Error 2
make[2]: *** Waiting for unfinished jobs....
Kernel: arch/x86/boot/bzImage is ready (#2)
make[1]: *** [sub-make] Error 2
make: *** [all] Error 2
Quoted 14 lines · Peter Foley
Quoted 8 lines · Greg KH
Quoted 1 line · Peter Foley
This patch adds a dependency on NLS to
HYPERV_UTILSto avoid a build error.What is the build error?
thanks,
greg k-h
When
CONFIG_HYPERV_UTILS=yandCONFIG_NLS=n
the build fails with this error:
Quoted 9 lines
Building modules, stage 2.
MODPOST 3 modules
ERROR: "utf8s_to_utf16s" [drivers/staging/hv/hv_utils.ko] undefined! make[3]: *** [__modpost] Error 1
make[2]: *** [modules] Error 2
make[2]: *** Waiting for unfinished jobs....
Kernel:arch/x86/boot/bzImageis ready (#2)
make[1]: *** [sub-make] Error 2
make: *** [all] Error 2
Ah, ok, we need this for that function, that's what I wanted to know, I'll put it in the changelog entry. Please do that the next time.
thanks,
greg k-h
Quoted 12 lines · Peter Foley
This patch adds a dependency on NLS to
HYPERV_UTILSto avoid a build error.Signed-off-by Peter Foley <[email protected]>--- drivers/staging/hv/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/staging/hv/Kconfig +0
-0
drivers/staging/hv/Kconfig config HYPERV_NET · line 33
Quoted 4 lines
drivers/staging/hv/Kconfig +1
-1@@ -31,7 +31,7 @@ config HYPERV_NET config HYPERV_UTILS tristate "Microsoft Hyper-V Utilities driver" - depends on CONNECTOR + depends on CONNECTOR && NLS
This patch doesn't apply at all, and I can't figure out why. Did your email client somehow mess it up?
Care to resend it, with the proper information in the Changelog entry (i.e. what build error this is fixing) so I can apply it?
thanks,
greg k-h
Quoted 21 lines · Greg KH
Quoted 12 lines · Peter Foley
This patch adds a dependency on NLS to
HYPERV_UTILSto avoid a build error.Signed-off-by Peter Foley <[email protected]>--- drivers/staging/hv/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/staging/hv/Kconfig +0
-0drivers/staging/hv/Kconfig config HYPERV_NET · line 33
Quoted 4 lines
drivers/staging/hv/Kconfig +1
-1@@ -31,7 +31,7 @@ config HYPERV_NET config HYPERV_UTILS tristate "Microsoft Hyper-V Utilities driver" - depends on CONNECTOR + depends on CONNECTOR && NLSThis patch doesn't apply at all, and I can't figure out why. Did your email client somehow mess it up?
Quoted 6 lines
Care to resend it, with the proper information in the Changelog entry (i.e. what build error this is fixing) so I can apply it?
thanks,
greg k-h
Ok, I'll resend it.
I seem to have a problem with my email client corrupting patches. I'm going to try a different one which will hopefully fix the problem.
Thanks,
Peter